mirror of
https://github.com/router-for-me/Cli-Proxy-API-Management-Center.git
synced 2026-11-22 16:37:49 +08:00
* fix(styles): replace undefined CSS custom properties
Three rules read var(--radius-sm), which no stylesheet defines, so those
elements get square corners. Use the $radius-sm Sass variable.
The plugin install gate repository link read var(--accent-color) and
var(--focus-ring-color, var(--accent-color)). Neither is defined, so the
outline is invalid at computed time and the link has no focus ring. Use
var(--primary-color) for the ring, like the other focus outlines, and
var(--text-primary) for the hover color.
Add a test that fails when a var() read has no definition in src.
* test(styles): distinguish required CSS variables from optional reads
---------
(cherry picked from commit 43e35147ac)
Co-authored-by: Aaron Reisman <lifeiscontent@users.noreply.github.com>
58 lines
2.1 KiB
TypeScript
58 lines
2.1 KiB
TypeScript
import { describe, expect, test } from 'bun:test';
|
|
|
|
function findUndefinedReads(files: [string, string][]) {
|
|
const defined = new Set<string>();
|
|
const required = new Map<string, string>();
|
|
|
|
for (const [path, source] of files) {
|
|
const definitions = /\.s?css$/.test(path)
|
|
? [/(?<![\w-])(--[\w-]+)\s*:/g]
|
|
: [/['"](--[\w-]+)['"]\s*:/g, /\.setProperty\(\s*['"`](--[\w-]+)['"`]\s*,/g];
|
|
for (const pattern of definitions) {
|
|
for (const [, name] of source.matchAll(pattern)) defined.add(name);
|
|
}
|
|
// Only calls without a fallback require a definition. Nested var() calls are
|
|
// matched independently, so a required variable inside a fallback is still checked.
|
|
for (const [, name] of source.matchAll(/var\(\s*(--[\w-]+)\s*\)/g)) {
|
|
if (!required.has(name)) required.set(name, path);
|
|
}
|
|
}
|
|
return [...required].filter(([name]) => !defined.has(name));
|
|
}
|
|
|
|
describe('CSS custom properties', () => {
|
|
test('allows optional properties but checks required reads inside fallbacks', () => {
|
|
expect(
|
|
findUndefinedReads([
|
|
[
|
|
'a.css',
|
|
'a { color: var(--optional, currentColor); background: var(--bg, var(--missing)); }',
|
|
],
|
|
])
|
|
).toEqual([['--missing', 'a.css']]);
|
|
});
|
|
|
|
test('counts runtime writes but not reads or removals as definitions', () => {
|
|
expect(
|
|
findUndefinedReads([
|
|
[
|
|
'a.scss',
|
|
'a { --local: red; color: var(--local); padding: var(--inline); top: var(--set); left: var(--typo); }',
|
|
],
|
|
[
|
|
'a.tsx',
|
|
`const style = { '--inline': 1 }; el.style.setProperty('--set', '0'); el.style.getPropertyValue('--typo'); el.style.removeProperty('--typo');`,
|
|
],
|
|
])
|
|
).toEqual([['--typo', 'a.scss']]);
|
|
});
|
|
|
|
test('required var() reads in src have definitions', async () => {
|
|
const files: [string, string][] = [];
|
|
for await (const path of new Bun.Glob('src/**/*.{scss,css,ts,tsx}').scan('.')) {
|
|
files.push([path, await Bun.file(path).text()]);
|
|
}
|
|
expect(findUndefinedReads(files)).toEqual([]);
|
|
});
|
|
});
|