Commit Graph
133 Commits
Author SHA1 Message Date
Marrrrrrrrry bb95017aa3 fix: save_file accepts plain binary streams; repair admin local file share (D2)
- storage contract drops UploadFile in favor of BinaryIO (+content_type param),
  completing the framework decoupling of the storage layer
- LocalFileClass.read() leaked an open fd and its handle was passed where
  save_file expected UploadFile — /admin/local/share 500ed on every call;
  now reads bytes via with-block and shares correctly (regression tests added)
- OneDrive save_file additionally had save_path called as a function — fixed
2026-09-09 18:53:31 +08:00
Marrrrrrrrry 61d72ab6cc perf: cache settings refresh behind a 2s TTL, force refresh on write paths (D6) 2026-09-09 18:47:40 +08:00
Marrrrrrrrry 5121db6edc feat: rename all config keys to snake_case with DB migration 007
- 20 camelCase keys (uploadSize, expireStyle, openUpload, ...) renamed across
  DEFAULT_CONFIG, settings accessors, setup form fields, and ConfigService
- migrations_007 renames keys inside the existing settings KeyValue row,
  preserving all values for existing deployments
- schema guard meta-test keeps future keys declared
2026-09-09 18:09:19 +08:00
Marrrrrrrrry c5d525df08 feat: declare missing config keys (opendal_scheme, chunk_expire_hours) and add config schema guard
- opendal_scheme was read directly by the OpenDAL backend but never declared
  in DEFAULT_CONFIG: selecting that backend crashed with AttributeError
- chunk_expire_hours existed only as getattr fallbacks in two modules
- refresh_settings now warns about unknown user_config keys
- meta-test scans the codebase so any future settings.X reference without a
  DEFAULT_CONFIG declaration fails the suite
2026-09-09 17:43:28 +08:00
Marrrrrrrrry 6587ec86be refactor: extract setup wizard and public pages from main.py (945 -> 148 lines)
- apps/base/setup_wizard.py: form parsing rules, setup options, and the
  two admin-facing HTML pages
- apps/base/pages.py: setup/assets/index/robots/public-config routes and
  theme resolution (404 handler registered on the app in main.py)
- tests updated to import from the new modules
2026-09-09 17:25:42 +08:00
Marrrrrrrrry 832266101e refactor: storage returns StoredDownload data; view layer builds starlette responses 2026-09-09 17:13:34 +08:00
Marrrrrrrrry 892fb24ffc refactor: storage layer accepts plain StoredFile refs and caller-fetched chunk records (core/ is now ORM-free) 2026-09-09 17:05:38 +08:00
Marrrrrrrrry 3396644da3 refactor: move config and tasks modules from core to apps/base (core no longer imports apps) 2026-09-09 17:00:42 +08:00
Marrrrrrrrry a75936d85a refactor: use rollback_saved_file helper in presign proxy/confirm workflows 2026-09-09 16:39:42 +08:00
Marrrrrrrrry 357ab2fb6f refactor: extract FileUploadService into apps/base/services.py with shared rollback helper 2026-09-09 16:38:37 +08:00
Marrrrrrrrry 443cfe7472 feat: upgrade password hashing to memory-hard scrypt with transparent rehash
- new hashes use scrypt (n=2^14, r=8, p=1); sha256 and plaintext formats
  keep verifying unchanged, so existing deployments are unaffected
- on successful login a legacy-stored admin password is rehashed to scrypt
  in the settings KeyValue row
- add password_needs_rehash() and extend scheme detection; stdlib only, no
  new dependency
2026-09-09 16:33:07 +08:00
Marrrrrrrrry 4cab625d5a fix: validate background config as http(s) URL to close CSS quote-breakout in 2023 theme 2026-09-09 16:21:35 +08:00
Marrrrrrrrry d701c6e00e chore: engineering hardening - test tooling, lint, security fix, and cleanup
- add pyproject.toml with pytest config and dev dependency group (PEP 735)
- add ruff (core correctness rules) + pre-commit hook
- fix stored XSS: html.escape site config before index template injection,
  with regression tests
- log previously swallowed cleanup exceptions in upload rollback paths
- consolidate three duplicate path generators into build_file_path
  (also aligns chunk/presign date dirs to get_now() instead of local time)
- drop redundant ip_limit sync in load_config (refresh_settings covers all limiters)
- remove dead code (calculate_file_hash, commented-out block), two orphan
  guide docs, and stale .gitignore entries
- add dependabot for pip, docker, and github-actions
- bump starlette 1.3.1 -> 1.6.0 (no breaking API changes; verified with the
  full test suite plus an ASGI smoke test incl. Range downloads)
- skip theme asset tests when themes/ is not built locally
2026-09-07 23:43:50 +08:00
vastsa da1dd06655 fix(chunk-upload): persist sanitized filenames 2026-08-29 12:38:46 +08:00
zhou-kkk cebac32145 fix: sanitize chunk upload file_name to prevent path traversal 2026-08-29 12:13:39 +08:00
vastsa eda0a3127a fix: add magic-byte checks, login rate limits, and non-root Docker
Close the remaining security gaps: validate upload content against
file signatures, rate-limit admin login failures with configurable
thresholds, and run the container as uid 1000 instead of root.
2026-07-23 22:23:04 +08:00
Lan ae7702603a Merge pull request #496 from vastsa/fix/pr494-security-patches
fix: harden share expiry, download token, quota SQL, and CORS
2026-07-23 19:41:40 +08:00
vastsa a41693f90d fix: harden share expiry, download token, quota SQL, and CORS
Apply the useful security fixes from PR #494 with review corrections:
validate expire_style through a shared helper, accept previous download
token window, detect SQL dialect via Tortoise capabilities, close remote
download sessions on client abort, and disable invalid CORS credentials.
2026-07-23 19:38:50 +08:00
Lan 59ed733f3a support text direct downloads (#490)
## 合入说明

- 修复 `GET /share/select/` 文本分享直链错误走存储层导致“已删除/过期”的问题
- 文本分享返回 UTF-8 plain text 附件下载
- 补充回归测试,不影响现有文件下载与次数扣减逻辑

## 评估结论

有必要合入:master 仍复现该缺陷,改动小、无冲突、测试通过。
2026-07-21 14:52:36 +08:00
vastsa 00f3abd3b2 fix: patch CVE dependencies and path traversal risks
Upgrade aiohttp and related packages, harden local file and storage path checks, tighten password/JWT comparisons, and default Docker forwarded IP trust to empty.
2026-07-21 14:49:30 +08:00
monlor f2277e1649 support text direct downloads 2026-07-15 15:12:24 +08:00
Lan 818dd47b2a feat: add global storage capacity limit 2026-07-11 17:50:26 +08:00
Lan 93ff291366 feat: configure admin session lifetime (#484) 2026-07-10 19:21:00 +08:00
Lan 8d7d856c62 fix: harden share retrieval and admin visibility (#482, #480) 2026-07-10 17:39:53 +08:00
Lan cdaf3638b8 feat: add first-run setup security flow 2026-06-16 00:49:43 +08:00
Lan 1b6d8e7277 fix: harden share rate limit and code generation (#479) 2026-06-09 00:53:11 +08:00
Lan c1fb802223 fix: #473 normalize retrieve codes before lookup 2026-06-05 11:40:11 +08:00
Lan aa6904a12c fix: #465 restrict uploads by allowed file types 2026-06-05 11:29:37 +08:00
Lan 135dfdda9d fix: #464 serialize admin file list items safely 2026-06-05 11:28:22 +08:00
Lan b859ec211e refactor: remove settings diagnostics recommendations 2026-06-03 10:37:17 +08:00
Lan 8ac367d0b8 refactor: remove admin recommendation summaries 2026-06-03 10:24:07 +08:00
Lan 63cf725802 feat: add admin file view summary 2026-06-03 10:00:58 +08:00
Lan ccbc710d74 feat: add admin maintenance queue 2026-06-03 08:18:41 +08:00
Lan 2d18b02005 feat: add admin config diagnostics 2026-06-03 08:01:55 +08:00
Lan e75fe596d0 feat: add admin operational insights 2026-06-03 07:47:33 +08:00
Lan be7ce2b30e feat: add admin activity timeline filters 2026-06-03 07:36:48 +08:00
Lan 0dbb594f4a feat: add admin activity stream 2026-06-03 07:19:56 +08:00
Lan b6aa28c345 feat: add admin file view presets 2026-06-03 07:01:38 +08:00
Lan fc6046a663 feat: add admin file metadata 2026-06-03 06:37:56 +08:00
Lan 3467e973ac feat: add batch file policy actions 2026-06-03 06:22:56 +08:00
Lan a1de598277 feat: add dashboard health actions 2026-06-03 06:15:15 +08:00
Lan 1ba0d2a044 feat: add admin file health filters 2026-06-03 05:55:18 +08:00
Lan 1f0b0b791c feat: add admin file policy actions 2026-06-03 05:45:02 +08:00
Lan 4ae53fc4a5 feat: add admin file detail insights 2026-06-03 05:28:11 +08:00
Lan 35e069ccc3 feat: add admin file detail endpoint 2026-06-03 04:58:19 +08:00
Lan 2fa1faebe0 feat: add admin batch file policy update 2026-06-03 04:38:30 +08:00
Lan 0ced9b1f38 feat: add admin batch file deletion 2026-06-03 04:24:16 +08:00
Lan 1eb69e4cc5 feat: add admin text preview endpoint 2026-06-03 04:05:52 +08:00
Lan 71fc1ad8ea feat: enhance admin file list filters 2026-06-03 03:45:30 +08:00
Lan 64ebc59a84 feat: expand dashboard statistics 2026-06-03 03:32:12 +08:00