Files
FileCodeBox/tests/test_outbound_endpoint_validation.py
vastsa 031d300cae fix: keep Docker as root, close s3_hostname SSRF, unbreak 404 tests
Revert gosu/non-root entrypoint so NAS and root-owned volumes keep
working. Reject @/userinfo in s3_hostname. Theme-less checkouts no
longer crash the HTML 404 handler.
2026-09-20 02:05:57 +08:00

241 lines
8.2 KiB
Python

"""Outbound endpoint SSRF validation (write-entry only).
s3_endpoint_url / s3_hostname / webdav_url are fetched server-side; a
hijacked admin session must not be able to point them at loopback/private
targets. Enforcement applies only with APP_ENV=production so local
development (minio, dev webdav) keeps working; already-stored values are
never re-validated.
"""
import pytest
from core.security import validate_outbound_endpoint, validate_outbound_hostname
@pytest.fixture
def production_env(monkeypatch):
monkeypatch.setenv("APP_ENV", "production")
@pytest.mark.parametrize(
"endpoint",
[
"http://127.0.0.1:9000",
"https://10.0.0.5",
"https://192.168.1.10:9000",
"http://172.16.0.1",
"http://169.254.169.254/latest/meta-data",
"https://localhost:9000",
"https://minio.internal:9000",
"https://nas.local",
"file:///etc/passwd",
"gopher://10.0.0.1",
"ftp://example.com",
"not a url",
],
)
def test_production_rejects_internal_and_bad_scheme_endpoints(production_env, endpoint):
with pytest.raises(ValueError):
validate_outbound_endpoint(endpoint)
@pytest.mark.parametrize(
"endpoint",
[
"",
"https://s3.amazonaws.com",
"https://s3.cn-north-1.amazonaws.com.cn",
"http://example.com:9000",
],
)
def test_production_allows_public_https_endpoints(production_env, endpoint):
assert validate_outbound_endpoint(endpoint) == endpoint
def test_development_env_allows_local_endpoints(monkeypatch):
monkeypatch.setenv("APP_ENV", "development")
assert (
validate_outbound_endpoint("http://127.0.0.1:9000") == "http://127.0.0.1:9000"
)
@pytest.mark.parametrize(
"hostname",
[
"127.0.0.1",
"10.0.0.5",
"192.168.1.10:9000",
"localhost",
"minio.internal",
"nas.local",
],
)
def test_production_rejects_internal_hostnames(production_env, hostname):
with pytest.raises(ValueError):
validate_outbound_hostname(hostname)
@pytest.mark.parametrize(
"hostname",
["", "s3.amazonaws.com", "minio.corp.example.com", "files.example.com:9000"],
)
def test_production_allows_public_hostnames(production_env, hostname):
assert validate_outbound_hostname(hostname) == hostname
def test_hostname_tier_rejects_url_forms(production_env):
"""s3_hostname 是裸主机名字段——传 URL 形态直接拒绝(曾用 URL 校验错误处理它)。"""
with pytest.raises(ValueError):
validate_outbound_hostname("https://s3.amazonaws.com")
with pytest.raises(ValueError):
validate_outbound_hostname("http://127.0.0.1:9000")
def test_hostname_tier_rejects_userinfo(production_env):
"""存储层拼 https://{s3_hostname},@ 会被当成 userinfo,实际连 @ 后的地址。"""
for hostname in ("evil.com@127.0.0.1", "attacker.example@127.0.0.1:8443"):
with pytest.raises(ValueError):
validate_outbound_hostname(hostname)
@pytest.mark.asyncio
class TestChangedOnlyEnforcement:
"""changed-only 集成回归:存量内网 endpoint 不得挡死无关设置保存。
background 校验曾因校验合并后配置而挡死存量用户(上游 #528 修复),
endpoint 校验沿用同一语义——这里用集成层锁死该行为。
"""
async def _login(self, client) -> str:
from tests.conftest import TEST_ADMIN_PASSWORD
response = await client.post(
"/admin/login", json={"password": TEST_ADMIN_PASSWORD}
)
assert response.status_code == 200, response.text
return response.json()["detail"]["token"]
async def test_unchanged_internal_endpoint_passes_and_unrelated_save_ok(
self, initialized_client, monkeypatch
):
monkeypatch.setenv("APP_ENV", "production")
token = await self._login(initialized_client)
headers = {"Authorization": f"Bearer {token}"}
# 存量场景:先在 production 放行前写入了内网 endpoint(模拟旧数据),
# 直接落库;此后 production 下保存同一值 + 无关字段都必须成功。
from apps.base.models import KeyValue
from core.settings import settings
record = await KeyValue.filter(key="settings").first()
config = dict(record.value or {})
config["s3_endpoint_url"] = "http://192.168.1.10:9000"
record.value = config
await record.save()
settings.user_config = config
response = await initialized_client.patch(
"/admin/config/update",
json={"s3_endpoint_url": "http://192.168.1.10:9000", "name": "renamed"},
headers=headers,
)
assert response.status_code == 200, response.text
async def test_changed_to_internal_endpoint_is_rejected(
self, initialized_client, monkeypatch
):
monkeypatch.setenv("APP_ENV", "production")
token = await self._login(initialized_client)
response = await initialized_client.patch(
"/admin/config/update",
json={"s3_endpoint_url": "http://127.0.0.1:9000"},
headers={"Authorization": f"Bearer {token}"},
)
assert response.status_code == 400
async def test_hostname_tier_blocks_internal_target(
self, initialized_client, monkeypatch
):
monkeypatch.setenv("APP_ENV", "production")
token = await self._login(initialized_client)
response = await initialized_client.patch(
"/admin/config/update",
json={"s3_hostname": "minio.internal"},
headers={"Authorization": f"Bearer {token}"},
)
assert response.status_code == 400
@pytest.mark.parametrize(
"value",
[
"https://127.1", # glibc 速记 = 127.0.0.1
"https://2130706433", # 十进制整数 IP = 127.0.0.1
"https://0x7f.0x0.0x0.0x1", # 十六进制 IP
"https://10.1", # 速记 = 10.0.0.1
"https://127.0.0.1.nip.io", # DNS 映射到 loopback
"https://foo.localhost", # *.localhost 现代解析器指向 loopback
"https://[::1]",
"https://0.0.0.0",
],
)
def test_url_tier_denies_ip_shorthand_and_dns_tricks(production_env, value):
"""静态字符串黑名单对 IP 速记/十六进制/十进制/DNS 映射全部失效——必须解析后复判。"""
with pytest.raises(ValueError):
validate_outbound_endpoint(value)
@pytest.mark.parametrize(
"hostname",
[
"127.1",
"2130706433",
"10.1",
"foo.localhost",
"127.0.0.1.nip.io",
"[::1]",
"[::ffff:127.0.0.1]:9000",
],
)
def test_hostname_tier_denies_ip_shorthand_and_dns_tricks(production_env, hostname):
with pytest.raises(ValueError):
validate_outbound_hostname(hostname)
def test_hostname_tier_accepts_ipv6_with_port_and_public(production_env):
assert validate_outbound_hostname("[2606:4700::1]:9000") == "[2606:4700::1]:9000"
assert validate_outbound_hostname("files.example.com:9000") == "files.example.com:9000"
@pytest.mark.asyncio
class TestNormalizedWriteBack:
async def test_whitespace_padded_endpoint_stored_stripped(
self, initialized_client, monkeypatch
):
monkeypatch.setenv("APP_ENV", "production")
from tests.conftest import TEST_ADMIN_PASSWORD
login = await initialized_client.post(
"/admin/login", json={"password": TEST_ADMIN_PASSWORD}
)
token = login.json()["detail"]["token"]
response = await initialized_client.patch(
"/admin/config/update",
json={"s3_endpoint_url": " https://s3.example.com "},
headers={"Authorization": f"Bearer {token}"},
)
assert response.status_code == 200, response.text
from apps.base.models import KeyValue
record = await KeyValue.filter(key="settings").first()
config = dict(record.value or {})
assert config["s3_endpoint_url"] == "https://s3.example.com"
def test_hostname_tier_development_gate(monkeypatch):
"""hostname 档同样受 APP_ENV 门控(开发环境本地 minio 不被拒)。"""
monkeypatch.setenv("APP_ENV", "development")
assert validate_outbound_hostname("127.0.0.1:9000") == "127.0.0.1:9000"