mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-11-22 21:48:20 +08:00
Copy was broken twice over. `langbot.api()` already resolves the unwrapped
payload (PageResponse.ok -> HTTP data -> resp.data.data -> the SDK's
resolve(data.data)), so `item.data.url` was always `undefined` and the page
copied an empty string. `writeText('')` resolves without throwing, so it also
never reached the fallback: the UI said "copied" while the clipboard stayed
empty.
The iframe is worse than assumed. It is a `blob:` document under
`sandbox="allow-scripts allow-forms"`, so its origin is opaque: `location.origin`
is "null", relative asset URLs do not load, and `navigator.clipboard` rejects
with NotAllowedError. `/list` returns relative URLs while `public_base_url` is
empty, so even a correct value would have pasted as an unusable path. URLs are
now made absolute against `location.ancestorOrigins[0]` before either the
clipboard or an `<img src>`, and copy reads `item.url` from the list cache
instead of making a redundant `/item` round trip.
Every other call had the same layer mistake: `res.error` is never set on a
resolved value, because failures reject the promise, so no failure ever
surfaced. All call sites now catch, and an empty URL toasts an error rather
than claiming success.
Verified in a real blob: iframe with the real sandbox: relative url -> absolute
-> clipboard read back byte for byte, and the same URL loads as the preview
(0 `/image` calls). Also passes with `navigator.clipboard` removed, proving the
execCommand tier is what carries it.
The host is untouched now, so this is plugin-only; the `allow-modals` flip is
dropped and the clear confirmation stays in-page.
Co-authored-by: multica-agent <github@multica.ai>
89 lines
3.0 KiB
Python
89 lines
3.0 KiB
Python
"""UI regressions behind the reported screenshot.
|
|
|
|
Each assertion pins one visible defect from the report: the reversed action
|
|
hierarchy, the name above the preview, the always-visible "load more" button,
|
|
the un-converted kilobyte header, the double count, the missing failure
|
|
placeholder and the unannounced toast.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from pathlib import Path
|
|
|
|
PAGE = Path(__file__).resolve().parents[1] / "components" / "pages" / "hub" / "index.html"
|
|
|
|
|
|
def html() -> str:
|
|
return PAGE.read_text(encoding="utf-8")
|
|
|
|
|
|
def script() -> str:
|
|
return "\n".join(re.findall(r"<script>(.*?)</script>", html(), re.S))
|
|
|
|
|
|
def styles() -> str:
|
|
return re.search(r"<style>(.*?)</style>", html(), re.S).group(1)
|
|
|
|
|
|
def card_markup() -> str:
|
|
body = script()
|
|
start = body.index("'<div class=\"card\"")
|
|
return body[start: body.index("</div>');", start) + 12]
|
|
|
|
|
|
def test_copy_outranks_delete_on_a_card():
|
|
card = card_markup()
|
|
assert 'class="ghost copy"' in card, "copy should carry the primary variant"
|
|
assert 'class="ghost danger"' in card
|
|
# The search strings share the data-action=" prefix, so compare the
|
|
# action names themselves.
|
|
assert card.index('"copy"') < card.index('"delete"')
|
|
|
|
|
|
def test_delete_is_not_painted_solid_red():
|
|
style = styles()
|
|
danger = [ln for ln in style.splitlines() if "button.ghost.danger {" in ln]
|
|
assert danger, "danger state must stay scoped to the ghost variant"
|
|
assert "#ef4444" not in danger[0], "resting delete must not be solid red"
|
|
assert "#dc2626" in "\n".join(
|
|
ln for ln in style.splitlines() if "button.ghost.danger:hover" in ln
|
|
), "hover is what should turn it red"
|
|
|
|
|
|
def test_names_sit_below_the_preview():
|
|
card = card_markup()
|
|
assert card.index('class="thumb"') < card.index('class="name"')
|
|
|
|
|
|
def test_load_more_uses_one_toggle():
|
|
body = script()
|
|
assert "'more').hidden" in body, "the button should toggle the hidden attribute"
|
|
assert "style.display" not in body, "display plus visibility used to fight each other"
|
|
assert "style.visibility" not in body
|
|
|
|
|
|
def test_header_size_is_human_readable():
|
|
body = script()
|
|
assert "display_bytes" in body, "the stats endpoint already formats the size"
|
|
assert "/ 1024).toFixed(1) + ' KB'" in body, "the header must not print raw KB"
|
|
|
|
|
|
def test_total_is_not_counted_twice():
|
|
body = script()
|
|
stats = body[body.index("async function loadStats"): body.index("async function loadList")]
|
|
assert "'{n} 个表情包" not in stats, "the sticker count belongs to the footer only"
|
|
assert "stats', '已用 {used}" in stats
|
|
|
|
|
|
def test_failed_image_falls_back_to_a_placeholder():
|
|
body = script()
|
|
assert "classList.add('failed')" in body
|
|
assert "naturalWidth" in body, "a cached broken image only reports via naturalWidth"
|
|
|
|
|
|
def test_toast_is_announced():
|
|
markup = html()
|
|
assert re.search(r'id="toast"[^>]*aria-live="polite"', markup)
|
|
assert re.search(r'id="toast"[^>]*role="status"', markup)
|