2022-02-08 12:00:44 -06:00
|
|
|
package coderd_test
|
|
|
|
|
|
|
|
|
|
import (
|
2024-01-31 14:49:55 +01:00
|
|
|
"archive/tar"
|
2026-06-02 10:11:49 -07:00
|
|
|
"archive/zip"
|
2023-02-04 14:07:09 -06:00
|
|
|
"bytes"
|
2022-02-08 12:00:44 -06:00
|
|
|
"context"
|
2026-06-02 10:11:49 -07:00
|
|
|
"encoding/binary"
|
|
|
|
|
"io"
|
2022-03-07 11:40:54 -06:00
|
|
|
"net/http"
|
2025-07-30 13:55:30 -07:00
|
|
|
"sync"
|
2022-02-08 12:00:44 -06:00
|
|
|
"testing"
|
|
|
|
|
|
2022-10-13 18:02:52 -05:00
|
|
|
"github.com/google/uuid"
|
2025-09-04 14:28:29 +10:00
|
|
|
"github.com/stretchr/testify/assert"
|
2022-02-08 12:00:44 -06:00
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
|
|
2024-10-25 15:14:39 +01:00
|
|
|
"github.com/coder/coder/v2/archive"
|
|
|
|
|
"github.com/coder/coder/v2/archive/archivetest"
|
2026-06-02 10:11:49 -07:00
|
|
|
"github.com/coder/coder/v2/coderd"
|
2023-08-18 13:55:43 -05:00
|
|
|
"github.com/coder/coder/v2/coderd/coderdtest"
|
|
|
|
|
"github.com/coder/coder/v2/codersdk"
|
|
|
|
|
"github.com/coder/coder/v2/testutil"
|
2022-02-08 12:00:44 -06:00
|
|
|
)
|
|
|
|
|
|
2022-03-07 11:40:54 -06:00
|
|
|
func TestPostFiles(t *testing.T) {
|
2022-02-08 12:00:44 -06:00
|
|
|
t.Parallel()
|
2026-03-23 19:54:43 +00:00
|
|
|
|
2026-06-02 10:11:49 -07:00
|
|
|
buildZipWithFile := func(t *testing.T, name string, writeContents func(w io.Writer) error) []byte {
|
|
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
|
|
var zipBytes bytes.Buffer
|
|
|
|
|
zw := zip.NewWriter(&zipBytes)
|
|
|
|
|
w, err := zw.Create(name)
|
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
require.NoError(t, writeContents(w))
|
|
|
|
|
require.NoError(t, zw.Close())
|
|
|
|
|
|
|
|
|
|
return zipBytes.Bytes()
|
|
|
|
|
}
|
|
|
|
|
|
2026-03-23 19:54:43 +00:00
|
|
|
// Single instance shared across all sub-tests. Each sub-test
|
|
|
|
|
// creates independent resources with unique IDs so parallel
|
|
|
|
|
// execution is safe.
|
|
|
|
|
client := coderdtest.New(t, nil)
|
|
|
|
|
_ = coderdtest.CreateFirstUser(t, client)
|
2022-02-08 12:00:44 -06:00
|
|
|
t.Run("BadContentType", func(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
2022-08-09 20:17:00 +03:00
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
2023-02-04 14:07:09 -06:00
|
|
|
_, err := client.Upload(ctx, "bad", bytes.NewReader([]byte{'a'}))
|
2022-02-08 12:00:44 -06:00
|
|
|
require.Error(t, err)
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
t.Run("Insert", func(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
2022-08-09 20:17:00 +03:00
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
2023-02-04 14:07:09 -06:00
|
|
|
_, err := client.Upload(ctx, codersdk.ContentTypeTar, bytes.NewReader(make([]byte, 1024)))
|
2022-02-08 12:00:44 -06:00
|
|
|
require.NoError(t, err)
|
|
|
|
|
})
|
2022-02-12 13:34:04 -06:00
|
|
|
|
2024-11-08 18:24:12 +11:00
|
|
|
t.Run("InsertWindowsZip", func(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
|
|
|
|
_, err := client.Upload(ctx, "application/x-zip-compressed", bytes.NewReader(archivetest.TestZipFileBytes()))
|
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
})
|
|
|
|
|
|
2022-02-12 13:34:04 -06:00
|
|
|
t.Run("InsertAlreadyExists", func(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
2022-08-09 20:17:00 +03:00
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
2022-02-12 13:34:04 -06:00
|
|
|
data := make([]byte, 1024)
|
2023-02-04 14:07:09 -06:00
|
|
|
_, err := client.Upload(ctx, codersdk.ContentTypeTar, bytes.NewReader(data))
|
2022-02-12 13:34:04 -06:00
|
|
|
require.NoError(t, err)
|
2023-02-04 14:07:09 -06:00
|
|
|
_, err = client.Upload(ctx, codersdk.ContentTypeTar, bytes.NewReader(data))
|
2022-02-12 13:34:04 -06:00
|
|
|
require.NoError(t, err)
|
|
|
|
|
})
|
2026-06-02 10:11:49 -07:00
|
|
|
t.Run("InvalidZipMetadata", func(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
|
|
|
|
|
|
|
|
|
corruptZipUncompressedSize := func(t *testing.T, zipBytes []byte, size uint32) []byte {
|
|
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
|
|
const (
|
|
|
|
|
directoryHeaderSignature = "PK\x01\x02"
|
|
|
|
|
uncompressedSizeOffset = 24
|
|
|
|
|
)
|
|
|
|
|
hdrOffset := bytes.Index(zipBytes, []byte(directoryHeaderSignature))
|
|
|
|
|
require.NotEqual(t, -1, hdrOffset, "missing ZIP central directory header")
|
|
|
|
|
corrupted := bytes.Clone(zipBytes)
|
|
|
|
|
sizeBytes := corrupted[hdrOffset+uncompressedSizeOffset : hdrOffset+uncompressedSizeOffset+4]
|
|
|
|
|
binary.LittleEndian.PutUint32(sizeBytes, size)
|
|
|
|
|
|
|
|
|
|
return corrupted
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
|
|
|
|
zipBytes := buildZipWithFile(t, "hello.txt", func(w io.Writer) error {
|
|
|
|
|
_, err := w.Write([]byte("hello"))
|
|
|
|
|
return err
|
|
|
|
|
})
|
|
|
|
|
zipBytes = corruptZipUncompressedSize(t, zipBytes, 6)
|
|
|
|
|
|
|
|
|
|
_, err := client.Upload(ctx, codersdk.ContentTypeZip, bytes.NewReader(zipBytes))
|
|
|
|
|
var apiErr *codersdk.Error
|
|
|
|
|
require.ErrorAs(t, err, &apiErr)
|
|
|
|
|
require.Equal(t, http.StatusBadRequest, apiErr.StatusCode())
|
|
|
|
|
})
|
2025-07-30 13:55:30 -07:00
|
|
|
t.Run("InsertConcurrent", func(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
|
|
|
|
var wg sync.WaitGroup
|
|
|
|
|
var end sync.WaitGroup
|
|
|
|
|
wg.Add(1)
|
|
|
|
|
end.Add(3)
|
|
|
|
|
for range 3 {
|
|
|
|
|
go func() {
|
|
|
|
|
wg.Wait()
|
|
|
|
|
data := make([]byte, 1024)
|
|
|
|
|
_, err := client.Upload(ctx, codersdk.ContentTypeTar, bytes.NewReader(data))
|
|
|
|
|
end.Done()
|
2025-09-04 14:28:29 +10:00
|
|
|
assert.NoError(t, err)
|
2025-07-30 13:55:30 -07:00
|
|
|
}()
|
|
|
|
|
}
|
|
|
|
|
wg.Done()
|
|
|
|
|
end.Wait()
|
|
|
|
|
})
|
2026-06-02 10:11:49 -07:00
|
|
|
//nolint:paralleltest // This subtest is intentionally serial to
|
|
|
|
|
// avoid extra memory pressure.
|
|
|
|
|
t.Run("OversizedZipExpansion", func(t *testing.T) {
|
|
|
|
|
buildZipWithSizedFile := func(t *testing.T, name string, size int64) []byte {
|
|
|
|
|
return buildZipWithFile(t, name, func(w io.Writer) error {
|
|
|
|
|
chunk := bytes.Repeat([]byte("a"), 32*1024)
|
|
|
|
|
for written := int64(0); written < size; {
|
|
|
|
|
n := len(chunk)
|
|
|
|
|
if remaining := size - written; int64(n) > remaining {
|
|
|
|
|
n = int(remaining)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
_, err := w.Write(chunk[:n])
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
written += int64(n)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
|
|
|
|
// Leave only enough room for the tar trailer. The single
|
|
|
|
|
// entry header then pushes the converted tar output over the
|
|
|
|
|
// file size limit.
|
|
|
|
|
size := int64(coderd.HTTPFileMaxBytes - 1024)
|
|
|
|
|
zipBytes := buildZipWithSizedFile(t, "oversized.txt", size)
|
|
|
|
|
|
|
|
|
|
_, err := client.Upload(ctx, codersdk.ContentTypeZip, bytes.NewReader(zipBytes))
|
|
|
|
|
var apiErr *codersdk.Error
|
|
|
|
|
require.ErrorAs(t, err, &apiErr)
|
|
|
|
|
require.Equal(t, http.StatusRequestEntityTooLarge, apiErr.StatusCode())
|
|
|
|
|
})
|
2022-02-08 12:00:44 -06:00
|
|
|
}
|
2022-03-07 11:40:54 -06:00
|
|
|
|
|
|
|
|
func TestDownload(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
2026-03-23 19:54:43 +00:00
|
|
|
|
|
|
|
|
// Shared instance — see TestPostFiles for rationale.
|
|
|
|
|
client := coderdtest.New(t, nil)
|
|
|
|
|
_ = coderdtest.CreateFirstUser(t, client)
|
2022-03-07 11:40:54 -06:00
|
|
|
t.Run("NotFound", func(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
2022-08-09 20:17:00 +03:00
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
2022-10-13 18:02:52 -05:00
|
|
|
_, _, err := client.Download(ctx, uuid.New())
|
2022-03-07 11:40:54 -06:00
|
|
|
var apiErr *codersdk.Error
|
|
|
|
|
require.ErrorAs(t, err, &apiErr)
|
2022-06-14 10:14:05 -05:00
|
|
|
require.Equal(t, http.StatusNotFound, apiErr.StatusCode())
|
2022-03-07 11:40:54 -06:00
|
|
|
})
|
|
|
|
|
|
2024-01-31 14:49:55 +01:00
|
|
|
t.Run("InsertTar_DownloadTar", func(t *testing.T) {
|
2022-03-07 11:40:54 -06:00
|
|
|
t.Parallel()
|
2024-01-31 14:49:55 +01:00
|
|
|
// given
|
2022-08-09 20:17:00 +03:00
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
2024-10-25 15:14:39 +01:00
|
|
|
|
|
|
|
|
tarball := archivetest.TestTarFileBytes()
|
2022-08-09 20:17:00 +03:00
|
|
|
|
2024-01-31 14:49:55 +01:00
|
|
|
// when
|
2024-03-11 13:29:57 +00:00
|
|
|
resp, err := client.Upload(ctx, codersdk.ContentTypeTar, bytes.NewReader(tarball))
|
2022-03-07 11:40:54 -06:00
|
|
|
require.NoError(t, err)
|
2022-10-13 18:02:52 -05:00
|
|
|
data, contentType, err := client.Download(ctx, resp.ID)
|
2022-03-07 11:40:54 -06:00
|
|
|
require.NoError(t, err)
|
2024-01-31 14:49:55 +01:00
|
|
|
|
|
|
|
|
// then
|
2024-03-11 13:29:57 +00:00
|
|
|
require.Len(t, data, len(tarball))
|
2022-03-07 11:40:54 -06:00
|
|
|
require.Equal(t, codersdk.ContentTypeTar, contentType)
|
2024-03-11 13:29:57 +00:00
|
|
|
require.Equal(t, tarball, data)
|
2024-10-25 15:14:39 +01:00
|
|
|
archivetest.AssertSampleTarFile(t, data)
|
2022-03-07 11:40:54 -06:00
|
|
|
})
|
2024-01-31 14:49:55 +01:00
|
|
|
|
|
|
|
|
t.Run("InsertZip_DownloadTar", func(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
|
|
|
|
// given
|
2024-10-25 15:14:39 +01:00
|
|
|
zipContent := archivetest.TestZipFileBytes()
|
2024-01-31 14:49:55 +01:00
|
|
|
|
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
|
|
|
|
// when
|
|
|
|
|
resp, err := client.Upload(ctx, codersdk.ContentTypeZip, bytes.NewReader(zipContent))
|
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
data, contentType, err := client.Download(ctx, resp.ID)
|
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
// then
|
|
|
|
|
require.Equal(t, codersdk.ContentTypeTar, contentType)
|
2024-03-11 13:29:57 +00:00
|
|
|
|
|
|
|
|
// Note: creating a zip from a tar will result in some loss of information
|
|
|
|
|
// as zip files do not store UNIX user:group data.
|
2024-10-25 15:14:39 +01:00
|
|
|
archivetest.AssertSampleTarFile(t, data)
|
2024-01-31 14:49:55 +01:00
|
|
|
})
|
|
|
|
|
|
|
|
|
|
t.Run("InsertTar_DownloadZip", func(t *testing.T) {
|
|
|
|
|
t.Parallel()
|
|
|
|
|
// given
|
2024-10-25 15:14:39 +01:00
|
|
|
tarball := archivetest.TestTarFileBytes()
|
2024-01-31 14:49:55 +01:00
|
|
|
|
|
|
|
|
tarReader := tar.NewReader(bytes.NewReader(tarball))
|
2024-10-25 15:14:39 +01:00
|
|
|
expectedZip, err := archive.CreateZipFromTar(tarReader, 10240)
|
2024-01-31 14:49:55 +01:00
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
|
defer cancel()
|
|
|
|
|
|
|
|
|
|
// when
|
|
|
|
|
resp, err := client.Upload(ctx, codersdk.ContentTypeTar, bytes.NewReader(tarball))
|
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
data, contentType, err := client.DownloadWithFormat(ctx, resp.ID, codersdk.FormatZip)
|
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
// then
|
|
|
|
|
require.Equal(t, codersdk.ContentTypeZip, contentType)
|
|
|
|
|
require.Equal(t, expectedZip, data)
|
2024-10-25 15:14:39 +01:00
|
|
|
archivetest.AssertSampleZipFile(t, data)
|
2024-01-31 14:49:55 +01:00
|
|
|
})
|
2022-03-07 11:40:54 -06:00
|
|
|
}
|