Adds typed AI Gateway actor identity, including the API key ID used by recording. Recorders now read the authenticated API key ID from each call context instead of capturing request identity at construction time. This allows one recorder to be reused safely across sequential and concurrent requests. Includes context helper coverage and recorder regression tests. Generated by Coder Agents on behalf of @pawbana.
278 lines
8.9 KiB
Go
278 lines
8.9 KiB
Go
package cli
|
|
|
|
import (
|
|
"bytes"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.opentelemetry.io/otel/trace/noop"
|
|
|
|
"cdr.dev/slog/v3"
|
|
"github.com/coder/coder/v2/aibridge"
|
|
"github.com/coder/coder/v2/aibridge/headers"
|
|
"github.com/coder/coder/v2/aibridge/recorder"
|
|
"github.com/coder/coder/v2/coderd/aibridged/proto"
|
|
"github.com/coder/coder/v2/coderd/database"
|
|
"github.com/coder/coder/v2/codersdk"
|
|
"github.com/coder/coder/v2/testutil"
|
|
"github.com/coder/serpent"
|
|
)
|
|
|
|
func TestBuildProviderFromProtoSetsAPIDumpDir(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
const dumpDir = "/tmp/coder-aibridge-dumps"
|
|
|
|
tests := []struct {
|
|
name string
|
|
provider *proto.AIProvider
|
|
expectedType string
|
|
}{
|
|
{
|
|
name: "OpenAI",
|
|
provider: &proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeOpenai),
|
|
Name: "openai",
|
|
BaseUrl: "https://api.openai.com/",
|
|
},
|
|
expectedType: aibridge.ProviderOpenAI,
|
|
},
|
|
{
|
|
name: "Anthropic",
|
|
provider: &proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeAnthropic),
|
|
Name: "anthropic",
|
|
BaseUrl: "https://api.anthropic.com/",
|
|
},
|
|
expectedType: aibridge.ProviderAnthropic,
|
|
},
|
|
{
|
|
name: "Copilot",
|
|
provider: &proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeCopilot),
|
|
Name: "copilot",
|
|
BaseUrl: "https://api.githubcopilot.com/",
|
|
},
|
|
expectedType: aibridge.ProviderCopilot,
|
|
},
|
|
{
|
|
name: "Azure",
|
|
provider: &proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeAzure),
|
|
Name: "azure",
|
|
BaseUrl: "https://example.openai.azure.com/",
|
|
},
|
|
expectedType: aibridge.ProviderOpenAI,
|
|
},
|
|
{
|
|
name: "Google",
|
|
provider: &proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeGoogle),
|
|
Name: "google",
|
|
BaseUrl: "https://generativelanguage.googleapis.com/v1beta/openai/",
|
|
},
|
|
expectedType: aibridge.ProviderOpenAI,
|
|
},
|
|
{
|
|
name: "OpenAICompat",
|
|
provider: &proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeOpenaiCompat),
|
|
Name: "openai-compat",
|
|
BaseUrl: "https://compat.example.com/v1/",
|
|
},
|
|
expectedType: aibridge.ProviderOpenAI,
|
|
},
|
|
{
|
|
name: "OpenRouter",
|
|
provider: &proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeOpenrouter),
|
|
Name: "openrouter",
|
|
BaseUrl: "https://openrouter.ai/api/v1/",
|
|
},
|
|
expectedType: aibridge.ProviderOpenAI,
|
|
},
|
|
{
|
|
name: "Vercel",
|
|
provider: &proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeVercel),
|
|
Name: "vercel",
|
|
BaseUrl: "https://api.v0.dev/v1/",
|
|
},
|
|
expectedType: aibridge.ProviderOpenAI,
|
|
},
|
|
{
|
|
name: "Bedrock",
|
|
provider: &proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeBedrock),
|
|
Name: "bedrock",
|
|
BaseUrl: "https://bedrock-runtime.us-east-1.amazonaws.com/",
|
|
Bedrock: &proto.AIProviderKindBedrock{
|
|
Region: "us-east-1",
|
|
AccessKey: "AKID",
|
|
AccessKeySecret: "secret",
|
|
Model: "anthropic.claude-3-5-sonnet-20241022-v2:0",
|
|
SmallFastModel: "anthropic.claude-3-5-haiku-20241022-v1:0",
|
|
},
|
|
},
|
|
expectedType: aibridge.ProviderBedrock,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
provider, err := buildProvider(t.Context(), protoToProviderSpec(tt.provider), codersdk.AIBridgeConfig{
|
|
AllowBYOK: serpent.Bool(true),
|
|
APIDumpDir: serpent.String(dumpDir),
|
|
}, slog.Make(), nil)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, dumpDir, provider.APIDumpDir())
|
|
assert.Equal(t, tt.expectedType, provider.Type())
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestBuildProviderActorHeaders(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
actorID := uuid.MustParse("6f1d2c3b-4a5e-4f60-8a7b-9c0d1e2f3a4b")
|
|
const (
|
|
actorAPIKeyID = "authenticated-api-key-id"
|
|
actorUsername = "authenticated-username"
|
|
actorEmail = "authenticated@example.com"
|
|
clientID = "client-user"
|
|
clientName = "client-username"
|
|
customIDHeader = "X-Downstream-User-ID"
|
|
customNameHeader = "X-Downstream-Username"
|
|
customMailHeader = "X-Downstream-Email"
|
|
)
|
|
|
|
tests := []struct {
|
|
name string
|
|
providerType database.AIProviderType
|
|
sendActorHeaders bool
|
|
actorHeaderID string
|
|
actorHeaderName string
|
|
actorHeaderEmail string
|
|
wantCustomHeaders bool
|
|
}{
|
|
{
|
|
name: "disabled with configured destinations",
|
|
providerType: database.AIProviderTypeOpenai,
|
|
actorHeaderID: customIDHeader,
|
|
actorHeaderName: customNameHeader,
|
|
actorHeaderEmail: customMailHeader,
|
|
},
|
|
{
|
|
name: "enabled with empty destinations",
|
|
providerType: database.AIProviderTypeOpenai,
|
|
sendActorHeaders: true,
|
|
},
|
|
{
|
|
name: "enabled with selected destinations",
|
|
providerType: database.AIProviderTypeOpenai,
|
|
sendActorHeaders: true,
|
|
actorHeaderID: customIDHeader,
|
|
actorHeaderName: customNameHeader,
|
|
actorHeaderEmail: customMailHeader,
|
|
wantCustomHeaders: true,
|
|
},
|
|
{
|
|
name: "Copilot ignores configured destinations",
|
|
providerType: database.AIProviderTypeCopilot,
|
|
sendActorHeaders: true,
|
|
actorHeaderID: customIDHeader,
|
|
actorHeaderName: customNameHeader,
|
|
actorHeaderEmail: customMailHeader,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
upstreamHeaders := make(chan http.Header, 1)
|
|
upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
upstreamHeaders <- r.Header.Clone()
|
|
w.Header().Set("Content-Type", "application/json")
|
|
_, _ = w.Write([]byte(`{"id":"chatcmpl-test","object":"chat.completion","choices":[]}`))
|
|
}))
|
|
t.Cleanup(upstream.Close)
|
|
|
|
provider, err := buildProvider(t.Context(), aiProviderSpec{
|
|
Type: tt.providerType,
|
|
Name: string(tt.providerType),
|
|
Enabled: true,
|
|
BaseURL: upstream.URL,
|
|
Keys: []string{"upstream-key"},
|
|
}, codersdk.AIBridgeConfig{
|
|
SendActorHeaders: serpent.Bool(tt.sendActorHeaders),
|
|
ActorHeaderID: serpent.String(tt.actorHeaderID),
|
|
ActorHeaderUsername: serpent.String(tt.actorHeaderName),
|
|
ActorHeaderEmail: serpent.String(tt.actorHeaderEmail),
|
|
}, slog.Make(), nil)
|
|
require.NoError(t, err)
|
|
|
|
request := httptest.NewRequest(http.MethodPost, provider.RoutePrefix()+"/chat/completions", bytes.NewBufferString(`{"model":"gpt-4","messages":[],"stream":false}`))
|
|
request = request.WithContext(aibridge.AsActor(request.Context(), aibridge.Actor{ID: actorID, APIKeyID: actorAPIKeyID, Username: actorUsername, Email: actorEmail}))
|
|
request.Header.Set("Authorization", "Bearer client-key")
|
|
request.Header.Set(headers.ActorIDHeader, clientID)
|
|
request.Header.Set(headers.ActorMetadataHeader("Username"), clientName)
|
|
|
|
interceptor, err := provider.CreateInterceptor(httptest.NewRecorder(), request, noop.NewTracerProvider().Tracer("test"))
|
|
require.NoError(t, err)
|
|
interceptor.Setup(slog.Make(), recorder.NewLogRecorder(slog.Make(), false, nil), nil)
|
|
|
|
processRequest := httptest.NewRequest(http.MethodPost, provider.RoutePrefix()+"/chat/completions", bytes.NewBufferString(`{"model":"gpt-4","messages":[],"stream":false}`)).WithContext(request.Context())
|
|
response := httptest.NewRecorder()
|
|
require.NoError(t, interceptor.ProcessRequest(response, processRequest))
|
|
|
|
receivedHeaders := testutil.TryReceive(testutil.Context(t, testutil.WaitShort), t, upstreamHeaders)
|
|
if tt.wantCustomHeaders {
|
|
assert.Equal(t, actorID.String(), receivedHeaders.Get(customIDHeader))
|
|
assert.Equal(t, actorUsername, receivedHeaders.Get(customNameHeader))
|
|
assert.Equal(t, actorEmail, receivedHeaders.Get(customMailHeader))
|
|
} else {
|
|
assert.NotContains(t, receivedHeaders, http.CanonicalHeaderKey(customIDHeader))
|
|
assert.NotContains(t, receivedHeaders, customNameHeader)
|
|
assert.NotContains(t, receivedHeaders, customMailHeader)
|
|
}
|
|
// Client actor headers never reach the upstream.
|
|
assert.NotContains(t, receivedHeaders, http.CanonicalHeaderKey(headers.ActorIDHeader))
|
|
assert.NotContains(t, receivedHeaders, http.CanonicalHeaderKey(headers.ActorMetadataHeader("Username")))
|
|
for name, values := range receivedHeaders {
|
|
assert.NotContains(t, values, actorAPIKeyID, "the actor API key ID must never be forwarded in %s", name)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestBuildProviderFromProtoBedrockWithoutSettings(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
_, err := buildProvider(t.Context(), protoToProviderSpec(&proto.AIProvider{
|
|
Enabled: true,
|
|
Type: string(database.AIProviderTypeBedrock),
|
|
Name: "bedrock-no-settings",
|
|
BaseUrl: "https://bedrock-runtime.us-east-1.amazonaws.com/",
|
|
}), codersdk.AIBridgeConfig{
|
|
AllowBYOK: serpent.Bool(true),
|
|
}, slog.Make(), nil)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "bedrock provider has no bedrock credentials configured")
|
|
}
|