Ethan
0616658cb5
feat(coderd): add a steer lane to queued chat messages ( #31154 )
...
As suggested on #30074 , steer messages are now their own lane, rather
than queue rows that jump ahead with a lower position. chatstate uses a
queued message's `busy_behavior` as its lane, and the steer lane always
goes first. `GetChatQueuedMessages` lists the steer lane first, so the
queue is shown in the order it'll actually be delivered.
At turn end, when an interruption finishes, and on a send to an errored
chat, the whole steer lane goes in. If there aren't any steer messages,
the queue head goes in like it does today. So with a queue of `Q1 S1 Q2
S2`, turn end delivers `S1 S2`, and `Q1` waits for the next turn end.
chatstate accepts `steer` here, but nothing sends it yet, so users won't
see a change. Until later in the stack, a few things still ignore the
steer lane:
- An interrupt send goes to the head of the queue lane, so it waits
behind any steer messages. #31155 moves it to the end of the steer lane.
- "Send now" on a running or interrupting chat only moves the message to
the head of its own lane, so when the interruption finishes, the steer
lane goes in instead of it.
- "Send now" on an errored chat, or one waiting on tool results, puts
the message into history straight away, ahead of any queued steer
messages.
#31156 fixes both "Send now" cases by making it steer. None of these can
happen yet, as there are no steer messages to get in the way.
I've added a "Queued message lanes" section to the chatd architecture
doc. Most of the diff is new cases in the transition matrix tests.
Since the first review, lane rule 3 in the architecture doc also says
that delivery stops at a message under edit, and which model and
reasoning effort a batch of delivered messages uses.
Part of CODAGT-1140
2026-11-09 15:55:15 +11:00
..
2026-11-03 12:34:49 +02:00
2026-11-05 09:48:48 +00:00
2026-11-03 16:39:43 +00:00
2026-11-03 16:39:43 +00:00
2026-09-29 11:48:52 +02:00
2026-09-11 01:48:56 +00:00
2026-11-06 13:12:49 +11:00
2026-10-07 11:43:19 +03:00
2026-09-02 11:29:35 +02:00
2026-10-18 12:58:39 +07:00
2026-08-21 23:46:27 -06:00
2026-10-15 14:20:44 -05:00
2026-10-13 07:57:56 +00:00
2026-11-05 14:22:30 -05:00
2026-10-16 00:21:40 -08:00
2026-10-05 16:52:36 -07:00
2026-11-09 15:55:15 +11:00
2026-10-13 07:57:56 +00:00
2026-10-09 16:42:41 -06:00
2026-10-13 07:57:56 +00:00
2026-09-16 14:52:21 -07:00
2026-10-19 14:37:36 +11:00
2026-11-06 13:10:50 -05:00
2026-10-28 09:13:17 -06:00
2026-08-21 23:46:27 -06:00
2026-11-05 09:45:21 -05:00
2026-10-19 17:59:18 +03:00
2026-10-29 11:05:54 +01:00
2026-10-18 18:46:46 +02:00
2026-10-22 16:37:05 +11:00
2026-07-30 08:37:45 +01:00
2026-10-28 09:17:10 -06:00
2026-08-10 14:43:16 -05:00
2026-11-04 10:32:03 -06:00
2026-08-11 11:04:51 -05:00
2026-10-22 13:58:42 +00:00
2026-08-25 08:12:00 -07:00
2026-09-17 18:14:08 +02:00
2026-10-11 19:57:49 +02:00
2026-10-30 15:52:22 +02:00
2026-11-06 13:12:49 +11:00
2026-10-14 12:35:48 -04:00
2026-10-19 17:59:18 +03:00
2026-10-02 16:40:24 -08:00
2026-08-25 16:40:41 +07:00
2026-11-05 15:16:40 -05:00
2026-10-21 14:07:02 -07:00
2026-11-04 09:59:50 -08:00
2026-08-03 15:56:56 -05:00
2026-10-15 17:40:00 -05:00
2026-10-26 21:48:36 +00:00
2026-10-15 14:20:44 -05:00
2026-11-09 15:55:15 +11:00
2026-09-23 20:08:31 +02:00
2026-09-09 10:16:24 +02:00
2026-09-11 16:03:44 +00:00
2026-09-11 16:03:44 +00:00
2026-09-29 09:20:31 +01:00
2026-09-29 09:20:31 +01:00
2026-09-29 09:20:31 +01:00
2026-09-14 13:47:48 -07:00
2026-10-07 11:43:19 +03:00
2026-10-07 11:43:19 +03:00
2026-08-19 19:46:23 +00:00
2026-09-11 01:48:56 +00:00
2026-08-06 09:18:46 -04:00
2026-08-06 09:18:46 -04:00
2026-08-06 09:18:46 -04:00
2026-11-03 23:03:37 +07:00
2026-11-03 23:03:37 +07:00
2026-10-13 19:15:16 +07:00
2026-10-27 16:23:59 +01:00
2026-10-05 12:52:10 -04:00
2026-10-19 11:32:26 +00:00
2026-10-23 19:32:08 +07:00
2026-10-23 19:32:08 +07:00
2026-10-27 18:18:41 -04:00
2026-10-19 11:32:26 +00:00
2026-10-29 23:24:18 +01:00
2026-10-30 15:52:22 +02:00
2026-09-14 08:31:26 -07:00
2026-10-29 20:32:56 +01:00
2026-07-14 12:29:38 -07:00
2026-08-18 12:54:45 -07:00
2026-08-24 12:06:56 -07:00
2026-08-21 23:46:27 -06:00
2026-09-24 15:12:28 +03:00
2026-10-30 19:07:36 +00:00
2026-10-30 20:27:10 +00:00
2026-10-26 15:01:03 +00:00
2026-10-29 23:24:18 +01:00
2026-11-04 12:15:55 +11:00
2026-09-21 17:42:31 +02:00
2026-10-30 20:15:50 +00:00
2026-08-24 11:20:26 +01:00
2026-08-26 13:33:13 +02:00
2026-10-30 15:52:22 +02:00
2026-09-21 15:58:18 +02:00
2026-10-30 15:52:22 +02:00
2026-10-07 15:55:04 +02:00
2026-11-09 15:55:15 +11:00
2026-10-27 01:50:56 +01:00
2026-11-06 13:12:49 +11:00
2026-10-29 20:32:56 +01:00
2026-10-29 20:32:56 +01:00
2026-09-29 12:23:00 +00:00
2026-10-19 14:02:47 +11:00
2026-07-15 12:16:25 -08:00
2026-08-19 13:00:31 -08:00
2026-08-18 12:54:45 -07:00
2026-10-06 13:01:11 +03:00
2026-10-06 13:01:11 +03:00
2026-09-25 18:51:55 +10:00
2026-09-25 18:51:55 +10:00
2026-10-23 12:53:39 +11:00
2026-10-19 17:59:18 +03:00
2026-10-26 21:48:36 +00:00
2026-10-27 10:15:44 +01:00
2026-10-30 20:27:10 +00:00
2026-10-14 14:55:29 -07:00
2026-11-03 12:39:30 +11:00
2026-11-03 12:39:30 +11:00
2026-10-09 00:58:39 +05:00
2026-10-09 00:58:39 +05:00
2026-10-09 00:58:39 +05:00
2026-11-03 12:39:30 +11:00
2026-08-26 15:29:26 +02:00
2026-08-26 15:29:26 +02:00
2026-09-16 11:36:45 -07:00
2026-09-28 18:46:14 +00:00
2026-08-26 11:57:56 -06:00
2026-09-14 18:31:48 -07:00
2026-09-14 18:31:48 -07:00
2026-09-28 18:46:14 +00:00
2026-09-22 23:20:24 +00:00
2026-11-05 14:22:30 -05:00
2026-10-29 12:53:50 +00:00
2026-10-29 12:53:50 +00:00
2026-10-13 16:43:15 +00:00
2026-10-30 20:15:50 +00:00
2026-10-13 16:24:45 +00:00
2026-10-23 19:32:08 +07:00
2026-09-08 17:20:53 +00:00
2026-09-17 14:33:37 -05:00
2026-08-21 10:31:01 -04:00
2026-08-21 10:31:01 -04:00
2026-11-05 14:22:30 -05:00
2026-11-05 14:22:30 -05:00
2026-09-27 23:34:26 +02:00
2026-10-14 14:55:29 -07:00
2026-10-14 14:55:29 -07:00
2026-10-14 14:55:29 -07:00
2026-09-02 12:51:33 -04:00
2026-09-10 08:21:29 -04:00
2026-09-10 08:21:29 -04:00
2026-09-11 18:13:16 -05:00
2026-09-11 18:13:16 -05:00
2026-09-17 11:11:38 +10:00
2026-09-11 18:13:16 -05:00
2026-08-19 16:16:51 -06:00
2026-10-13 07:57:56 +00:00
2026-08-26 11:57:56 -06:00
2026-10-07 19:03:46 +02:00
2026-10-09 16:42:41 -06:00
2026-10-23 12:53:40 +11:00
2026-07-28 09:58:33 -06:00
2026-09-02 09:21:36 -07:00
2026-09-02 09:21:36 -07:00
2026-09-02 09:21:36 -07:00
2026-08-21 23:46:27 -06:00
2026-09-02 09:21:36 -07:00
2026-08-18 12:54:45 -07:00
2026-10-27 01:06:49 +01:00
2026-10-27 01:06:49 +01:00
2026-11-04 12:15:55 +11:00
2026-11-03 12:34:49 +02:00
2026-11-04 12:15:55 +11:00
2026-10-19 23:06:41 +03:00
2026-10-14 13:54:17 +03:00
2026-10-19 23:06:41 +03:00
2026-10-07 11:43:19 +03:00
2026-10-07 11:43:19 +03:00
2026-09-25 13:59:53 -05:00
2026-09-21 11:04:12 +00:00
2026-08-21 23:46:27 -06:00
2026-10-16 15:55:28 +00:00
2026-10-16 15:55:28 +00:00
2026-09-24 11:41:32 -07:00
2026-09-24 11:41:32 -07:00
2026-09-19 00:32:51 +02:00
2026-08-26 11:57:56 -06:00
2026-11-03 15:48:10 -06:00
2026-11-03 15:48:10 -06:00
2026-10-15 17:40:00 -05:00
2026-09-21 21:06:06 +02:00