Ethan
166b9d25e3
test(coderd): remove low-value cron and chatwebhook tests ( #32164 )
...
The tests from #32063 and #32062 are two to three times the size of the
code they cover, and a lot of them can't fail for a reason we'd care
about. This PR removes those, with no production changes.
In `coderd/schedule/cron`, two tests rebuilt the schedule rule a second
time to compare against, which was also the only use of
`export_test.go`, so that goes too. Most of the rest, in both packages,
are table rows that take the same branch as a row that stays. I also
dropped a copy of the webhook scheme list and a repeated-request test
that belongs at the route.
What's left is a row per reject branch, the RFC cases, the regression
test for the `Next` hang and the constant-time scan. I replayed each fix
commit from the two PRs against the smaller suite, and the pre-fix code
still fails a test for every one, other than a fix to the wording of a
zone error.
One row that stays is changed: the bearer wrong-scheme case used
`Basic`, which was only rejected because of where its space lands, so
nothing covered the scheme word. It's now `Digest`.
#32162 overlaps with this in `cron`. With the shim's users gone it no
longer needs to touch that package, so it's now stacked on top of this
PR.
2026-11-18 14:14:26 +11:00
..
2026-11-13 10:39:16 -05:00
2026-11-12 09:58:58 +00:00
2026-11-17 18:02:24 +00:00
2026-11-10 07:39:54 +02:00
2026-09-29 11:48:52 +02:00
2026-09-11 01:48:56 +00:00
2026-11-17 15:34:04 +00:00
2026-10-07 11:43:19 +03:00
2026-09-02 11:29:35 +02:00
2026-11-17 21:59:01 +07:00
2026-08-21 23:46:27 -06:00
2026-10-15 14:20:44 -05:00
2026-06-26 07:24:21 -04:00
2026-06-25 15:41:09 -06:00
2026-10-13 07:57:56 +00:00
2026-11-13 17:20:31 +01:00
2026-10-16 00:21:40 -08:00
2026-10-05 16:52:36 -07:00
2026-11-17 17:26:27 +00:00
2026-10-13 07:57:56 +00:00
2026-11-11 23:54:05 +01:00
2026-10-13 07:57:56 +00:00
2026-11-13 17:20:31 +01:00
2026-10-19 14:37:36 +11:00
2026-11-13 16:38:44 +00:00
2026-10-28 09:13:17 -06:00
2026-11-18 14:14:26 +11:00
2026-11-05 09:45:21 -05:00
2026-10-19 17:59:18 +03:00
2026-11-13 17:20:31 +01:00
2026-11-13 13:21:32 +00:00
2026-10-22 16:37:05 +11:00
2026-07-30 08:37:45 +01:00
2026-04-02 23:51:02 +02:00
2026-11-11 15:02:18 +00:00
2026-08-10 14:43:16 -05:00
2026-11-04 10:32:03 -06:00
2026-08-11 11:04:51 -05:00
2026-10-22 13:58:42 +00:00
2026-08-25 08:12:00 -07:00
2026-11-13 16:38:44 +00:00
2026-11-18 14:14:26 +11:00
2026-11-13 10:59:32 +11:00
2026-11-13 13:02:38 +02:00
2026-10-14 12:35:48 -04:00
2026-10-19 17:59:18 +03:00
2026-10-02 16:40:24 -08:00
2026-08-25 16:40:41 +07:00
2026-06-10 02:18:44 -05:00
2026-11-05 15:16:40 -05:00
2026-10-21 14:07:02 -07:00
2026-11-13 16:38:44 +00:00
2026-08-03 15:56:56 -05:00
2026-10-15 17:40:00 -05:00
2026-10-26 21:48:36 +00:00
2026-10-15 14:20:44 -05:00
2026-07-07 09:18:30 -07:00
2026-07-07 09:18:30 -07:00
2026-11-18 14:14:26 +11:00
2026-09-23 20:08:31 +02:00
2026-09-09 10:16:24 +02:00
2026-07-06 23:00:09 +01:00
2026-09-11 16:03:44 +00:00
2026-09-11 16:03:44 +00:00
2026-09-29 09:20:31 +01:00
2026-05-27 11:58:43 +02:00
2026-09-29 09:20:31 +01:00
2026-09-29 09:20:31 +01:00
2026-05-25 18:04:12 +02:00
2026-09-14 13:47:48 -07:00
2026-10-07 11:43:19 +03:00
2026-10-07 11:43:19 +03:00
2026-05-05 02:54:03 +05:00
2026-05-28 18:37:57 +01:00
2026-08-19 19:46:23 +00:00
2026-09-11 01:48:56 +00:00
2026-08-06 09:18:46 -04:00
2026-08-06 09:18:46 -04:00
2026-08-06 09:18:46 -04:00
2026-07-07 10:42:01 +00:00
2026-11-03 23:03:37 +07:00
2026-11-03 23:03:37 +07:00
2026-10-13 19:15:16 +07:00
2026-10-27 16:23:59 +01:00
2026-10-05 12:52:10 -04:00
2026-10-19 11:32:26 +00:00
2026-11-17 17:55:35 +07:00
2026-11-17 17:55:35 +07:00
2026-11-13 09:59:39 -07:00
2026-11-17 21:59:01 +07:00
2026-10-29 23:24:18 +01:00
2026-10-30 15:52:22 +02:00
2026-07-01 20:15:03 +01:00
2026-09-14 08:31:26 -07:00
2026-11-13 17:20:31 +01:00
2026-07-14 12:29:38 -07:00
2026-08-18 12:54:45 -07:00
2026-11-13 17:20:31 +01:00
2026-11-13 17:20:31 +01:00
2026-09-24 15:12:28 +03:00
2026-05-05 02:54:03 +05:00
2026-05-05 02:54:03 +05:00
2026-10-30 19:07:36 +00:00
2026-10-30 20:27:10 +00:00
2026-11-13 09:59:39 -07:00
2026-10-29 23:24:18 +01:00
2026-11-12 14:03:57 +02:00
2026-09-21 17:42:31 +02:00
2026-10-30 20:15:50 +00:00
2026-08-24 11:20:26 +01:00
2026-08-26 13:33:13 +02:00
2026-10-30 15:52:22 +02:00
2026-09-21 15:58:18 +02:00
2026-10-30 15:52:22 +02:00
2026-10-07 15:55:04 +02:00
2026-11-17 19:57:11 +02:00
2026-10-27 01:50:56 +01:00
2026-11-13 13:02:38 +02:00
2026-11-11 23:54:05 +01:00
2026-11-11 23:54:05 +01:00
2026-09-29 12:23:00 +00:00
2026-10-19 14:02:47 +11:00
2026-07-15 12:16:25 -08:00
2026-08-19 13:00:31 -08:00
2026-06-02 10:11:49 -07:00
2026-08-18 12:54:45 -07:00
2026-06-02 08:36:01 -06:00
2026-07-06 13:15:58 +01:00
2026-11-13 16:38:44 +00:00
2026-10-06 13:01:11 +03:00
2026-03-23 19:54:43 +00:00
2026-05-05 02:54:03 +05:00
2026-09-25 18:51:55 +10:00
2026-09-25 18:51:55 +10:00
2026-10-23 12:53:39 +11:00
2026-10-19 17:59:18 +03:00
2026-03-04 18:01:56 -08:00
2026-10-26 21:48:36 +00:00
2026-10-27 10:15:44 +01:00
2026-10-30 20:27:10 +00:00
2026-10-14 14:55:29 -07:00
2026-11-03 12:39:30 +11:00
2026-11-03 12:39:30 +11:00
2026-10-09 00:58:39 +05:00
2026-10-09 00:58:39 +05:00
2026-10-09 00:58:39 +05:00
2026-11-03 12:39:30 +11:00
2026-08-26 15:29:26 +02:00
2026-08-26 15:29:26 +02:00
2026-05-05 02:54:03 +05:00
2026-09-16 11:36:45 -07:00
2026-09-28 18:46:14 +00:00
2026-08-26 11:57:56 -06:00
2026-09-14 18:31:48 -07:00
2026-09-14 18:31:48 -07:00
2026-09-28 18:46:14 +00:00
2026-09-22 23:20:24 +00:00
2026-11-05 14:22:30 -05:00
2026-05-05 02:54:03 +05:00
2026-10-29 12:53:50 +00:00
2026-10-29 12:53:50 +00:00
2026-10-13 16:43:15 +00:00
2026-10-30 20:15:50 +00:00
2026-10-13 16:24:45 +00:00
2026-10-23 19:32:08 +07:00
2026-09-08 17:20:53 +00:00
2026-09-17 14:33:37 -05:00
2026-08-21 10:31:01 -04:00
2026-08-21 10:31:01 -04:00
2026-05-05 02:54:03 +05:00
2026-11-10 17:42:30 -05:00
2026-06-03 10:46:07 +01:00
2026-04-10 09:50:11 -05:00
2026-11-10 17:42:30 -05:00
2026-09-27 23:34:26 +02:00
2026-05-05 02:54:03 +05:00
2026-05-05 02:54:03 +05:00
2026-10-14 14:55:29 -07:00
2026-10-14 14:55:29 -07:00
2026-10-14 14:55:29 -07:00
2026-09-02 12:51:33 -04:00
2026-09-10 08:21:29 -04:00
2026-09-10 08:21:29 -04:00
2026-09-11 18:13:16 -05:00
2026-09-11 18:13:16 -05:00
2026-09-17 11:11:38 +10:00
2026-09-11 18:13:16 -05:00
2026-08-19 16:16:51 -06:00
2026-10-13 07:57:56 +00:00
2026-05-05 02:54:03 +05:00
2026-06-04 14:37:19 -04:00
2026-08-26 11:57:56 -06:00
2026-10-07 19:03:46 +02:00
2026-11-16 15:03:30 -07:00
2026-11-16 15:03:30 -07:00
2026-07-28 09:58:33 -06:00
2026-09-02 09:21:36 -07:00
2026-09-02 09:21:36 -07:00
2026-09-02 09:21:36 -07:00
2026-08-21 23:46:27 -06:00
2026-09-02 09:21:36 -07:00
2026-08-18 12:54:45 -07:00
2026-11-17 17:55:35 +07:00
2026-11-17 17:55:35 +07:00
2026-04-15 11:31:43 +02:00
2026-04-26 14:49:10 -07:00
2026-05-05 02:54:03 +05:00
2026-05-05 02:54:03 +05:00
2026-07-01 15:59:55 +03:00
2026-11-04 12:15:55 +11:00
2026-11-11 16:51:20 +11:00
2026-11-04 12:15:55 +11:00
2026-10-19 23:06:41 +03:00
2026-11-13 10:39:16 -05:00
2026-10-19 23:06:41 +03:00
2026-10-07 11:43:19 +03:00
2026-10-07 11:43:19 +03:00
2026-09-25 13:59:53 -05:00
2026-09-21 11:04:12 +00:00
2026-08-21 23:46:27 -06:00
2026-10-16 15:55:28 +00:00
2026-10-16 15:55:28 +00:00
2026-05-05 02:54:03 +05:00
2026-09-24 11:41:32 -07:00
2026-09-24 11:41:32 -07:00
2026-09-19 00:32:51 +02:00
2026-08-26 11:57:56 -06:00
2026-11-03 15:48:10 -06:00
2026-11-03 15:48:10 -06:00
2026-10-15 17:40:00 -05:00
2026-09-21 21:06:06 +02:00