Michael Suchacz
7517301ffa
chore: add golangci new-code quality gates ( #30622 )
...
Stack context: second layer of the Go lint gate stack, built on the
exclusion fix below.
Why: adds commented-out code detection and a `log/slog` ban to the main
config, plus a new-code-only pass requiring reasons on lint
suppressions, flagging ignored errors (including `_, _ = w.Write(...)`),
and banning `time.Sleep` in tests. Fixing the hits surfaced a real bug:
GitLab warnings went to the wrong logger. The new-code pass resolves
symlinked checkout paths so it does not silently report nothing.
Validation: both configs report 0 issues; each seeded violation is
caught; `make pre-commit` passed.
> Xum acted for Mike to open this PR.
2026-10-13 07:57:56 +00:00
..
2026-07-28 13:59:37 +02:00
2026-08-20 14:04:23 -04:00
2026-10-01 11:05:28 +01:00
2026-09-30 21:27:14 +00:00
2025-10-06 12:08:17 +02:00
2026-09-21 11:53:11 +02:00
2026-03-05 11:58:10 +00:00
2026-10-02 15:05:10 -04:00
2026-01-08 10:29:41 +04:00
2026-03-23 23:19:23 +02:00
2026-10-01 20:08:40 +00:00
2026-09-30 21:27:14 +00:00
2026-10-01 16:50:42 -04:00
2026-06-16 09:01:43 +00:00
2026-09-17 19:26:18 +02:00
2026-10-02 14:52:57 -04:00
2026-02-19 09:28:52 +00:00
2026-10-08 12:24:42 -04:00
2026-09-29 17:00:27 +02:00
2026-09-30 21:27:14 +00:00
2026-10-08 12:26:20 -04:00
2026-09-18 09:55:21 +02:00
2025-03-26 01:56:39 -05:00
2026-09-14 17:19:06 +02:00
2026-03-30 15:17:55 +02:00
2026-03-05 11:58:10 +00:00
2026-09-02 11:16:11 +02:00
2026-05-12 00:08:37 +02:00
2026-04-17 00:07:30 +10:00
2026-05-13 10:41:56 -04:00
2026-09-25 08:16:24 -04:00
2024-08-17 11:51:13 +00:00
2026-10-13 07:57:56 +00:00
2026-09-18 14:28:38 -04:00
2026-09-21 15:58:18 +02:00
2026-08-12 13:36:52 -07:00
2025-06-27 12:05:34 +01:00
2026-10-05 22:28:54 +00:00
2026-09-24 13:51:38 -04:00
2026-01-08 15:24:11 +04:00
2026-10-13 07:57:56 +00:00
2026-10-01 16:09:01 -04:00
2026-09-22 19:18:59 +00:00
2026-03-09 19:03:06 +02:00
2026-06-29 17:47:06 -04:00
2026-01-08 15:24:11 +04:00
2026-10-12 15:56:40 +03:00
2026-02-06 09:44:40 +00:00
2026-03-05 22:32:18 +02:00
2026-05-11 17:27:29 +02:00
2026-03-05 22:32:18 +02:00
2025-04-07 17:54:05 +02:00
2026-03-24 18:59:44 -04:00
2024-08-19 20:33:37 -04:00
2026-05-11 17:27:29 +02:00
2026-05-11 17:27:29 +02:00
2026-03-06 13:09:56 +01:00
2024-09-12 15:34:03 +10:00
2026-09-22 10:20:24 +01:00
2023-11-08 14:54:48 +00:00
2026-06-01 15:55:19 +02:00
2026-10-13 07:57:56 +00:00
2026-06-01 15:55:19 +02:00
2026-01-16 10:48:20 +02:00
2024-05-30 13:33:00 +02:00
2025-08-19 19:24:20 +01:00
2026-09-11 21:14:39 +00:00
2024-04-30 19:36:12 +03:00
2025-02-07 14:06:38 +01:00
2026-03-16 16:13:57 +02:00
2026-09-22 11:07:06 +00:00
2025-08-18 17:32:53 +01:00
2026-01-08 16:25:28 +00:00
2026-07-22 17:42:42 +02:00
2025-10-02 12:12:29 +10:00
2024-09-12 21:28:07 +00:00
2024-09-12 15:34:03 +10:00
2026-06-01 15:55:19 +02:00
2025-05-22 15:53:37 +02:00
2024-05-06 13:13:24 +00:00
2026-05-11 17:27:29 +02:00
2025-01-03 18:37:25 +05:00
2024-05-17 08:25:10 +00:00
2026-07-24 12:52:01 -04:00
2024-10-01 13:59:49 +00:00
2026-10-11 19:57:49 +02:00
2026-06-01 15:55:19 +02:00
2026-03-05 01:50:50 +11:00
2024-04-29 10:43:27 -05:00
2026-03-25 10:24:31 +01:00
2026-05-26 14:52:21 +02:00
2026-09-24 13:51:38 -04:00
2024-06-22 00:02:12 +10:00
2025-07-01 08:05:44 +00:00