Bobby Ho
5f90c2da69
fix: deflake config-ssh tests with per-invocation contexts ( #28803 )
...
Closes
[PLAT-563](https://linear.app/codercom/issue/PLAT-563/flake-testconfigssh-multiple-variants )
## Problem
`TestConfigSSH` and `TestConfigSSH_NoWildcard` both failed at
`cli/configssh.go:568` with `context deadline exceeded` in [this
run](https://github.com/coder/coder/actions/runs/33414383561/job/99561585574 ).
- Both commands made their API calls promptly, then went silent for
~18.4s, then printed `Updated ".../.ssh/config"` and failed the next
HTTP call.
- The only code in that window is `atomic.WriteFile`, which calls
`f.Sync()`. fsync takes no context and cannot be cancelled.
- Both gaps ended in the same millisecond while other goroutines in both
processes kept logging on schedule, so this was a shared filesystem
stall, not CPU starvation or a crashed server.
- `configssh.go:568` is the reporting site, not the fault site. The
fsync drained the context, so the next request failed before dialing.
- Both tests made this easier to hit by creating one `WaitMedium`
context before server, agent, and workspace setup, so the command ran on
whatever budget was left over.
## Fix
- One context per `config-ssh` invocation, created just before it runs,
so setup and prior runs cannot drain it.
- `WaitMedium` (15s) to `WaitLong` (25s), to cover a slow disk on top of
the HTTP calls.
- `TestConfigSSH` passes that context to the invocation, so
`StartWithWaiter` inherits it instead of injecting a second, independent
`WaitMedium` deadline.
Failed 20/20 under 4.8x CPU oversubscription before the change, 0/20
after.
This buys margin, it does not remove the failure mode: an uncancellable
fsync still sits inside a context-bounded command. The higher-leverage
follow-up is CI side (the Postgres container runs `log_statement=all` on
Docker's json-file driver, and `$RUNNER_TEMP` is not on tmpfs for
Linux). Filing that separately.
2026-09-01 16:09:02 -07:00
..
2026-06-05 14:33:15 +03:00
2026-06-03 15:30:37 -04:00
2026-08-26 11:57:56 -06:00
2025-06-24 11:16:31 +02:00
2026-01-08 15:24:11 +04:00
2026-03-12 13:39:24 -06:00
2026-03-11 15:19:56 +02:00
2026-08-31 11:35:59 -04:00
2025-06-20 13:16:55 -06:00
2026-06-02 10:46:40 +00:00
2026-07-20 15:39:21 +02:00
2026-07-16 16:09:25 +01:00
2026-08-26 11:57:56 -06:00
2025-10-27 17:07:25 +01:00
2025-06-20 13:16:55 -06:00
2026-04-27 12:58:26 +01:00
2026-07-09 07:40:42 -07:00
2026-05-13 14:59:33 -05:00
2026-09-01 16:09:02 -07:00
2026-06-02 10:46:40 +00:00
2026-08-21 23:46:27 -06:00
2026-01-08 15:24:11 +04:00
2026-01-08 15:24:11 +04:00
2026-08-26 11:57:56 -06:00
2026-08-26 11:57:56 -06:00
2026-06-03 15:30:37 -04:00
2026-04-27 12:58:26 +01:00
2025-03-04 15:37:29 -07:00
2025-03-04 15:37:29 -07:00
2025-03-04 15:37:29 -07:00
2026-01-08 15:24:11 +04:00
2026-06-22 19:26:34 -06:00
2026-06-22 12:15:27 -06:00
2026-08-26 18:46:34 +02:00
2025-06-20 13:16:55 -06:00
2025-03-26 01:56:39 -05:00
2026-08-13 18:32:47 +02:00
2026-08-21 23:46:27 -06:00
2026-03-05 09:35:57 -08:00
2026-06-03 15:30:37 -04:00
2025-09-22 17:14:07 +04:00
2026-06-26 12:45:53 +01:00
2026-08-26 18:46:34 +02:00
2026-08-24 11:20:25 +01:00
2026-08-25 12:45:02 -07:00
2026-05-15 14:36:54 -07:00
2026-08-25 12:48:00 -07:00
2026-08-04 16:24:14 +10:00
2026-08-25 12:48:00 -07:00
2026-04-29 10:28:27 -07:00
2026-05-15 14:36:54 -07:00
2026-01-08 15:24:11 +04:00
2026-05-15 14:36:54 -07:00
2026-08-20 12:24:58 -07:00
2026-08-25 12:48:00 -07:00
2026-07-07 12:38:37 -07:00
2026-07-07 12:38:37 -07:00
2026-01-08 15:24:11 +04:00
2026-04-27 12:58:26 +01:00
2026-06-03 15:30:37 -04:00
2026-03-02 22:52:39 -05:00
2026-06-03 15:16:42 -04:00
2025-09-03 10:49:19 +04:00
2025-03-26 01:56:39 -05:00
2026-06-04 08:43:51 -06:00
2026-08-05 10:42:13 -07:00
2025-12-03 11:32:59 +02:00
2026-04-21 15:11:50 -05:00
2026-08-31 11:35:59 -04:00
2026-08-31 11:35:59 -04:00
2026-06-03 15:30:37 -04:00
2025-10-30 17:41:08 -06:00
2026-01-08 15:24:11 +04:00
2026-04-27 12:58:26 +01:00
2026-06-03 15:16:42 -04:00
2026-04-16 12:46:52 -04:00
2025-09-11 15:08:57 +02:00
2026-01-08 15:24:11 +04:00
2026-07-28 16:59:33 -07:00
2026-08-26 11:57:56 -06:00
2026-05-05 19:43:08 -06:00
2026-06-11 09:58:16 -06:00
2026-06-11 09:58:16 -06:00
2026-06-03 15:30:37 -04:00
2026-08-24 09:41:21 -05:00
2026-02-05 19:35:20 +11:00
2026-02-06 14:09:39 +11:00
2026-08-24 09:41:21 -05:00
2025-12-03 11:32:59 +02:00
2026-03-25 13:11:08 +11:00
2026-03-04 11:14:52 -07:00
2026-04-24 17:09:17 -04:00
2026-02-26 14:34:30 +01:00
2026-04-24 17:09:17 -04:00
2025-07-03 13:22:54 +10:00
2026-06-03 15:30:37 -04:00
2026-08-26 11:57:56 -06:00
2025-06-20 13:16:55 -06:00
2026-06-25 15:41:09 -06:00
2026-06-05 14:33:15 +03:00
2025-10-06 08:56:43 +00:00
2025-12-03 11:32:59 +02:00
2026-03-03 08:47:34 +00:00
2025-12-03 11:32:59 +02:00
2026-01-08 15:24:11 +04:00
2025-03-26 01:56:39 -05:00
2026-06-03 15:30:37 -04:00
2026-04-27 12:58:26 +01:00
2026-06-03 15:30:37 -04:00
2026-01-08 15:24:11 +04:00
2026-08-26 11:57:56 -06:00
2026-04-27 12:58:26 +01:00
2026-05-21 16:51:34 +02:00
2026-07-08 11:12:53 +02:00
2026-08-21 23:46:27 -06:00
2025-06-20 13:16:55 -06:00
2026-06-03 15:30:37 -04:00
2026-04-27 12:58:26 +01:00
2026-07-28 14:37:29 -07:00
2026-07-28 14:37:29 -07:00
2026-08-26 11:57:56 -06:00
2026-07-14 15:30:36 -04:00
2026-06-05 14:33:13 -05:00
2026-06-02 08:36:01 -06:00
2026-06-16 13:26:04 -07:00
2026-06-23 11:37:33 -05:00
2026-06-23 11:37:33 -05:00
2026-03-04 20:26:03 -05:00
2026-06-03 15:30:37 -04:00
2026-01-08 15:24:11 +04:00
2026-08-26 13:16:29 +02:00
2026-08-30 13:09:17 +02:00
2026-06-23 11:58:00 -05:00
2026-06-23 11:58:00 -05:00
2026-06-03 15:30:37 -04:00
2026-04-27 12:58:26 +01:00
2026-06-03 15:16:42 -04:00
2026-01-08 15:24:11 +04:00
2026-06-03 13:21:45 +00:00
2026-06-25 15:41:09 -06:00
2026-06-05 16:08:20 +10:00
2026-06-03 15:30:37 -04:00
2026-04-27 12:58:26 +01:00
2025-03-26 10:36:53 +00:00
2025-03-26 10:36:53 +00:00
2026-02-23 22:46:17 -06:00
2026-04-27 12:58:26 +01:00
2026-04-27 12:58:26 +01:00
2026-07-16 13:00:32 +03:00
2026-07-16 13:00:32 +03:00
2026-07-16 13:00:32 +03:00
2025-11-28 08:33:50 +02:00
2026-06-17 13:01:57 +02:00
2025-11-28 08:33:50 +02:00
2026-05-27 12:33:39 +02:00
2026-06-17 13:01:57 +02:00
2026-06-17 13:01:57 +02:00
2026-05-14 14:45:20 +02:00
2026-06-17 13:01:57 +02:00
2025-11-25 15:24:25 +00:00
2025-11-25 15:24:25 +00:00
2026-06-03 15:30:37 -04:00
2026-01-08 15:24:11 +04:00
2026-06-03 15:30:37 -04:00
2025-12-03 11:32:59 +02:00
2026-03-07 01:36:03 +00:00
2026-02-02 15:50:09 +02:00
2026-06-03 15:30:37 -04:00
2026-02-13 14:21:31 +00:00
2026-06-03 15:30:37 -04:00
2026-02-17 16:24:13 +00:00
2026-07-14 11:48:31 +10:00
2026-05-25 19:14:29 +03:00
2026-08-26 11:57:56 -06:00
2026-03-12 08:33:09 -06:00
2026-08-26 11:57:56 -06:00
2026-08-19 14:46:10 -05:00
2026-08-06 14:45:38 +10:00
2026-08-26 11:57:56 -06:00
2026-06-03 15:30:37 -04:00
2026-01-08 15:24:11 +04:00
2026-08-06 14:45:38 +10:00
2026-08-26 11:57:56 -06:00
2026-06-02 08:05:26 -04:00
2026-03-23 23:19:23 +02:00
2026-06-03 15:30:37 -04:00
2025-12-03 11:32:59 +02:00
2026-06-03 15:30:37 -04:00
2025-12-03 11:32:59 +02:00
2026-06-03 15:30:37 -04:00
2025-09-22 17:14:07 +04:00
2026-06-03 15:30:37 -04:00
2025-10-03 10:20:06 -05:00
2025-07-24 16:44:36 +01:00
2025-12-15 11:26:41 -06:00
2025-09-22 17:14:07 +04:00
2026-06-03 15:30:37 -04:00
2026-02-19 09:31:12 +11:00
2026-03-06 00:04:09 +00:00
2026-07-14 13:39:58 -04:00
2026-08-26 11:57:56 -06:00
2026-04-27 12:58:26 +01:00
2026-06-03 15:30:37 -04:00
2026-07-28 21:05:50 +10:00
2026-07-28 21:05:50 +10:00
2025-09-22 17:14:07 +04:00
2025-04-15 18:30:20 -04:00
2025-09-22 17:14:07 +04:00
2026-06-03 15:30:37 -04:00
2025-12-03 11:32:59 +02:00
2026-03-19 15:14:00 +00:00
2026-03-18 22:10:04 +00:00
2026-03-18 22:10:04 +00:00
2026-01-08 15:24:11 +04:00
2025-06-20 13:16:55 -06:00
2026-08-21 23:46:27 -06:00
2025-06-20 13:16:55 -06:00
2026-01-08 15:24:11 +04:00
2026-01-08 15:24:11 +04:00
2026-02-12 12:14:56 +01:00
2026-02-12 12:14:56 +01:00
2026-02-12 12:14:56 +01:00
2026-02-12 12:14:56 +01:00
2026-06-02 10:50:27 -04:00
2026-08-21 23:46:27 -06:00
2026-08-05 10:42:13 -07:00
2025-09-26 11:20:25 +01:00