Removes the experimental Chat Automations feature (`chat-automations` experiment) from main. This reverts the 16-PR stack that added it and adds two forward migrations that undo its schema and credential changes.
> [!WARNING]
> **Upgrade consequences**
>
> - **Automation data is deleted.** Migration 000615 drops the `chat_automations` table and deletes every queued message an automation delivered. Chats, their messages and ordinary queued messages stay. Messages lose their automation provenance (`automation_id`, `input_id`).
> - **Automation-only credentials are revoked.** Migration 000616 deletes API keys, OAuth2 codes and OAuth2 tokens whose only scopes (or allow-list entries) were `chat_automation:*`. Mixed credentials keep their other scopes. Custom roles lose their `chat_automation` permissions. OAuth2 apps that allowed only `chat_automation` scopes get the whitespace allowlist that grants nothing, as in 000595.
> - **A coordinated restart is required.** Stop all old replicas before the new version runs the migrations. Old replicas read the dropped table and columns, so a rolling deploy is not supported.
> - **Remove `--chat-max-automations-per-owner` before upgrading.** The flag, the YAML key `chat.maxAutomationsPerOwner` and the env var `CODER_CHAT_MAX_AUTOMATIONS_PER_OWNER` are removed. A deployment that still sets the flag or the YAML key will not start (`unknown flag` / `unknown option`). The env var is ignored. This includes dogfood. No release or tag contains the flag.
> - **Down migrations restore the schema only.** 000616 down and 000615 down recreate the 000611 schema with empty tables. They do not restore deleted automations, webhook secrets, provenance, queued deliveries, revoked credentials, stripped permissions or the deleted experiment rule.
## What is removed
- The `chat-automations` experiment and its stored runtime rule (`experiment_rule:chat-automations`).
- The `--chat-max-automations-per-owner` deployment option.
- The `chat_automation` RBAC resource, its member and chatd grants, and the `chat_automation:*` API key scopes.
- The automation sqlc queries, dbauthz wrappers and audit table entries.
- The management routes under `/api/experimental/organizations/{organization}/chat-automations`, and the webhook route `POST /api/experimental/chat-automations/{automation}/events` with its rate limiter.
- The chatd management service, webhook publish, schedule loop, the `manage_automations` tool, and the chatstate admission seam and queue promotion guard that only automations used.
- The Agents Automations page, editor, nav entry, chat labels, the Manage automations toggle and the API client.
- The `archived:any` chat search value that the automations "View chats" dialog added.
- `docs/ai-coder/agents/automations.md`, its manifest entry, the glossary entry and the related rows.
Reverted PRs: #30085, #30096, #30112, #30117, #30127, #30134, #30160, #30166, #30167, #30171, #30187, #30207, #30214, #30217, #30219, #30220.
## What stays, and why
- Migrations 000609, 000610 and 000611, their fixture, and the #30297 lock fix with `migration000609_test.go` stay unchanged. Deployments such as dogfood already ran them.
- New migration **000615** reverses the schema changes of 000609 and 000611 against the current schema. It uses the same short-wait lock-and-retry block as 000609, and it rebuilds `chats_expanded` from main's current definition minus the two automation columns. New migration **000616** follows the 000595 Tasks removal for credentials and recreates `api_key_scope` without the five `chat_automation:*` values. It keeps the `chat_project_memory:*` values from 000612.
- The `chat_automation` value stays in the `resource_type` enum, and `codersdk.ResourceTypeChatAutomation` stays. Old audit log rows stay readable, as with `task` after the Tasks removal.
- The 000615 delete fires the existing queue-version trigger, so `queue_version` moves to `snapshot_version` for each affected chat. `snapshot_version` is not bumped: the coordinated restart restarts every stream loop from an empty state, and the site does not read the version fields.
- `coderd/x/chatd/ARCHITECTURE.md` drops the sections the stack added and gets back its pre-stack wording, merged with the later main edits to the same file.
## Notes for reviewers
- #30379 (chat project page) merged while this PR was in progress. It passed `manageAutomationsEnabled` in `AgentCreatePage.test.tsx` and listed an `automations` route in `AgentsPageLayout.test.tsx`. Later main commits also added automation props in `ConversationTimeline.test.tsx` and `ConversationTimelineWorkingBlocks.stories.tsx`. This PR removes all of them.
- Remaining `automation` matches under `coderd`, `codersdk`, `enterprise`, `site/src` and `docs` are intended:
- migrations 000609 to 000611, their fixture and `migration000609_test.go`;
- the new 000615 and 000616 migrations and `migration000615_test.go`;
- the `chat_automation` resource type in `dump.sql`, `models.go`, `codersdk/audit.go`, the generated API docs, `swagger.json` and `typesGenerated.ts`;
- unrelated uses of the word "automation" (docs, `chatlabels_test.go`, `ratelimit.go`, `autostop.go`, `subagent_catalog.go`, `WorkspaceSharingSection.tsx`, `AgentChatPage.stories.tsx`).
Remote UAT on an isolated dev deployment passed. It upgraded a populated pre-removal database, then checked chats, queued messages, tokens, the 404 routes, the removed page and nav entry, and the experiments list.
---
_Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_

242 lines
11 KiB
PL/PgSQL
242 lines
11 KiB
PL/PgSQL
-- Restores the chat automations schema from migrations 000609 to 000611
|
|
-- with empty tables. Only the schema comes back: deleted automations,
|
|
-- webhook secrets, message provenance and automation-queued messages are not
|
|
-- restored.
|
|
--
|
|
-- Take every table lock this migration needs before changing anything. See
|
|
-- 000609_chat_automations.up.sql for the reasoning. chat_automations does
|
|
-- not exist yet, so it is not locked here.
|
|
DO $$
|
|
DECLARE
|
|
previous_lock_timeout text := current_setting('lock_timeout');
|
|
deadline timestamptz := clock_timestamp() + interval '2 minutes';
|
|
BEGIN
|
|
LOOP
|
|
BEGIN
|
|
-- Well below the default deadlock_timeout of 1s, so this
|
|
-- transaction gives up before PostgreSQL can choose an
|
|
-- application transaction as the deadlock victim.
|
|
PERFORM set_config('lock_timeout', '100ms', true);
|
|
-- chats_expanded is recreated below. DROP VIEW locks only the
|
|
-- view, while LOCK TABLE on the view would also lock users (via
|
|
-- visible_users) in ACCESS EXCLUSIVE mode.
|
|
DROP VIEW IF EXISTS chats_expanded;
|
|
LOCK TABLE chats, chat_messages, chat_queued_messages IN ACCESS EXCLUSIVE MODE;
|
|
-- The chat_automations foreign keys need these.
|
|
LOCK TABLE organizations, users, chat_model_configs IN SHARE ROW EXCLUSIVE MODE;
|
|
EXIT;
|
|
EXCEPTION WHEN lock_not_available OR deadlock_detected THEN
|
|
IF clock_timestamp() > deadline THEN
|
|
RAISE EXCEPTION 'migration 000615 down could not lock the chat tables within 2 minutes';
|
|
END IF;
|
|
END;
|
|
PERFORM pg_sleep(0.1);
|
|
END LOOP;
|
|
PERFORM set_config('lock_timeout', previous_lock_timeout, true);
|
|
END;
|
|
$$;
|
|
|
|
CREATE TYPE chat_automation_kind AS ENUM ('webhook', 'schedule');
|
|
CREATE TYPE chat_automation_target_mode AS ENUM ('existing_chat', 'new_chat');
|
|
CREATE TYPE chat_automation_webhook_use AS ENUM ('single', 'multi');
|
|
CREATE TYPE chat_automation_when_busy AS ENUM ('queue', 'skip');
|
|
|
|
CREATE TABLE chat_automations (
|
|
id uuid PRIMARY KEY DEFAULT gen_random_uuid(),
|
|
organization_id uuid NOT NULL REFERENCES organizations (id) ON DELETE CASCADE,
|
|
owner_id uuid NOT NULL REFERENCES users (id) ON DELETE CASCADE,
|
|
name text NOT NULL,
|
|
created_by_chat_id uuid REFERENCES chats (id) ON DELETE SET NULL,
|
|
kind chat_automation_kind NOT NULL,
|
|
enabled boolean NOT NULL DEFAULT false,
|
|
target_mode chat_automation_target_mode NOT NULL,
|
|
target_chat_id uuid REFERENCES chats (id) ON DELETE SET NULL,
|
|
new_chat_model_config_id uuid,
|
|
reasoning_effort chat_reasoning_effort,
|
|
when_busy chat_automation_when_busy,
|
|
webhook_use chat_automation_webhook_use,
|
|
webhook_secret_hash bytea,
|
|
webhook_secret_version bigint NOT NULL DEFAULT 0,
|
|
webhook_consumed_at timestamptz,
|
|
prompt text NOT NULL,
|
|
schedule_cron text,
|
|
schedule_time_zone text,
|
|
schedule_revision bigint NOT NULL DEFAULT 1,
|
|
schedule_next_run_at timestamptz,
|
|
queue_generation bigint NOT NULL DEFAULT 1,
|
|
created_at timestamptz NOT NULL DEFAULT now(),
|
|
updated_at timestamptz NOT NULL DEFAULT now(),
|
|
CONSTRAINT chat_automations_name_length CHECK (char_length(name) BETWEEN 1 AND 128),
|
|
-- Keeps the new-chat model in the automation's organization, matching
|
|
-- the composite foreign keys on chat_*_model_overrides.
|
|
CONSTRAINT chat_automations_new_chat_model_config_fkey
|
|
FOREIGN KEY (organization_id, new_chat_model_config_id)
|
|
REFERENCES chat_model_configs (organization_id, id),
|
|
CONSTRAINT chat_automations_target_shape CHECK (
|
|
(target_mode = 'existing_chat' AND new_chat_model_config_id IS NULL AND when_busy IS NOT NULL)
|
|
OR (target_mode = 'new_chat' AND target_chat_id IS NULL AND new_chat_model_config_id IS NOT NULL AND when_busy IS NULL)
|
|
),
|
|
CONSTRAINT chat_automations_kind_shape CHECK (
|
|
(kind = 'webhook' AND webhook_use IS NOT NULL AND schedule_cron IS NULL)
|
|
OR (kind = 'schedule' AND webhook_use IS NULL AND webhook_secret_hash IS NULL AND schedule_cron IS NOT NULL AND schedule_time_zone IS NOT NULL)
|
|
)
|
|
);
|
|
|
|
COMMENT ON TABLE chat_automations IS 'Owner-authored webhook or schedule triggers that deliver a prompt to an existing chat or a new chat.';
|
|
COMMENT ON COLUMN chat_automations.target_chat_id IS 'Target chat for existing_chat automations. Set to NULL when the target chat is deleted.';
|
|
COMMENT ON COLUMN chat_automations.webhook_secret_hash IS 'Hash of the webhook bearer secret. The plaintext secret is never stored.';
|
|
COMMENT ON COLUMN chat_automations.webhook_secret_version IS 'Incremented each time the webhook secret is rotated.';
|
|
COMMENT ON COLUMN chat_automations.webhook_consumed_at IS 'Single-use webhook marker. Set once when the webhook is consumed and never reset.';
|
|
COMMENT ON COLUMN chat_automations.schedule_revision IS 'Incremented whenever the schedule changes, so work computed from an older schedule can be detected as stale.';
|
|
COMMENT ON COLUMN chat_automations.schedule_next_run_at IS 'Schedule cursor: the next occurrence to fire. NULL when no occurrence is pending.';
|
|
COMMENT ON COLUMN chat_automations.queue_generation IS 'Incremented to invalidate queued messages this automation delivered earlier; queued rows carry the generation they were created with.';
|
|
|
|
-- A composite foreign key cannot keep these chats in the automation's
|
|
-- organization: ON DELETE SET NULL would also clear organization_id, and
|
|
-- column-list SET NULL needs PostgreSQL 15.
|
|
CREATE FUNCTION enforce_chat_automation_chat_organization() RETURNS trigger
|
|
LANGUAGE plpgsql
|
|
AS $$
|
|
BEGIN
|
|
-- Validate a reference only when it or organization_id changes. Chat
|
|
-- deletion runs one ON DELETE SET NULL update per reference, and the
|
|
-- other, unchanged reference may point at a chat the same statement is
|
|
-- deleting.
|
|
IF NEW.target_chat_id IS NOT NULL AND (
|
|
TG_OP = 'INSERT'
|
|
OR NEW.target_chat_id IS DISTINCT FROM OLD.target_chat_id
|
|
OR NEW.organization_id IS DISTINCT FROM OLD.organization_id
|
|
) AND NOT EXISTS (
|
|
SELECT 1 FROM chats
|
|
WHERE id = NEW.target_chat_id AND organization_id = NEW.organization_id
|
|
) THEN
|
|
RAISE EXCEPTION 'target chat % is not in organization %', NEW.target_chat_id, NEW.organization_id
|
|
USING ERRCODE = 'check_violation',
|
|
CONSTRAINT = 'chat_automations_chat_organization';
|
|
END IF;
|
|
IF NEW.created_by_chat_id IS NOT NULL AND (
|
|
TG_OP = 'INSERT'
|
|
OR NEW.created_by_chat_id IS DISTINCT FROM OLD.created_by_chat_id
|
|
OR NEW.organization_id IS DISTINCT FROM OLD.organization_id
|
|
) AND NOT EXISTS (
|
|
SELECT 1 FROM chats
|
|
WHERE id = NEW.created_by_chat_id AND organization_id = NEW.organization_id
|
|
) THEN
|
|
RAISE EXCEPTION 'creating chat % is not in organization %', NEW.created_by_chat_id, NEW.organization_id
|
|
USING ERRCODE = 'check_violation',
|
|
CONSTRAINT = 'chat_automations_chat_organization';
|
|
END IF;
|
|
RETURN NEW;
|
|
END;
|
|
$$;
|
|
|
|
CREATE TRIGGER trigger_enforce_chat_automation_chat_organization
|
|
BEFORE INSERT OR UPDATE OF organization_id, target_chat_id, created_by_chat_id ON chat_automations
|
|
FOR EACH ROW EXECUTE FUNCTION enforce_chat_automation_chat_organization();
|
|
|
|
CREATE INDEX chat_automations_org_owner_idx ON chat_automations (organization_id, owner_id);
|
|
-- Serves owner lookups without an organization, including the users cascade.
|
|
CREATE INDEX chat_automations_owner_id_idx ON chat_automations (owner_id);
|
|
-- Chat deletion enforces ON DELETE SET NULL through these columns.
|
|
CREATE INDEX chat_automations_target_chat_id_idx ON chat_automations (target_chat_id) WHERE target_chat_id IS NOT NULL;
|
|
CREATE INDEX chat_automations_created_by_chat_id_idx ON chat_automations (created_by_chat_id) WHERE created_by_chat_id IS NOT NULL;
|
|
CREATE INDEX chat_automations_due_idx ON chat_automations (schedule_next_run_at) WHERE kind = 'schedule' AND enabled;
|
|
|
|
-- Provenance columns record which automation input produced a row. They
|
|
-- have no foreign key to chat_automations by design: provenance must
|
|
-- survive the automation's deletion.
|
|
ALTER TABLE chat_queued_messages
|
|
ADD COLUMN automation_id uuid,
|
|
ADD COLUMN input_id uuid,
|
|
ADD COLUMN queue_generation bigint,
|
|
ADD CONSTRAINT chat_queued_messages_automation_shape CHECK (
|
|
(automation_id IS NULL AND input_id IS NULL AND queue_generation IS NULL)
|
|
OR (automation_id IS NOT NULL AND input_id IS NOT NULL AND queue_generation IS NOT NULL)
|
|
);
|
|
|
|
COMMENT ON COLUMN chat_queued_messages.automation_id IS 'Automation that queued this message. No foreign key by design.';
|
|
COMMENT ON COLUMN chat_queued_messages.input_id IS 'Automation input (webhook delivery or schedule occurrence) that queued this message.';
|
|
COMMENT ON COLUMN chat_queued_messages.queue_generation IS 'chat_automations.queue_generation at queue time. A lower value than the automation''s current generation marks the message stale.';
|
|
|
|
CREATE INDEX chat_queued_messages_automation_idx ON chat_queued_messages (automation_id) WHERE automation_id IS NOT NULL;
|
|
|
|
ALTER TABLE chat_messages
|
|
ADD COLUMN automation_id uuid,
|
|
ADD COLUMN input_id uuid;
|
|
|
|
COMMENT ON COLUMN chat_messages.automation_id IS 'Automation that delivered this message. No foreign key by design.';
|
|
COMMENT ON COLUMN chat_messages.input_id IS 'Automation input (webhook delivery or schedule occurrence) that delivered this message.';
|
|
|
|
CREATE INDEX chat_messages_automation_idx ON chat_messages (automation_id) WHERE automation_id IS NOT NULL;
|
|
|
|
ALTER TABLE chats
|
|
ADD COLUMN automation_id uuid;
|
|
|
|
COMMENT ON COLUMN chats.automation_id IS 'Automation that created this chat. No foreign key by design.';
|
|
|
|
CREATE INDEX chats_automation_idx ON chats (automation_id) WHERE automation_id IS NOT NULL;
|
|
|
|
ALTER TABLE chats
|
|
ADD COLUMN manage_automations_enabled boolean NOT NULL DEFAULT false;
|
|
|
|
COMMENT ON COLUMN chats.manage_automations_enabled IS 'Interim per-chat switch that offers the manage_automations tool. Only the chat owner may change it after creation.';
|
|
|
|
-- Recreate chats_expanded, dropped at the top of this migration, with the
|
|
-- restored columns.
|
|
CREATE VIEW chats_expanded AS
|
|
SELECT c.id,
|
|
c.owner_id,
|
|
c.workspace_id,
|
|
c.title,
|
|
c.status,
|
|
c.worker_id,
|
|
c.started_at,
|
|
c.heartbeat_at,
|
|
c.created_at,
|
|
c.updated_at,
|
|
c.parent_chat_id,
|
|
c.root_chat_id,
|
|
c.last_model_config_id,
|
|
c.last_reasoning_effort,
|
|
c.archived,
|
|
c.last_error,
|
|
c.mode,
|
|
c.mcp_server_ids,
|
|
c.labels,
|
|
c.build_id,
|
|
c.agent_id,
|
|
c.pin_order,
|
|
c.last_read_message_id,
|
|
c.dynamic_tools,
|
|
c.organization_id,
|
|
c.project_id,
|
|
c.plan_mode,
|
|
c.client_type,
|
|
c.last_turn_summary,
|
|
c.summary,
|
|
c.summary_generated_at,
|
|
c.snapshot_version,
|
|
c.history_version,
|
|
c.queue_version,
|
|
c.generation_attempt,
|
|
c.retry_state,
|
|
c.retry_state_version,
|
|
c.runner_id,
|
|
c.requires_action_deadline_at,
|
|
COALESCE(root.user_acl, c.user_acl) AS user_acl,
|
|
COALESCE(root.group_acl, c.group_acl) AS group_acl,
|
|
owner.username AS owner_username,
|
|
owner.name AS owner_name,
|
|
c.context_aggregate_hash,
|
|
c.context_dirty_since,
|
|
c.context_dirty_resources,
|
|
c.context_error,
|
|
c.compaction_requested_at,
|
|
c.title_source,
|
|
c.title_updated_at,
|
|
c.automation_id,
|
|
c.manage_automations_enabled
|
|
FROM ((chats c
|
|
LEFT JOIN chats root ON ((root.id = COALESCE(c.root_chat_id, c.parent_chat_id))))
|
|
JOIN visible_users owner ON ((owner.id = c.owner_id)));
|