Files
galaxy/test/unit/data/security/test_validate_user_input.py
John ChiltonandClaude Opus 5.5 ad9b32d0f1 Share the message-rule payload validator; trim re-exports
message_rule_validator turns a value rule returning a user-facing message
into a pydantic validator, replacing three copies of the same check in
galaxy.schema.schema. validation_message_wrapper is now typed generically
so it can wrap it.

Rename Username to StoredUsername - it only bounds the length, and read
like the validated types next to it.

Stop re-exporting DISPLAY_NAME_MAX_LEN and validate_display_name_str from
galaxy.security.validate_user_input; they never lived there in a release.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-09-28 14:14:46 -04:00

111 lines
4.4 KiB
Python

import pytest
from galaxy import config
from galaxy.security import validate_user_input
from galaxy.security.validate_user_input import (
extract_domain,
is_email_banned,
validate_email_domain_name,
)
from galaxy.util import user_input
@pytest.fixture()
def appconfig():
return config.GalaxyAppConfiguration(override_tempdir=False)
def test_extract_full_domain():
assert extract_domain("jack@foo.com") == "foo.com"
assert extract_domain("jack@foo.bar.com") == "foo.bar.com"
assert extract_domain("foo.bar.com") == "foo.bar.com"
assert extract_domain('"i-like-to-break-email-valid@tors"@foo.com') == "foo.com"
def test_extract_base_domain():
# Use case: ignore subdomains to filter out disposable email addresses
assert extract_domain("jack@foo.com", base_only=True) == "foo.com"
assert extract_domain("jack@foo.bar.com", base_only=True) == "bar.com"
def test_validate_email_domain_name():
assert validate_email_domain_name("example.org") == ""
assert validate_email_domain_name("this is an invalid domain!") != ""
@pytest.mark.parametrize(
"name",
[
"EMAIL_MAX_LEN",
"FILL_CHAR",
"is_valid_email_str",
"PASSWORD_MIN_LEN",
"PUBLICNAME_MAX_LEN",
"transform_publicname",
"VALID_EMAIL_RE",
"VALID_PUBLICNAME_RE",
"VALID_PUBLICNAME_SUB",
"validate_email_str",
"validate_password_str",
"validate_publicname_str",
],
)
def test_value_rules_importable_from_previous_home(name):
assert getattr(validate_user_input, name) is getattr(user_input, name)
class TestIsEmailBanned:
mock_ban_list = ["ab@foo.com", "ab@gmail.com", "Not.Canonical+email+gmail+address@gmail.com"]
def test_default_canonical_rules(self, monkeypatch, appconfig):
"""Rules loaded from schema."""
monkeypatch.setattr(validate_user_input, "_read_email_ban_list", lambda a: self.mock_ban_list)
rules = appconfig.canonical_email_rules
assert is_email_banned("ab@foo.com", "_", rules)
assert not is_email_banned("Ab@foo.com", "_", rules)
assert not is_email_banned("a.b@foo.com", "_", rules)
assert not is_email_banned("ab+bar@foo.com", "_", rules)
assert not is_email_banned("something-else@foo.com", "_", rules)
# default rules for gmail are applied:
assert is_email_banned("ab@googlemail.com", "_", rules)
assert is_email_banned("Ab@gmail.com", "_", rules)
assert is_email_banned("a.b@gmail.com", "_", rules)
assert is_email_banned("ab+bar@gmail.com", "_", rules)
assert not is_email_banned("ab-bar@gmail.com", "_", rules) # different sub-addressing delimiter
def test_no_canonical_rules(self, monkeypatch):
"""No rules loaded."""
monkeypatch.setattr(validate_user_input, "_read_email_ban_list", lambda a: self.mock_ban_list)
rules = None
assert is_email_banned("ab@foo.com", "_", rules)
assert not is_email_banned("Ab@foo.com", "_", rules)
assert not is_email_banned("a.b@foo.com", "_", rules)
assert not is_email_banned("ab+bar@foo.com", "_", rules)
assert not is_email_banned("something-else@foo.com", "_", rules)
# default rules for gmail are NOT applied:
assert not is_email_banned("ab@googlemail.com", "_", rules)
assert not is_email_banned("Ab@gmail.com", "_", rules)
assert not is_email_banned("a.b@gmail.com", "_", rules)
assert not is_email_banned("ab+bar@gmail.com", "_", rules)
def test_custom_canonical_rules(self, monkeypatch):
"""No rules loaded."""
monkeypatch.setattr(validate_user_input, "_read_email_ban_list", lambda a: self.mock_ban_list)
rules = {"all": {"ignore_case": True}, "foo.com": {"ignore_dots": True}}
assert is_email_banned("ab@foo.com", "_", rules)
assert is_email_banned("Ab@foo.com", "_", rules) # ignore_case for all
assert is_email_banned("a.b@foo.com", "_", rules) # ignore_dots for foo.com
assert not is_email_banned("ab+bar@foo.com", "_", rules)
assert not is_email_banned("something-else@foo.com", "_", rules)
# default rules for gmail are NOT applied:
assert not is_email_banned("ab@googlemail.com", "_", rules)
assert is_email_banned("Ab@gmail.com", "_", rules) # ignore_case for all
assert not is_email_banned("a.b@gmail.com", "_", rules)
assert not is_email_banned("ab+bar@gmail.com", "_", rules)