mirror of
https://github.com/coder/coder.git
synced 2026-11-22 11:28:40 +08:00
feea5ab959f59cd2135443ed2a0c19bf7643db8f
1336
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
7022f3f3b4 |
ci: pin wingetcreate in publish-winget and check its SHA-256 (#32387)
Pins the `wingetcreate.exe` that `publish-winget` downloads and checks its SHA-256 before running it. The job runs in the `release-publish` environment with cdrci's token, so it shouldn't run whatever `aka.ms/wingetcreate/latest` currently points at. ## Changes (`.github/workflows/release.yaml`, `publish-winget` job) - Downloads `wingetcreate.exe` from the GitHub release `v1.28.1.0` of microsoft/winget-create, not `https://aka.ms/wingetcreate/latest`. - Fails if the file's SHA-256 isn't `63d980ba79e97042395bd6eb5992c2db9e01e9e7a8a22958a95c288f27310413`, and deletes the file. - Keeps the output path `.\wingetcreate.exe`, so the next step doesn't change. - To upgrade, change `WINGETCREATE_VERSION` and `WINGETCREATE_SHA256` together. The comment above the step says where to find both. ## Where the hash comes from - **Same build as now:** `aka.ms/wingetcreate/latest` currently redirects to `releases/download/v1.28.1.0/wingetcreate.exe`, so releases already use this binary. - **Three sources agree on the hash:** - my own download; - GitHub's asset digest for `wingetcreate.exe`; - the `wingetcreate.exe.txt` checksum file Microsoft publishes in the same release. - **Signature:** the binary carries a Microsoft Authenticode signature. coder/coder-desktop-windows#196 pins the same version and hash. ## Checks - `actionlint .github/workflows/release.yaml`: clean. - `zizmor --offline .github/workflows/release.yaml`: no errors or warnings, on `main` or on this branch. --- AI disclosure: an AI coding agent (Xum) wrote this change and ran the checks above at my direction. It stays a draft until I've reviewed it. |
||
|
|
d974fefc08 |
chore: sign with github.com/coder/gpgkms instead of scripts/gpgkms (#32308)
Replaces `scripts/gpgkms` with [`github.com/coder/gpgkms`](https://github.com/coder/gpgkms) v0.2.0, the same code extracted into a shared module (terraform-provider-coder already signs its releases with it). v0.2.0 also rejects keys that aren't HSM-backed (`gpg-release` is `HSM`, and the check reads `protectionLevel` from the existing `GetPublicKey` call, so no new IAM is needed), limits each KMS request to a minute, and writes `-out` atomically. - `go.mod`: gpgkms is a `tool` dependency, so the version is pinned in `go.mod`/`go.sum` and Dependabot keeps it current. This bumps go-crypto 1.4.1 → 1.5.2, google.golang.org/api 0.308.0 → 0.311.0 and circl 1.6.3 → 1.6.5, plus a few indirect dependencies. go-crypto is now only indirect: nothing else in coder/coder imports it. - `scripts/gpgkms.sh` (new): runs it with `go tool` (like `scripts/format_go_file.sh` does for gofumpt and gci), passing the release key's OpenPGP identity (name, email, creation time, 4-year lifetime). The library takes these as flags instead of hardcoding them, so they now live in one place. - It also pins `-fingerprint 0F685EFE0AE5A8182A473DD86E3A8E5613707520`, so signing and `public-key` fail if the KMS key or creation time ever change. That's the fingerprint every current main build prints (e.g. run 44031030839), and I recomputed it from the KMS public key and the creation time alone, without signing anything. The fingerprint doesn't cover the user ID or lifetime; the equivalence check below does. - `scripts/sign_with_gpg.sh` and the "Print GPG KMS public key" step in `build.yaml` call the wrapper instead of `./scripts/gpgkms`. Signatures stay armored `.v2.asc` files, as before. - `scripts/gpgkms/` is deleted. ## Same key, same signatures The OpenPGP key's fingerprint depends on these exact inputs, so I checked that nothing changed. With a local RSA-4096 key standing in for KMS, the deleted `newEntity`/`writePublicKey`/`sign` produce the same output as the gpgkms CLI with the flags read out of `scripts/gpgkms.sh`: - The public key is **byte for byte identical**. - A signature with `-prepend` is armored the same way and has the same length (only the timestamp differs). Both the prepended signature and the KMS signature verify in both outputs. - Changing the lifetime in the wrapper by one hour makes the comparison fail, so the check is sensitive. ``` $ git -C gpgkms describe --tags v0.2.0 $ WRAPPER_ARGS_FILE=wrapper-args.txt go test ./cmd/gpgkms -run TestCoderWrapperMatchesOldCoderCode -count=3 -v === RUN TestCoderWrapperMatchesOldCoderCode equiv_coder_test.go:40: wrapper args: ["-name" "Coder Release Signing Key" "-email" "security@coder.com" "-created" "2026-11-16T00:00:00Z" "-lifetime" "35040h"] --- PASS: TestCoderWrapperMatchesOldCoderCode (0.33s) --- PASS: TestCoderWrapperMatchesOldCoderCode (0.11s) --- PASS: TestCoderWrapperMatchesOldCoderCode (0.20s) ok github.com/coder/gpgkms/cmd/gpgkms 0.634s # with -lifetime 35041h equiv_coder_test.go:56: public keys differ: FAIL # with the wrapper's -fingerprint pin and a random test key derived key has fingerprint 9794B34B5E098DE61DD6CE247E0DFD4BF203C917, want 0F685EFE0AE5A8182A473DD86E3A8E5613707520 (wrong -key, -created or KMS key?) ``` (The byte-for-byte comparison runs without `-fingerprint`, since the test key is random.) gpgkms also has its own compatibility test against this identity (`compat_test.go`). Other checks: ``` $ ./scripts/gpgkms.sh public-key # from the repo root (build.yaml) gpgkms: -key is required $ cd scripts && ./gpgkms.sh public-key # from scripts/ (build_go.sh -> execrelative) gpgkms: -key is required $ ./gpgkms.sh sign -key x -prepend ../no-such-file -out o.asc ../go.mod # relative paths resolve from the caller gpgkms: read prepend signature: open ../no-such-file: no such file or directory $ shellcheck -x scripts/gpgkms.sh scripts/sign_with_gpg.sh # clean $ shfmt -d scripts/gpgkms.sh scripts/sign_with_gpg.sh # clean $ actionlint .github/workflows/build.yaml # clean $ go build ./... && go mod tidy -diff # clean ``` Not run here: real signing through Cloud KMS. The first main build after merging prints the public key in the job summary; it should be identical to the one printed by current main builds. --- AI disclosure: this PR was written by an AI coding agent (Xum) at my direction, and the agent ran the verification above. It stays a draft until I've reviewed it. |
||
|
|
c0cc6cef4a |
ci: turn off docs PR previews (#32364)
docs-pr-preview-deploy.yaml has failed on every docs PR since 2026-11-17 22:59: its engine job reads the `DOCS_ENGINE_APP_ID` and `DOCS_ENGINE_APP_PRIVATE_KEY` repository secrets, which aren't set. This gates the engine job with `false &&`. The build, deploy and comment jobs need it, so they skip too, and docs PRs show skipped checks instead of failed ones. Previews come back by dropping `false && ` once the job has another way to read docs-engine. `test-docs-preview-mapper.sh` and actionlint pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
555069ef80 |
ci: run eval-coder-agents in its own eval environment (#32363)
The `run` job in `eval-coder-agents.yaml` checks out the PR's head and runs its code, including its own `scripts/harbor-coder`. It currently uses the `main` environment, which holds main-only secrets for other workflows. This moves it to a dedicated `eval` environment, so only eval secrets are ever in scope. - **Depends on** coder/github-org-terraform#124, which creates `eval` (only `main` may deploy, no reviewers, no admin bypass). Merge that first; otherwise GitHub creates `eval` unprotected on the first run. - **`EVAL_CODER_SESSION_TOKEN`:** the job references it, but it isn't set in `main` today. When it's added, put it in `eval`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e2abab288b |
ci: mint backport, automation, CI reader, CLA and membership App tokens with Cloud KMS (#32352)
Switches App token steps from `actions/create-github-app-token` with a private key to [coder/github-app-token-action](https://github.com/coder/github-app-token-action). Each App's key becomes a non-exportable Cloud KMS key that only the listed workflow, in its environment, can sign with (coder/gcp#383). | Workflow | App | Environment | Token | |---|---|---|---| | `backport.yaml` | `coder-backporter-app` | `main` | coder: contents, pull_requests, workflows, issues write | | `aigateway-prices-refresh.yaml` | `coder-automations` | `main` | coder: contents, pull_requests write | | `audit-docs-paths.yaml` | `coder-ci-reader` | `main` | coder.com: contents read | | `contrib.yaml` (`cla`) | `coder-cla` | `main` | cla: contents write | | `contrib.yaml` (`community-label`) | `coder-org-membership-bot` | `main` | members read | - **Scope is unchanged:** same repositories and permissions as before. The token is revoked when the job ends. - **Permissions:** each signing job gets `id-token: write`. - **backport.yaml and contrib.yaml community-label:** the old steps set no `repositories`, so the token defaulted to this repository. The action needs it explicitly, so they now say `repositories: coder`; the membership token requests only `members: read`, which is all the App has. - **Tighter than today:** the `main` environment holds all five keys, so any job in `main` could use any of them. Now each key only signs for the one workflow file above, on `main`. - **Secrets:** the KMS key and `APP_KEYS_WORKLOAD_ID_PROVIDER` are already set in the environment. The old private-key secret is deleted after this merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
85a786c4fa |
ci: mint release and package publisher App tokens with Cloud KMS (#32331)
Switches every GitHub App token step in the release workflows from `actions/create-github-app-token` with a private key to [coder/github-app-token-action](https://github.com/coder/github-app-token-action). Each App's key becomes a non-exportable Cloud KMS key that only these workflows, in their environments, can sign with. **`coder-release-publisher`** - `release.yaml` (environment `release`): the tagging token and the release-publishing token. - `create-release-branch.yaml` (environment `release-refs`, `main` only): the release-branch token. The job gets `id-token: write`. - Scope is unchanged: `repositories: coder`, `contents: write`, `workflows: write`. **`coder-package-publisher`** - `release.yaml` `publish-packages` (environment `release-publish`): `repositories: packages`, `contents: write`. - `release.yaml` `publish-homebrew` (environment `release-publish`): `repositories: homebrew-coder`, `contents: write`, `pull_requests: write`. - Both jobs get job-level `contents: read` and `id-token: write`. Before, they inherited the workflow's `contents: read`. **Unchanged** - Who approves: every environment still needs a release manager, and admins can't bypass. - Each token covers one repository and is revoked when its job ends. - The KMS keys, `APP_KEYS_WORKLOAD_ID_PROVIDER` and the App IDs are environment secrets, already set in `release`, `release-refs` and `release-publish`. Release branches 2.39, 2.38, 2.37, 2.34 and 2.29 run their own `release.yaml` and get the same change once this merges. The old private keys are deleted after that. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9c79ab71bb | ci: stop rcodesign finalizing and unloading the PKCS#11 module (#32333) | ||
|
|
e853deecb4 | ci: pin the Rust toolchain that builds rcodesign (#32306) | ||
|
|
8922988e34 |
ci: stop auto-approving Dependabot PRs (#32303)
Removes the step that approved Dependabot PRs with `GITHUB_TOKEN`. Auto-merge stays enabled, so a Dependabot PR merges as soon as a person approves it and checks pass. The approval came from `GITHUB_TOKEN`, so it met the one-review rule on `main` without anyone looking at the dependency update. The org is turning off "Allow GitHub Actions to create and approve pull requests", which would make the step fail anyway. From now on Dependabot PRs need a human approval like every other PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3e9dec617c |
ci: disable the Linear release sync (#32286)
`linear-release.yaml` fails on every push to `main` ([example](https://github.com/coder/coder/actions/runs/43946040791/job/133575848447)): `access_key input is required`. `LINEAR_ACCESS_KEY` isn't a repository secret anymore, and the `linear` environment that #32238 moves the jobs into has no secrets either, so that PR alone wouldn't fix it. This replaces the push trigger with `workflow_dispatch`, so nothing runs automatically. A manual dispatch doesn't sync either, because every job checks for a push event. The comment at the top says how to turn it back on: store a Linear access key in the `linear` environment, merge #32238 (`environment: linear` on each job), and restore the push trigger. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b4f8b6756c |
ci: validate the release commit input before checking it out (#32256)
The `release` job in `release.yaml` checked out the `commit` workflow_dispatch input before validating it. The only check (full SHA, ancestor of the dispatched branch head) ran in the `Create release tag` step, which is skipped when `dry_run` is true. A dry run could therefore check out any ref the repository resolves, such as an unprotected branch, a pull-request head or an unmerged commit, and run its scripts and the local `build-coder` action in the `release` environment with the signing secrets, the OIDC signing identities and the release App token. Changes: - Always check out the dispatched commit (`github.sha`) first. A new step, run from the workflow file and not from the tree being checked, requires `commit` to be a full 40-character SHA that is an ancestor of `GITHUB_SHA`, then switches to it with `git checkout --detach`. This runs for dry runs and real releases before any repository script, local action or credential. Without a `commit` input nothing changes. - Skip `Generate release App token` on dry runs. A dry run creates no release, and `scripts/release/publish.sh --dry-run` never calls `gh`, so it needs no token. - Document that dry runs still sign (to exercise the signing path) and that this relies on the commit check above. The existing check in `Create release tag` stays as a second line of defence. Verification: ran the new step's script against a scratch repository. It accepted an ancestor SHA and the branch head. It refused an unmerged branch SHA, a branch name, `refs/pull/1/head`, an uppercase SHA and a missing SHA, leaving HEAD unchanged. actionlint passes. --- _Generated by [Claude Code](https://claude.ai/code/session_015koAoN7npVzwZjdWhi3V5o)_ Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
368fddf1d6 |
feat: deploy dogfood by pulled digest instead of CI push (#32253)
Switches dogfood from push-based deploys to pull-based, digest-pinned deploys with Flux image automation (SEC-863): - **Remove the push deploy.** Deletes `deploy.yaml` and `scripts/should_deploy.sh`, and drops the `deploy` job from `build.yaml`. CI no longer assumes the AWS deploy role, fetches EKS credentials, runs `flux reconcile` or `kubectl rollout restart`, or retags `:dogfood`, which nothing consumes. `build.yaml` now has no cluster access, and only the signing job's existing `id-token: write` remains. - **`coder.image.digest`** in the `coder`, `provisioner` and `ai-gateway` charts. When set, the image renders as `repo:tag@digest`. Empty (the default) keeps today's output, and existing golden files are unchanged. - **Sortable main tag.** `build.yaml` pushes an extra `main-<commit unix time>-<12 char sha>` tag for every main build, which the Flux `ImagePolicy` orders on. The `prune` job already prunes `^main-` tags older than 30 days. Companion PR: coder/dogfood#857, which installs the image controllers and pins dogfood-cdr by digest. **Merge this one first**: the ai-gateway chart's schema rejects unknown keys, so dogfood's new `digest` value would fail on the current chart. Merging this before dogfood#857 doesn't regress anything. The `dogfood-coder-repo-ci` role's trust was disabled during containment, so the deploy job currently fails at OIDC role assumption on every main build and only sends a failure alert to Slack. Until dogfood#857 is live, dogfood stays on its current image. <details> <summary>Design notes and decision log</summary> - **Delete the deploy instead of keeping a Flux webhook ping.** A ping would only cut latency. Flux scans the registry every 2m, so any trigger can be added later as a notification-controller `Receiver` without giving CI cluster credentials. - **Separate digest value instead of `tag: x@sha256:...`.** Flux's `:tag` and `:digest` setters write separate fields, and no setter writes `tag@digest` into a single field. A dedicated chart value is the documented Flux pattern for HelmReleases and is useful to customers who pin by digest. - **Commit timestamp in the tag.** `git log -1 --format=%ct` makes the tag sort by commit time, which Flux's `numerical` policy selects on. The sha suffix keeps tags unique and traceable. - **Not done here:** - Making the cosign and GitHub attestation steps required. They're still `continue-on-error`. Admission-time signature verification is a separate SEC-863 step. - Removing the AWS role itself and the `AWS_DOGFOOD_*` repo variables. Those are settings outside the repo, and they become unused once this merges. </details> Verified: `go test ./helm/...`, `make lint/helm`, `make lint/actions`. I also rendered the dogfood-cdr values against this branch's charts, and the server, provisioner and ai-gateway images all come out as `ghcr.io/coder/coder-preview:<tag>@sha256:<digest>`. Refs SEC-863 > Generated by Coder Agents on behalf of @deansheather. |
||
|
|
b0a66bd878 |
ci: build and sign main and releases with a shared build-coder action (#32229)
> [!NOTE] > Generated by Coder Agents on behalf of @deansheather. Main builds and releases now build and sign through one shared composite action, so they can't drift apart. PR builds use the same action unsigned, in a job with no environment, so they can't reach signing secrets or identities. Depends on coder/gcp#343, which must merge first. The `release-signer` identity provider only accepts tag-dispatched releases and `ci.yaml`. Since #32211 made that login unconditional, releases and non-push main runs already fail today. ## Changes - **`.github/actions/build-coder` (new):** tool setup, then `make` for the given targets. With `sign: true` it signs darwin binaries with the Apple key in Cloud KMS, Windows binaries with EV, and everything with GPG (the legacy key plus the optional KMS key). With `notarize: true` it also notarizes. Composite actions can't read secrets, so callers pass them in. - Signing material goes in a `$RUNNER_TEMP/coder-signing` directory with mode 700 and is removed with `if: always()`. - Signing builds disable the mise, pnpm and rcodesign caches. - KMS signing no longer checks the event or ref. If the provider rejects a run, the build fails loudly. - **`.github/workflows/build.yaml` (new):** the signed main and `release/*` build, moved out of `ci.yaml`. - Triggers: `push` to `main` and `release/*` (ignoring the same docs-only paths as `ci.yaml`'s `changes` filter), plus `create` for `release/*`. No `pull_request` or `workflow_dispatch`. Top-level `permissions: {}`. - The `build` job runs in `ci-signing`. It builds and signs, pushes `coder-preview` tags, then runs SBOM, image attestations and binary attestations (new), and uploads artifacts. - `prune` runs `action-ghcr-prune` in its own job, away from the signing credentials. - `deploy` calls `deploy.yaml`. `notify-slack-on-failure` covers build, prune and deploy failures on main. - **`ci.yaml`:** - The `build` and `deploy` jobs are removed. - `check-build` now runs `make build-slim` through the action, unsigned. That compile-checks all 7 OS/arch targets without the frontend and fat builds. - `check-build` also runs when CI files change. - **`release.yaml`:** - Builds and signs through the action with `notarize: true`. Tagging, base image, images, attestations and publishing are unchanged. - The `refs/tags/*` KMS gate is removed. - The publish step now reads the `release-signer` credentials from the action's output. - **Hardening on top of #32211:** - `install-rcodesign` gains a `use-cache` input, which signing jobs set to `false`. Depot caches are shared across branches, so a PR could otherwise plant a binary under the cache key that a signing job would run with signing credentials. - `cargo install --locked` pins rcodesign's dependency tree. I verified the lockfile resolves with the patch at the pinned revision. - `sign_darwin.sh` takes `AC_PKCS11_CREDENTIALS_FILE` and sets `GOOGLE_APPLICATION_CREDENTIALS` only for `rcodesign`. The `release-signer` credentials no longer reach the whole `make` step. - The jsign jar is now verified against a pinned sha256. ## Validation - `make lint/actions/actionlint` passes. zizmor (offline, strict collection) reports no findings. shellcheck passes on every `run` block in the composite actions. - I dry-ran the signing-material and target-parsing logic locally. The kmsp11 config renders correctly and files are mode 600. Multi-line targets parse correctly. - Not run: a real signed build. The first main run after merge should show `.asc` and `.v2.asc` files, rcodesign and jsign output, `coder-preview:main` pushed and dogfood deployed. A release dry run from `main` covers `release.yaml` once #56 lets the `release` environment run on `main`; release branches still carry the old `release.yaml`. ## Follow-ups (manual) - After the first successful signed main build and release, delete `AC_CERTIFICATE_P12_BASE64` and `AC_CERTIFICATE_PASSWORD`. - The Rust toolchain is still whatever `stable` the runner has. Rebuilding rcodesign without the cache adds a few minutes to each signed build. The `release` environment changes and the release-branch `ci.yaml` signing are handled in coder/github-org-terraform#56 and coder/gcp#343. ## Merge order (all 8 PRs) coder/gcp applies on merge, so the order matters. 1. coder/github-org-terraform#56: the `code-signing` environments, tag rulesets, and coder/coder `release` and `release-publish` allowing `main`. This must be applied before an RC can be dispatched from `main`. 2. coder/gcp#343, then coder/coder#32229 right after. Signed `ci.yaml` builds on `main` fail between those two. `release/2.37` to `2.39` keep signing through `ci.yaml` under #343's temporary rule until 2027-02-16. 3. coder/coder-desktop-windows#192, coder/mutagen#19, coder/pr-buddy#69 and coder/xum#8170. 4. coder/gcp#347. Windows signing in those 4 repos breaks if this lands before step 3. <details> <summary>Plan and decision log</summary> **Goal:** main and `release/*` pushes build coderd fully, sign everything (EV, Apple, GPG and KMS GPG) the same way releases do, push `coder-preview`, and deploy dogfood. PRs get a compile check with no signing access. **Verified constraints:** - Signing secrets exist only in the `ci-signing` and `release` environments. There are none at the repo or org level. - `ci-signing` allows `main` and `release/*`. `release` requires `release-managers` with self-review prevented, and admins can't bypass. - `ev-code-signing` (coder-ci) and `release-signer` (coder-release-signing) are bound only to the `environment:ci-signing` and `environment:release` subjects. - The `release-signer` provider condition checks `job_workflow_ref`. A reusable workflow would change that claim, so the shared code is a composite action that runs inside the caller's job. This also keeps the release job as a single job, with no artifact handoff between build and publish. **Decisions:** - The new workflow is named `build.yaml`. - There is no cutover period, so the provider names only `build.yaml`. - Main builds are signed identically to releases. Only notarization and publishing differ, because main doesn't build darwin archives. - `release/*` still gets `coder-preview:release-X.Y` images. - PR `check-build` builds slim binaries only, which keeps the cross-compile coverage at a fraction of the cost. </details> |
||
|
|
a97894bf03 |
ci: refuse to tag a commit that was already released (#32240)
`version.sh` fails when the released commit has two release tags, with a misleading "not tagged with an annotated tag" error. Re-releasing without a new commit (v2.39.3, v2.38.9, v2.37.13) tagged the same commit as the previous release, failed at "Print version", and left a stray tag that only the release App can remove. This fails before creating the tag instead, saying the commit was already released and to merge a new commit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) |
||
|
|
a8ed5a1b65 | ci: sign darwin binaries with an Apple signing key in Google Cloud KMS (#32211) | ||
|
|
b83a339e03 | chore: add optional Cloud KMS dual signing for release GPG signatures (#32209) | ||
|
|
3c953d2ae4 |
ci: use GitHub App tokens instead of the cdrci machine-user tokens (#32218)
## Summary Replaces the `cdrci`/`cdrci2` personal access tokens in three workflows with short-lived GitHub App tokens. Each token is scoped to one repository and the permissions it needs. | Workflow | Was | Now | | --- | --- | --- | | `aigateway-prices-refresh` | `CDRCI_GITHUB_TOKEN` | `coder-automations` App: contents + pull requests write on `coder/coder`. App-opened PRs still trigger CI. | | `contrib` (CLA) | `CDRCI2_GITHUB_TOKEN` | `coder-cla` App: contents write on `coder/cla` only. | | `audit-docs-paths` | `CDRCI_GITHUB_TOKEN` | `coder-ci-reader` App: contents read on `coder/coder.com` only. | The App IDs and keys are already in the `main` environment, which all three jobs already use. Nothing else in the jobs changes. The `CDRCI_GITHUB_TOKEN` uses in `release.yaml` (winget) are separate: they need a token for a fork on a personal account, which an App can't provide. ## Testing - `actionlint` is clean. - `zizmor`: no new findings. The two it reports (the archived CLA action, and `community-label`'s token) were already on `main`. - After merge: dispatch `aigateway-prices-refresh` once, and comment `recheck` on a community PR to confirm the CLA bot. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
12766eca93 |
ci: create release tags and branches with the release App after approval (#32212)
## Summary **Unblocks releases after the `coder/coder` lockdown.** Only the `coder-release-publisher` App can now create tags and release branches (rulesets "Release tags (App only)" and "Release branch creation", managed in `coder/github-org-terraform`). Its key is only available in environments that need a **second release manager's approval** (`release-managers`, no self-review, no admin bypass). People can't push release tags anymore, so the tag is now created **inside the approved release run**. ### Releasing (`./scripts/release.sh` works as before, minus one step) 1. Run `./scripts/release.sh` on `release/X.Y` (or `main` for an RC), as today. It still picks the version, checks open PRs and breaking changes, and writes the release notes. 2. Instead of creating and pushing the tag, it checks the commit is already on `origin/<branch>` and dispatches `release.yaml` **on the branch** with `version`, `commit`, `release_channel` and `release_notes`. 3. The releaser prints the run's URL. GitHub also notifies the `release-managers` reviewers. **Another release manager approves** the run's `release` environment (Review deployments). 4. The approved job creates the annotated tag `version` at `commit` with the App, then builds, signs and publishes that commit as before. `release.yaml` can also be run by hand from the Actions UI with the same inputs. ### `release.yaml` - New `version` and `commit` inputs (required unless `dry_run`). - The `release` job checks out `commit`. Before anything else, it: - refuses a malformed version; - refuses a version that doesn't match the branch (`release/X.Y`, or `main`/`release/X.Y` for `-rc.N`); - refuses a commit that isn't already on the dispatched branch; - refuses an existing tag that points elsewhere; - otherwise creates the annotated tag with the App. A re-run reuses a tag already at that commit. `version.sh` and the rest of the job are unchanged. - **Homebrew and the `coder/packages` dispatch use the new `coder-package-publisher` App** (`release-publish` environment) instead of `CDRCI_GITHUB_TOKEN`. The dispatch moves to its own `publish-packages` job in `release-publish`, where that key lives; it's approved together with Homebrew and winget. Winget still uses the `cdrci` machine user, since an App can't open PRs on `microsoft/winget-pkgs`. - Every App token is scoped to one repository and the permissions it needs (`zizmor`'s `github-app` audit: 5 high findings to 0, one of which predates this PR). ### `create-release-branch.yaml` (new) Dispatched on `main` with `version` (e.g. `2.40`) and `commit`. After approval in the `release-refs` environment, it creates `release/X.Y` at that commit, refusing one that isn't on `main` or a branch that already exists. ### `scripts/releaser` - `ReleaseExecutor` drops `CreateTag`/`PushTag`. - `TriggerWorkflow` dispatches on the branch with `version` and `commit`. - An existing tag must already point at HEAD. - After dispatching, it looks up the run (`gh run list`, polling briefly) and prints its URL and the approval steps. ## Before merging - [ ] `RELEASE_APP_ID` and `RELEASE_APP_PRIVATE_KEY` set in the **`release-refs`** environment (currently empty), and the rotated release App key in `release`. - [x] `CODER_PACKAGE_PUBLISHER_APP_ID` / `CODER_PACKAGE_PUBLISHER_APP_PRIVATE_KEY` in `release-publish`; App installed on `homebrew-coder` and `packages`. ## After merging: backport to every branch you release from `release.yaml` runs from the dispatched branch's own copy, and `./scripts/release.sh` runs the branch's releaser. So **each `release/X.Y` needs this change before it can release**. Active lines by recent tags: `release/2.39`, `2.38`, `2.37`, `2.36`, `2.35`, `2.34`, `2.29`. ## Relation to #31321 #31321 (`Tag release`) runs the releaser non-interactively in CI. This PR is the smaller change that unblocks releases now. #31321 can build on it: its tagging job would need `environment: release-refs` (where the App key lives) plus the extra App permissions it asks for, which are a manifest change in `coder/github-org-terraform` `apps/`. ## Testing - `go build`, `go vet`, `go test ./scripts/releaser` pass. - `actionlint` and `zizmor` are clean on both workflows. - Not exercised end to end. Suggest the first use be an RC (`v2.40.0-rc.N` from `main`), watching the tag step. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9bafd0a525 | ci(.github): skip a doc-check run when the PR head already has a finished review (#32198) | ||
|
|
a921700974 | ci: report only wrong, missing, and broken findings in CI doc-check reviews (#32199) | ||
|
|
dc55633b47 |
ci(.github): start a new doc-check chat per run and stop it when the run ends (#32185)
## Summary doc-check reused one chat for every push to a PR, and a review kept running in Coder after its job stopped waiting for it. This PR starts a new chat for each run, waits up to 5 hours for it, and stops the review and its workspace when the run ends for any reason. On dogfood at 2026-11-13 17:28 UTC, 58 doc-check review chats and 45 of their sub-agents had status `running`, while 5 workflow runs were in progress and 1 was queued. 34 of the 58 chats were created before that day, and the oldest on 2026-09-29. The count covers only chats shared with me, so it is a lower bound. This combines the workflow half of #32061 with the stop script from #31720, and changes no skill file. ## Changes - **New chat per run.** `force-new-chat` replaces the one chat per PR, so a re-run no longer carries every earlier turn on the PR. The prompt gets a `## Previous run` section with the `doc-check-trace` of the latest finished review. - **One workspace per PR.** The job finds `doc-check-pr-<N>`, wakes and starts it, and passes its ID to the chat. On the first run the chat creates the workspace under that name. - **A started review finishes; pushes are debounced.** The review job's concurrency group is keyed on the PR URL with `cancel-in-progress: false`. GitHub keeps one pending run per group and replaces it on each push, so the next review covers the latest head. A `debounce` job sleeps 5 minutes on `synchronize`, in its own group with `cancel-in-progress: true`, so a burst of pushes starts one review. Other triggers do not wait. Merging the PR still cancels a running review (the `delete-workspace` job keeps `cancel-in-progress: true`), then deletes the workspace. - **Every run stops its review.** `.github/scripts/doc-check-stop-review.sh` runs before the review and in a final `always()` step. It drops queued messages, interrupts the chat and its sub-agents, and stops the workspace. - **5-hour wait.** `wait-timeout-seconds` goes from 2400 to 18000, and the job timeout from 50 to 330 minutes. The job now stays in its concurrency group for the whole review, so the next run for the PR waits for it. - **Previous trace lookup.** `.github/scripts/doc-check-previous-trace.sh` reads the 5 newest review chats for the PR and prints the first trace with an `outcome:` line. It reads more than one chat because a cancelled run's chat has no trace. A failed lookup costs only that context and never fails the job. - The `GITHUB_OUTPUT` delimiter for the prompt is random, because the trace is model output. ### Behavior changes to check | Before | After | Why | |--------|-------|-----| | A review past the wait ended the job with a green notice and kept running (#32097) | The last step stops the review, and the job fails | Nothing watches a review after the job ends | | A review kept running after its PR merged | The merge cancels the run | The result has no reader | | The `doc-check` label forced one review, on the `labeled` event | The label forces a review on every push until it is removed | The push run would otherwise skip on paths with no docs surface | | Runs for one PR queued | A started review finishes; pushes during it collapse into one pending run for the latest head, after a 5-minute debounce | Cancelling threw away prefill and starved busy PRs of a verdict | ## Testing Static checks, all passing: `actionlint`, `zizmor`, `shellcheck --external-sources`, and `shfmt -d`. Script tests, run locally: - `doc-check-stop-review.test.sh`: 48 cases against a fake API. - `doc-check-previous-trace.test.sh`: 22 cases, including CRLF in the trace text and in the PR URL. - Mutation check on the trace script: 25 one-line breaks, and the suite failed on 24. The survivor was a redundant trim, which I removed. - The trace extraction ran against 12 real finished doc-check chats on dogfood and returned a trace for all 12 (750 to 3,500 characters). End to end on dogfood, on this PR, 2026-11-13 UTC: | Run | Trigger | Result | |-----|---------|--------| | [1](https://github.com/coder/coder/actions/runs/43474029515) | dispatch, 17:33 | No workspace and no earlier chat. New chat created the workspace `doc-check-pr-32185` and had 2 running sub-agents at 17:48:23. | | [2](https://github.com/coder/coder/actions/runs/43476429715) | dispatch, 17:48:25 | Cancelled run 1 at 17:48:27. Run 1's last step interrupted the chat and both sub-agents and stopped the workspace by 17:48:51. Run 2 then started the same workspace, opened a second chat in it, finished clean at 17:52:54, and stopped the workspace. | | [3](https://github.com/coder/coder/actions/runs/43477511866) | dispatch, 17:55:08 | Cancelled by run 4 while the workspace was starting. Its last step stopped the workspace mid-start. No chat was created. | | [4](https://github.com/coder/coder/actions/runs/43477572348) | `ready_for_review`, 17:55:31 | Waited for run 3 to end, then opened a third chat in the same workspace. That chat's first message carries run 2's trace under `## Previous run`. | Not covered: - The 5-hour timeout path has not run live. The fake-API tests cover the script, and the summary text is a few lines of shell. - The merge path (`delete-workspace` cancelling a review) has not run live. - No CI job runs the two `.test.sh` suites. The workflow runs on `ubuntu-latest` only, and the scripts were not run on macOS or Windows. ## Follow-ups, not in this PR - Skip a run when the head SHA or the PR diff matches the last reviewed one. - Set a status on the head SHA from the trace. - Cancel a review when its PR closes without merging. Supersedes #31720 and the workflow half of #32061. Linear: DOCS-1745 <details> <summary>Plan and decision log</summary> This is PR 1 of a 5-part stack from the design doc "Design: reliable, low-cost doc-check on Solstice". 1. Workflow base: new chat per run, previous trace, workspace ID, 5-hour wait, cancel-in-progress, and the stop script. **This PR.** 2. Skip in Actions: same head SHA, same PR diff, and a delta since the last reviewed SHA with no docs surface. 3. Visible outcome: a status on the head SHA from the trace, for clean, findings, error, and skipped. 4. Packet and lint in Actions: PR data, diffs, open threads, and deterministic check results, written once. 5. Skill: scope to wrong, missing, and broken, tiers, a sub-agent cap, and one long wait. Gated by an eval. Decisions in this PR: - **Why this first.** A re-run's first prompt was 1.01 times the previous run's last prompt, so each push re-sent the whole history of the PR. A new chat per run removes that, and stopping stale reviews removes load that no job is watching. - **5 hours, not 25 or 40 minutes.** Reviews on the local model took a median of 61 minutes when clean and 247 minutes with findings (2026-11-04 to 11-11). A shorter wait would stop most reviews with findings before they post. With `cancel-in-progress`, a new push still ends the review of the old head at once. - **A timeout fails the job.** This reverses #32097, where a timeout was a notice. A green job with no review reads as a clean result. - **The stop runs twice.** The first step catches a review left by a run whose last step did not finish, for example a runner that died. - **The trace lookup is a script with tests, not inline YAML.** It parses model output, and it has to handle chats with no trace, a trace with no outcome, and CRLF. - **The trace is passed as a record, not as instructions.** The prompt says so, and asks for a review of the whole PR. A delta review needs the skip logic and the ledger from later PRs in the stack. - **No skill change.** The skill changes are gated by an eval that does not exist yet. </details> Follow-up commit `64a09655a1` (finish-then-rerun and debounce) generated by Coder Agents on behalf of @bpmct. _Generated by Coder Agents on behalf of @nickvigilante._ --------- Co-authored-by: Ben Potter <me@bpmct.net> |
||
|
|
eb87132790 |
test: stop Terraform tests from downloading providers that should be cached (#32146)
fix(test): avoid unnecessary Terraform provider downloads in CI Fix Terraform provider download flakes caused by GitHub 500/504 errors by improving provider cache reuse and CI cache uploads. - **Fix provider cache misses:** Use a stable providers-only configuration in `TestWorkspaceTemplateParamsChange` instead of a template containing a temporary path. - **Update CI cache keys:** Include a hash of cache entry names so new providers are cached immediately after a successful `main` run, rather than waiting for the next day. - **Reduce cache growth:** Avoid approximately 13 MB of redundant cache data per job per day. - **Preserve existing behavior:** Failed jobs do not save caches, and cache restore and retry behavior remain unchanged. **Validation:** - Confirmed repeated test runs reuse cached providers without creating new cache directories. - Verified Terraform tests pass with network access blocked after the cache is populated. - Confirmed cache keys remain stable when entries are unchanged and update when entries change. - All affected tests and `make lint/actions/actionlint` pass. **Note:** The CI upload action runs only on `main` and requires post-merge verification. Refs: https://linear.app/codercom/issue/CORE-40/flake-gen-terraform-provider-download-failure-context-deadline |
||
|
|
b71e1d492a | ci: log in to Docker Hub right before the dogfood push (#32130) | ||
|
|
ddf89cc69a | ci: run dogfood build_image in the main environment on main (#32123) | ||
|
|
13e673e9c2 |
ci: build docs PR previews on per-PR preview sites (#30698)
Docs previews at `coder.com/docs/@<branch>` share coder.com's origin and cookies with the real site. This publishes each pull request's docs as its own site on `docs.cdr-preview.dev`, a domain used only for previews (repository variable `DOCS_PREVIEW_DOMAIN`), and points the existing `docs-preview` comment's per-page links and checkboxes at it. ## URLs - `https://pr-<n>.docs.cdr-preview.dev`: the PR head, re-aliased on every build. A slower build of an older commit doesn't take it back. - `https://pr-<n>-<first 9 of sha>.docs.cdr-preview.dev`: one per built commit, listed newest first in a collapsible "Preview sites" list in the PR's docs preview comment, so reviewers can step through the branch. - Every URL is built from `vars.DOCS_PREVIEW_DOMAIN` (aliases, comment links, cleanup); nothing hard-codes the domain. Previews moved off `coderite.app`, which also hosts login-protected internal sites, so a preview page whose content any coder/coder writer controls would have been same-site with them. `cdr-preview.dev` hosts nothing else, and the docs previews sit under `docs.` so other preview kinds can get their own subdomain later. The jobs fail with a clear error if it is unset or a `vercel.app` name, because `*.vercel.app` names are first-come across all Vercel accounts and anyone could claim a preview's name before our deploy or after cleanup frees it. - Every preview carries the docs CSP and the other headers from docs-engine's `apps/offlinedocs/vercel.json`, plus `X-Robots-Tag: noindex`, which the deploy job prepends to the Build Output API `config.json` routes without touching the existing ones. - On merge or close, every deployment tagged `pr=<n>` and its aliases are deleted. A weekly groom (Mondays 07:23 UTC, also `workflow_dispatch`) deletes previews of any closed PR, in case a close event was missed. ## Who gets previews Only PRs from a branch in coder/coder, on every push that touches `docs/**`. Every job in the deploy workflow, and the close path of the cleanup, requires `github.event.pull_request.head.repo.full_name == github.repository`. Fork PRs get no preview for now. Building fork content in a `pull_request_target` run would share the base branch's Actions cache scope, so a fork could poison main's cache, and it would sit beside the private engine source. Fork previews come in a follow-up once the build runs in a no-network sandbox (or the public builder kit ships). That follow-up will gate on a maintainer stating the exact approved commit, not on a label, so a push after approval can't slip in. ## One comment, posted only after a deploy `docs-preview.yaml` is now a reusable workflow (`workflow_call` only). The deploy workflow's `comment` job calls it after `deploy` succeeds, so the per-page links never point at a preview that doesn't exist yet. I chose this over moving the per-page logic into the deploy job: the existing comment logic and its mapper test stay as they are, and only the trigger changes. Each PR gets at most one bot comment. The deploy job posts nothing; it passes the built commit (`short_sha`) to `docs-preview.yaml`, which adds a collapsible "Preview sites for each built commit" list to its comment, newest first, read back from the comment on each run and capped at 100. That comment is only posted when a non-generated page or an image changed: a PR that changes only `docs/reference/**` (generated CLI and API pages), or nothing previewable, gets no comment, and an earlier one is deleted. Engineers found the earlier two-comment version too noisy. If the comment is deleted that way and a later push brings it back, its commit list starts over; the earlier previews still exist until the PR closes. ## Three jobs, so PR content never runs beside a secret 1. `engine`: checks `DOCS_PREVIEW_DOMAIN` first, reads the docs-engine commit pinned in `docs/.engine-ref` (from the PR head, falling back to the base for a branch that predates the pin), mints a short-lived token from a GitHub App installed only on coder/docs-engine, downscoped to `contents: read` on that one repository, checks out with `persist-credentials: false`, and uploads a tarball plus its sha256 as a job output. Never touches PR content. 2. `build`: no secrets, `contents: read` only. Verifies the engine tarball against the digest, sparse-checks out the PR's `docs/`, refuses a `docs/` that is or contains a symbolic link (one could pull runner files, such as the private engine source, into a public preview), builds `apps/offlinedocs` with `DOCS_ROOT` as docs-engine's own `docs-pr-preview.yml` does, and uploads only the static `out/` export. 3. `deploy`: in the `docs-preview` environment with `VERCEL_PREVIEW_TOKEN`. Verifies the engine tarball against the digest again (a compromised build job could replace an artifact, but not a job output), refuses an export holding anything but regular files and directories, lays the static files out with the engine's `build:output` script, adds noindex, runs `vercel deploy --prebuilt` with meta `pr` and `sha`, and sets both aliases through the Vercel API. It holds only `pull-requests: read`, for the check that the PR head hasn't moved before re-aliasing; the `comment` job posts the comment. It runs the engine's trusted script rather than taking `config.json` from the build job, because a Build Output directory from another job could carry serverless functions or rewritten routes. `docs-pr-preview-cleanup.yaml` keeps `pull_request_target: closed` so a PR can't change its own cleanup; it checks out nothing and runs no PR content, only Vercel and GitHub API calls. Fork PRs have no previews, so their close is skipped. PR-chosen strings never reach a log line unfiltered: the comment workflow prints changed reference-page paths with every character outside a path allowlist as `?`, so a file name can't forge a `::` or `##[` workflow command, and the deploy job's errors name no path. ## Engine pin `docs/.engine-ref` now pins docs-engine `main` at `eadb477`, the engine `coder.com/docs` launched with on 2026-10-28 (was `e3c55c2`; an earlier revision of this PR pinned `5584d67`). The commands the workflow runs are unchanged between them. `e3c55c2` already had the `build:output` script, but the newer engine refuses a symlinked docs root, renders search hits without raw HTML, drops author-chosen heading ids that could break hydration, and pins Node 22.23.4, which the build and deploy jobs now use too. The commands the workflow runs (`pnpm turbo run build --filter=@coder/offlinedocs` and `apps/offlinedocs/scripts/build-output.mjs`) are unchanged at `5584d67`. The pin must be a commit on docs-engine `main`. The `engine` job checks docs-engine out with full history and fails before packing unless `git merge-base --is-ancestor "$REF" origin/main` passes. Once docs-engine is public, a commit pushed to any fork of it can be fetched by SHA through `coder/docs-engine`, so the 40-hex format check alone would let a PR build with unreviewed engine code. `test-docs-preview-mapper.sh` pins that the check runs in the `engine` job, before the pack step, against a full-history checkout. ## Before this can run Checked on 2026-11-12: IT registered `cdr-preview.dev` in Vercel on team `team_tGkWfhEGGelkkqUUm9nXq17r`, with Vercel nameservers, so `*.docs.cdr-preview.dev` needs no DNS or wildcard step. IT also set `docs.cdr-preview.dev` as the `coder-docs-pr-preview` project's own preview deployment suffix and removed `coderite.app` from it, so the project's generated deployment URLs land on the preview domain too, not on the team's `coderite.app` suffix; the first deploy will confirm that. The project has Vercel Authentication and password protection off. The secrets `DOCS_ENGINE_APP_ID` and `DOCS_ENGINE_APP_PRIVATE_KEY` exist. `DOCS_PREVIEW_DOMAIN` is set to `docs.cdr-preview.dev`. The `docs-preview` environment exists (created 2026-10-28) with no protection rules and no branch policy, and holds `VERCEL_PREVIEW_ORG_ID` and `VERCEL_PREVIEW_PROJECT_ID`, and `VERCEL_PREVIEW_TOKEN` was stored on 2026-11-12. - [ ] **GitHub App** (org owner; requested in DOCS-1739). Confirm the app behind `DOCS_ENGINE_APP_ID` is installed on coder/docs-engine only ("Only select repositories") with Repository permissions Contents: Read-only and Metadata: Read-only and nothing else, at https://github.com/organizations/coder/settings/installations. The workflow also downscopes each token to `contents: read` on docs-engine, so the installation is the outer bound. - [x] **Repository variable**, set on 2026-11-12. Set it at repository level, not on the environment, because the `engine` job and `docs-preview.yaml` run outside it: ```sh gh variable set DOCS_PREVIEW_DOMAIN -R coder/coder --body docs.cdr-preview.dev ``` - [x] **Vercel Authentication off** on `coder-docs-pr-preview` (`prj_RiVa1voPHmsfbEXkasFDXmYqAr0L`): checked on 2026-11-12, `ssoProtection` and `passwordProtection` both report `enabled: false`. - [x] **Preview domain** (IT): `cdr-preview.dev` registered with Vercel nameservers, and `docs.cdr-preview.dev` set as the project's preview deployment suffix. - [x] **Project-scoped Vercel token**, 90-day expiry (created 2026-11-12, expires about 2027-02-10; a rotation reminder is set for 2027-02-09). The three checks below returned `200`, `404` and `403`. Create it at https://vercel.com/account/settings/tokens, scoped to the `coder-docs-pr-preview` project only (`vercel tokens create --project` is refused for non-owners). Then check, with the new token in `$VERCEL_PREVIEW_TOKEN`, that it can list the project's deployments (`200`), reach the team-level alias API (`404`, not `403`), and cannot see the production `coder-docs` project (`403` or `404`, never `200`): ```sh curl -sS -o /dev/null -w '%{http_code}\n' -H "Authorization: Bearer $VERCEL_PREVIEW_TOKEN" \ "https://api.vercel.com/v6/deployments?teamId=team_tGkWfhEGGelkkqUUm9nXq17r&projectId=prj_RiVa1voPHmsfbEXkasFDXmYqAr0L&limit=1" curl -sS -o /dev/null -w '%{http_code}\n' -X DELETE -H "Authorization: Bearer $VERCEL_PREVIEW_TOKEN" \ "https://api.vercel.com/v2/aliases/pr-0.docs.cdr-preview.dev?teamId=team_tGkWfhEGGelkkqUUm9nXq17r" curl -sS -o /dev/null -w '%{http_code}\n' -H "Authorization: Bearer $VERCEL_PREVIEW_TOKEN" \ "https://api.vercel.com/v6/deployments?teamId=team_tGkWfhEGGelkkqUUm9nXq17r&projectId=prj_pC4y7hjUgcsYYNoSDL7pNJnafzh3&limit=1" ``` - [x] **`docs-preview` environment**: it exists with no branch policy (because `pull_request` runs on the merge ref) and its two variables are set. Only the token is left: ```sh gh secret set VERCEL_PREVIEW_TOKEN -R coder/coder --env docs-preview ``` `gh secret set` prompts for the token so it stays out of shell history. - [ ] **Security sign-off** (Lisa), on these points: - **Preview domain.** Previews now live on `docs.cdr-preview.dev`, which hosts nothing else, so they are no longer same-site with the login-protected sites on `coderite.app`. Previews are same-site with each other, so one PR's preview could set a cookie the others receive. Anything added to `cdr-preview.dev` later should stay outside `docs.` and not rely on cookies scoped to the parent domain. The docs CSP allows inline scripts, and any coder/coder writer controls a preview's content. - Any coder/coder writer can reach `VERCEL_PREVIEW_TOKEN` by editing the workflow on a branch, as with any secret a `pull_request` deploy uses. The token is scoped to the one preview project to bound that; required reviewers on the environment would close it, at the cost of an approval per preview. - The engine commit comes from the PR's `docs/.engine-ref`, so the engine code that lays out the export in the deploy job is PR-chosen, but only among commits on docs-engine `main`. It runs before, not in, the step that holds the token. - [ ] **Mark ready for review** once the items above are done and a docs push to this PR has produced a working preview. ## Testing `test-docs-preview-mapper.sh` checks that `docs-preview.yaml` reads the domain from `vars.DOCS_PREVIEW_DOMAIN`, builds links on `pr-<n>.<domain>` from the validated value with no `coder.com/docs/@` or `vercel.app` link, and runs only as a reusable workflow called after `deploy`. It also checks the per-commit list (this commit first, earlier ones carried, repeats and other PRs' lines dropped, capped at 100), that the list round-trips through the comment it renders without touching checkbox state, and that the deploy job posts no comment and passes its commit on. All 58 checks pass (run with GNU coreutils, sed, grep and awk on macOS); the new workflow check failed before the change. `actionlint` at the repo's pinned commit, with ShellCheck, reports nothing, and so does the repo's pinned zizmor 1.11.0 (`--strict-collection --persona=regular`). The noindex step was run against a `config.json` from docs-engine's real `build-output.mjs`: the route count went from 11 to 12 with the CSP route intact. With the variable, environment and token in place, the `engine` and `build` jobs pass on this PR, including the check that the pinned engine commit is on docs-engine `main`. The first deploy failed at `vercel pull` with "Could not retrieve Project Settings": Vercel CLI 59.3.0 looks up the token's team (403 for a project-scoped token) and gives up, although the token reads the project (200). Run locally with the same token, 65.11.0 skips that lookup and pulls the settings, so the workflow now pins 65.11.0, the newest release more than a week old. The deploy, alias and cleanup calls have not completed in CI yet. --- 🤖 Built with AI assistance. |
||
|
|
6171bee0b2 | ci: use OIDC for Depot and Docker Hub in dogfood (#31882) | ||
|
|
e49fe29600 |
ci(.github/workflows): don't fail doc-check when the review outlives the wait (#32097)
The doc-check chat keeps running in Coder after the job stops waiting at 40 minutes, and it posts its own comment when it is done. When the local model is busy, reviews run past the wait and the check goes red even though nothing failed. 33 of 46 doc-check runs today ended red this way, including on #32088, #31788, #31621 and #31620. ## Changes - `continue-on-error` on the agents-chat-action step. - New step that ends with a notice when the wait timed out and the chat is still `running` or `pending`, and fails the job for every other error. Generated by Coder Agents on behalf of @bpmct. |
||
|
|
6f22a88a51 |
ci: remove coder[bot] and Blink bots from CLA allowlist (#31496)
Removes `coder[bot]`, `blinkagent*`, and `blink-so*` from the CLA assistant allowlist in `.github/workflows/contrib.yaml`, so PRs authored by these bots are no longer exempt from the CLA check. Remaining bots in allowlist: * `dependabot*` for backport PRs * `coder-backporter-app[bot]` for backports |
||
|
|
73643176b6 |
ci(.github): add self-hosted test-go-pg variant (#31938)
Add a standalone `test-go-pg-self-hosted` workflow that runs the same Linux test suite as `test-go-pg` but on `coder-large` runners. It runs only on pushes to `main` and manual `workflow_dispatch` events, and only when the repository owner is `coder`. These runners are backed by Coder workspaces. For more details see [this Slack thread](https://codercom.slack.com/archives/C05AE94121Z/p1794226562056679). |
||
|
|
ad3818e850 |
docs: fix broken AWS HA and Red Hat OpenShift links (#31933)
Fixes the two broken links from the [Nov 9 weekly-docs run](https://github.com/coder/coder/actions/runs/42591777635). ## Changes - **`docs/admin/networking/high-availability.md`**: The AWS Prescriptive Guidance page on managed PostgreSQL for multi-tenant SaaS returns 404. The whole guide appears to be retired (welcome page, other sections, and PDF all 404). The link now points to [Configuring and managing a Multi-AZ deployment for Amazon RDS](https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.MultiAZ.html), the AWS counterpart to the existing GCP Cloud SQL HA link. - **`docs/install/server/openshift.md`**: Adds the equivalent [OKD build configuration page](https://docs.okd.io/latest/cicd/builds/understanding-buildconfigs.html) first, followed by the existing Red Hat OpenShift Container Platform link. Linkspector can still check the OKD link. - **`.github/.linkspector.yml`**: Ignores `docs.redhat.com`. Red Hat's edge returns 403 to automated requests, including GitHub runner IPs and headless Chrome, so the check fails intermittently. ## Why not retries? The pinned linkspector (v0.5.6) already defaults to `retryCount: 3`, but it only retries 429 responses and network errors. A 403 is returned immediately, and the Puppeteer fallback only retries on thrown exceptions. Adding 403 to `aliveStatusCodes` would apply to every domain, so it isn't used here. Co-authored-by: coder[bot] <137810501+coder[bot]@users.noreply.github.com> |
||
|
|
eb616306f0 | ci: run main-only secret consumers in the main environment (#31763) | ||
|
|
2e7ae8bea2 |
ci(.github/workflows): alert Slack when the dogfood image build fails on main (#31710)
The dogfood image workflow had no failure alert. Its main runs on 2026-11-02 and 2026-11-03 failed on network errors and nobody re-ran them, so workspaces kept pulling the 2026-10-27 image until a manual re-run on 2026-11-03. Add the notify-slack-on-failure job from ci.yaml and nightly-gauntlet.yaml, which posts to the CI failure channel and mentions the CI failure bot when build_image fails. It runs only on main, the only ref that pushes the image. |
||
|
|
3bcf67f3ba |
fix(.github/workflows): build dogfood images from the checkout (#31777)
Depot's cached clone of coder/coder still has the `test` branch, which was deleted on 2026-06-09. When a commit is missing from the clone, Depot fetches every branch, and git cannot create the `test/*` branches next to `origin/test`. 35 of the 42 retained main push builds (2026-08-19 to 2026-11-05) fell back to buildx without Depot's layer cache because of it. Passing the checked-out tree as the context removes the fetch. |
||
|
|
3f547f6a61 |
ci(.github/workflows): stop falling back to buildx in the dogfood build (#31851)
The fallback was added in #11538, when Depot builds failed because the Depot trial had ended and the job ran on GitHub's ubuntu-latest. The job has run on Depot's own runners since #16223, so the fallback only covers a Depot build failure while Depot's runners still work. In the retained logs it only ever hid one problem: 35 main builds fell back because of a stale branch in Depot's git clone, with a warning annotation as the only trace. Fallback builds have no layer cache, so they refetch every package and take minutes instead of seconds. A Depot failure now fails the build. The buildx setup step existed only for the fallback. |
||
|
|
8b5b5d19c0 |
ci: run the docs checker tests in lint-docs (#31768)
#31647 was a docs-only PR, but it broke `TestRepositoryManifest` on `main` (fixed in #31764). That test reads the committed `docs/manifest.json`, and the Go test jobs skip PRs that don't touch Go, so nothing ran it until it merged. On a docs-only PR the Go code can't change, so the only Go tests that can start failing are the ones that read the committed docs. Right now that's just `scripts/docsredirectscheck` and `scripts/docsgenfiltercheck`, and `./scripts/docs...` covers both. So, we'll just run `go test ./scripts/docs...` in `lint-docs`, which already runs whenever docs change and is part of `required`. The job now installs Go as well. I've skipped `go mod download`, as these tests only need 6 modules; from an empty module and build cache it took 6s locally. |
||
|
|
1986b94265 |
ci: allow docs changes under any PR title scope (#31773)
I ran into this on a `feat(site)` PR that also updated the docs: ``` Error: PR title scope "site" does not contain all changed files. Files outside scope: - docs/coder-agents/index.md ``` A frontend or CLI change that comes with a docs update shouldn't have to drop its scope, so the title check now just ignores files under `docs/` when the scope is outside `docs/`. The scope still has to match at least one changed file, and scopes under `docs/` (e.g. `docs(docs/admin)`) are as strict as before. I've updated the rule in `AGENTS.md` and the PR style guide to match. As the check runs on `pull_request_target`, this only takes effect once it's on `main`. |
||
|
|
2b7f03deea |
feat: replace Emoji Mart with Frimousse in the emoji picker (#30526)
> 🤖 This PR was modified by Coder Agents on behalf of Jake Howell. An alternative to #30361 for DEQ-67 ("Focus indicator is missing" on the template builder Customizations step). Instead of patching focus handling into Emoji Mart's shadow DOM, this replaces Emoji Mart (last released April 2024) with [Frimousse](https://frimousse.liveblocks.io), a headless picker that we style with Tailwind and our theme tokens. Fixes DEQ-67 Fixes DEQ-303 Fixes DEQ-201 Fixes DEQ-83 Also fixes 181 `aria-allowed-attr` tickets from Emoji Mart: 180 for `aria-posinset`/`aria-setsize` on its emoji buttons, and DEQ-370 for `aria-selected` on its category buttons. Frimousse renders a `grid` of `gridcell`s instead, and the category buttons use `aria-current`. - DEQ-303 (`scrollable-region-focusable`): the emoji grid is now a tab stop. - DEQ-201 (selected state of the category buttons): the current category has `aria-current`. - DEQ-83 (skin-tone button has no expanded state): the button now cycles tones in place and no longer opens a menu. <details> <summary>aria-allowed-attr tickets (181)</summary> Fixes DEQ-7 Fixes DEQ-8 Fixes DEQ-9 Fixes DEQ-11 Fixes DEQ-17 Fixes DEQ-18 Fixes DEQ-19 Fixes DEQ-26 Fixes DEQ-27 Fixes DEQ-30 Fixes DEQ-31 Fixes DEQ-33 Fixes DEQ-34 Fixes DEQ-41 Fixes DEQ-44 Fixes DEQ-47 Fixes DEQ-53 Fixes DEQ-57 Fixes DEQ-58 Fixes DEQ-65 Fixes DEQ-69 Fixes DEQ-71 Fixes DEQ-72 Fixes DEQ-73 Fixes DEQ-75 Fixes DEQ-77 Fixes DEQ-78 Fixes DEQ-80 Fixes DEQ-84 Fixes DEQ-85 Fixes DEQ-87 Fixes DEQ-89 Fixes DEQ-90 Fixes DEQ-96 Fixes DEQ-97 Fixes DEQ-98 Fixes DEQ-103 Fixes DEQ-109 Fixes DEQ-110 Fixes DEQ-113 Fixes DEQ-114 Fixes DEQ-116 Fixes DEQ-117 Fixes DEQ-119 Fixes DEQ-120 Fixes DEQ-123 Fixes DEQ-126 Fixes DEQ-129 Fixes DEQ-131 Fixes DEQ-135 Fixes DEQ-136 Fixes DEQ-153 Fixes DEQ-154 Fixes DEQ-157 Fixes DEQ-158 Fixes DEQ-160 Fixes DEQ-165 Fixes DEQ-170 Fixes DEQ-171 Fixes DEQ-173 Fixes DEQ-175 Fixes DEQ-179 Fixes DEQ-181 Fixes DEQ-185 Fixes DEQ-187 Fixes DEQ-188 Fixes DEQ-189 Fixes DEQ-192 Fixes DEQ-200 Fixes DEQ-202 Fixes DEQ-206 Fixes DEQ-212 Fixes DEQ-217 Fixes DEQ-220 Fixes DEQ-227 Fixes DEQ-229 Fixes DEQ-239 Fixes DEQ-240 Fixes DEQ-241 Fixes DEQ-245 Fixes DEQ-246 Fixes DEQ-247 Fixes DEQ-249 Fixes DEQ-251 Fixes DEQ-258 Fixes DEQ-262 Fixes DEQ-265 Fixes DEQ-270 Fixes DEQ-280 Fixes DEQ-282 Fixes DEQ-286 Fixes DEQ-296 Fixes DEQ-314 Fixes DEQ-315 Fixes DEQ-320 Fixes DEQ-322 Fixes DEQ-325 Fixes DEQ-326 Fixes DEQ-327 Fixes DEQ-334 Fixes DEQ-335 Fixes DEQ-343 Fixes DEQ-345 Fixes DEQ-347 Fixes DEQ-349 Fixes DEQ-353 Fixes DEQ-359 Fixes DEQ-360 Fixes DEQ-362 Fixes DEQ-367 Fixes DEQ-368 Fixes DEQ-369 Fixes DEQ-370 Fixes DEQ-372 Fixes DEQ-373 Fixes DEQ-375 Fixes DEQ-377 Fixes DEQ-380 Fixes DEQ-382 Fixes DEQ-389 Fixes DEQ-404 Fixes DEQ-405 Fixes DEQ-410 Fixes DEQ-413 Fixes DEQ-414 Fixes DEQ-415 Fixes DEQ-416 Fixes DEQ-421 Fixes DEQ-422 Fixes DEQ-423 Fixes DEQ-425 Fixes DEQ-429 Fixes DEQ-432 Fixes DEQ-435 Fixes DEQ-439 Fixes DEQ-442 Fixes DEQ-444 Fixes DEQ-448 Fixes DEQ-450 Fixes DEQ-451 Fixes DEQ-457 Fixes DEQ-460 Fixes DEQ-464 Fixes DEQ-465 Fixes DEQ-466 Fixes DEQ-468 Fixes DEQ-472 Fixes DEQ-475 Fixes DEQ-478 Fixes DEQ-485 Fixes DEQ-488 Fixes DEQ-490 Fixes DEQ-491 Fixes DEQ-501 Fixes DEQ-506 Fixes DEQ-507 Fixes DEQ-510 Fixes DEQ-513 Fixes DEQ-515 Fixes DEQ-518 Fixes DEQ-521 Fixes DEQ-523 Fixes DEQ-527 Fixes DEQ-528 Fixes DEQ-529 Fixes DEQ-530 Fixes DEQ-534 Fixes DEQ-538 Fixes DEQ-544 Fixes DEQ-547 Fixes DEQ-549 Fixes DEQ-551 Fixes DEQ-553 Fixes DEQ-561 Fixes DEQ-562 Fixes DEQ-571 Fixes DEQ-580 Fixes DEQ-582 Fixes DEQ-584 Fixes DEQ-593 Fixes DEQ-595 </details> - **Focus indicators:** every control in the picker shows a 2px `ring-content-link` focus ring: the category buttons, search field, clear and skin-tone buttons, and the emoji grid. In the grid, DOM focus stays in the search field or grid while the arrow keys move the active emoji, the same model as Emoji Mart. The active emoji gets the same ring, measured at `rgb(97,166,250)` on `rgb(9,9,11)` in dark mode and `rgb(36,99,235)` on white in light mode. Frimousse announces the active emoji through a live region. - **Keyboard:** Tab order is search, skin tone, grid, then the category buttons; the popover loops back to search. Arrow keys move the active emoji while focus is anywhere in the picker, and Enter selects. - **Same UX as before:** category buttons across the top, with Icons last. One search covers Unicode emoji and the `icons.json` icons. The skin-tone selector stays. - **Same stored values:** emoji still save as `/emojis/<file>.png` (the existing Apple PNGs) and icons as `/icon/<file>`. The file names in `static/emojis` follow emoji-datasource's rule: they keep U+FE0F only after characters that default to text style (`263a-fe0f`), while Emojibase adds it after every character. `emojiToValue` drops it after characters that are already emoji-style. Emoji newer than the shipped Apple set (15.1) are left out, as are 3 symbols the set has no image for. - **No CDN:** the picker bundles `emojibase-data` instead of Frimousse's default jsDelivr fetch, which matters for air-gapped deployments. - **Spritesheet:** the grid draws emoji from one sheet, `static/emojis/sheet-15.1.2.png` (4.5 MB, from emoji-datasource-apple 15.1.2, the same release as the PNGs), preloaded with the picker chunk as Emoji Mart did. Frimousse virtualizes the grid, so with one PNG per tile every category jump cost about 100 requests (2.7 s at 150 ms latency); with the sheet it costs none. The sheet has a versioned name because `/emojis` is served with immutable caching and its layout differs from the old `spritesheet.png`. `pnpm update-emojis` regenerates the sheet and its cell map (`emojiSheet.ts`) with `scripts/generate-emoji-sheet.mjs`. Custom icons still render as images. - **Removed:** `emoji-mart`, `@emoji-mart/*`, their type shim, and the old `static/emojis/spritesheet.png` (emoji-datasource 15.0.1 layout). - **Patched Frimousse:** 0.4.0 numbers `aria-rowindex` and `aria-colindex` from 0, which axe reports as `aria-valid-attr-value` (ARIA requires 1 or more). `site/patches/frimousse@0.4.0.patch` (a pnpm patch) makes both start at 1 in `dist/index.js` and `dist/index.cjs`, and shifts the `[aria-rowindex=...]` lookup that keyboard scroll-into-view uses by the same amount. Renumbering in our `Row` component alone would break that lookup. The bundles are minified to one line, so the patch file is large, but it changes three expressions per file: `"aria-rowindex":t?void 0:e` to `e+1`, `"aria-colindex":t` to `t+1`, and `[aria-rowindex="${R}"]` to `${R+1}`. The source-level fix and regression coverage are submitted upstream in [liveblocks/frimousse#39](https://github.com/liveblocks/frimousse/pull/39). Remove the patch only after upgrading to a Frimousse release containing the fix. - Note for reviewers: vendoring Frimousse's source into `site/src/vendor` (as with `message-scroller`) was considered and would have made the same fix as three readable lines, but was rejected because we would own about 3,900 copied lines and re-sync them by hand on every upgrade. Lazy chunks (gzip): `EmojiPicker` 16 KB (including the 13 KB sheet cell map) + `emoji-picker` 107 KB, versus about 134 KB for Emoji Mart and its data. Known differences and risks: - Frimousse matches the query anywhere in a name or tag, while Emoji Mart matches word prefixes. "apple" also returns "people wrestling" (tag "grapple"). This was accepted during review. - Frimousse's docs say custom data must be Unicode emoji. Icons are entries whose `emoji` is the icon path, rendered as images by our `Emoji` component. This works in 0.4.0 because Frimousse only filters out unsupported emoji in its built-in data loader. `frimousse` is pinned, and tests fail if icons stop appearing in search or stop returning `/icon/...` values. - Not tested with NVDA or another screen reader. - Not fixed here: DEQ-130 (category labels aren't headings) and DEQ-115 (dark icons lack contrast). - Shrinking the bundled emoji data is left for a follow-up. - The sheet is quantized to 256 colors (as was Emoji Mart's), so a few gradients differ slightly from the stored PNGs. Until it loads, emoji tiles are blank. <details> <summary>Verification</summary> - Upstream-tracking follow-up: `pnpm install --frozen-lockfile`, all 14 IconField and emoji-data tests, `pnpm check`, `pnpm lint`, `pnpm format:check`, and `make lint/emdash` pass. Only the patch preamble and generated lockfile hashes changed; the installed ESM and CommonJS bundles are byte-for-byte unchanged. - `pnpm check`, `lint:oxlint`, `lint:types`, `lint:knip`, `lint:circular-deps`, and `lint:compiler` pass, and `vite build` succeeds. - Vitest: `IconField.test.tsx` covers picking an icon, picking an emoji that keeps U+FE0F in its file name, picking with the keyboard, clearing the search, and marking a category as current. `emojiData.test.ts` checks that every emoji and skin tone maps to a PNG in `static/emojis`, the FE0F rule, and that deprecated icons are left out. Removing an entry from the list of unshipped symbols makes the first test fail, naming the emoji. - Playwright against Storybook, in dark and light themes: opened the picker with the keyboard and tabbed through every control, checking the focus ring on each. Typed "apple" and pressed ArrowDown and ArrowRight; the active emoji showed the ring. Scrolling the whole list in all six skin tones produced no failed image requests, and the picker made no requests outside localhost. - Storybook Vitest project (`--project=storybook`) for `IconField.stories.tsx` passes. - axe-core 4.11 against `OpenPicker` and `KeyboardActiveEmoji`, in dark and light themes and at 1280px and 320px widths: the picker has no violations. The remaining results are outside it: `aria-dialog-name` on the shared `PopoverContent`, plus the page-level `region` and `bypass`. With the patch, 150 ArrowDown and 150 ArrowUp presses through the full list, and 40 of each in the "face" results, kept the active emoji fully in view on every step. The grid viewport is now `role="group"`, because axe flagged `aria-label` on a div with no role. - Spritesheet: `emojiData.test.ts` checks that every emoji and skin tone has a sheet cell and spot-checks coordinates. A Playwright script compared all 3,775 sheet cells with their PNGs, and swapped 72 rendered tiles in place for their PNGs; every tile matched its own cell better than any neighbor. With 150 ms emulated latency, switching between Flags, Smileys, and Objects made no emoji requests (before: about 100 per category). </details> <details> <summary>Implementation plan and decision log</summary> **Why Frimousse.** It's a headless set of React parts styled with Tailwind, with a virtualized grid, keyboard navigation, and a live-region announcer. Prototypes compared it with emoji-picker-react 4.22.3, which also met the requirements but can only be restyled through its own CSS variables. @ferrucc-io/emoji-picker was ruled out over doubts about long-term maintenance. | Requirement | Frimousse | emoji-picker-react | | --- | --- | --- | | Category buttons, Icons last | Custom nav (~40 lines) | Built in | | One search over emoji + icons | Yes | Yes | | Icons in the same scroll list | Yes | Yes | | Keyboard navigation across both | Yes | Yes; one Enter picked a gender variant, unexplained | | Stored values unchanged | Yes | Yes | | No third-party requests | Yes (bundled data) | Yes | | Tailwind styling | Native | CSS variables only | **Plan as built:** 1. Dependencies: add pinned `frimousse` 0.4.0 and `emojibase-data` 17.0.0, plus `emojibase` 17.0.0 as a dev dependency for its types; remove Emoji Mart and its type shim; rename the Vite chunk group. 2. Data (`emojiData.ts`): build Frimousse `EmojiData` from `emojibase-data/en/data.json` and `messages.json`. Drop the "component" group, emoji newer than 15.1, and the 3 symbols the Apple set lacks. Map each emoji to its PNG by emoji-datasource's U+FE0F naming rule, and offer skin tones only when all five single-tone variants are shipped. Append the non-deprecated `icons.json` entries as a final "Icons" category, with the same keywords as Emoji Mart. 3. Picker (`EmojiPicker.tsx`): category `nav` buttons with `aria-current`. Clicking one clears the search and scrolls to the category; scrolling updates the current button. The search uses the shared `InputGroup` with our own clear button, and the native one is hidden. The grid renders images through `ExternalImage`, without lazy loading, and the icons are preloaded when the chunk loads, because a cold cache showed empty tiles for about 0.5 s. The skin-tone button cycles tones with `useSkinTone`. The grid is a tab stop. 4. `IconField.tsx`: `onEmojiSelect` now passes the stored value directly. The hidden pre-warm picker is unchanged. 5. Tests and stories as listed under Verification. 6. Spritesheet (added after hands-on testing showed tiles popping in): draw emoji from emoji-datasource-apple 15.1.2's `sheets-256/64.png` with a generated cell map, sized with percentages so one cell fills the tile. Native emoji glyphs were ruled out because they would not match the stored Apple PNGs; preloading individual PNGs would still miss on category jumps. **Changes from the original plan:** replaced the planned generated list of shipped files (3,787 lines of JSON) with emoji-datasource's U+FE0F naming rule, which a test checks against `static/emojis`. Used `nav` buttons with `aria-current` instead of `role="tab"`, since there are no tab panels. Added a tab stop on the grid. Accepted substring search. </details> > This PR was generated by Coder Agents. --------- Co-authored-by: Jake Howell <jake@hwll.me> |
||
|
|
fb36a3d877 |
chore: bump mise to 2026.10.25 (#31640)
Bump mise from 2026.5.12 in every place scripts/check_mise_versions.sh checks. mise.lock is regenerated because 2026.10.19 records vercel's registry default options, and `mise install --locked` fails on the old lockfile without them. 2026.7.12 removed `mise oci push --tool`, so the dogfood workflow drops `--tool crane` and the mise-oci-wrapper no longer installs crane. min_version is a hard requirement: in this repo, an older mise fails for `mise exec`, every shim and `mise activate` until `mise self-update` or a restart on the new dogfood image, so the git hooks block commits. Branches not rebased onto this change get mise.lock rewritten whenever mise 2026.10.25 installs something there. |
||
|
|
2cab0e8c37 |
ci: remove PR deployments (#31757)
PR deployments have been dead since February, but `pr-cleanup.yaml` still runs on every closed PR with the deployment secrets in scope. |
||
|
|
b0cc77d7b5 | chore: use environments for various CI pipelines (#31654) | ||
|
|
44285af741 |
ci(.github/workflows): add doc-check kill switch and auth-failure stop (#31242)
## Summary Adds a repository-variable kill switch for doc-check, and a prompt rule so the agent stops when GitHub authentication fails. This is the coder/coder part of the response to the Oct 23 doc-check token leak (same root cause as SEC-1205 and DOCS-1352). ## Changes - The `doc-check` job now runs only when the repository variable `DOC_CHECK_ENABLED` is `'true'`. The gate fails closed, matching `AUDIT_DOCS_PATHS_ENABLED` in `audit-docs-paths.yaml`. The `delete-workspace` cleanup job is not gated. - New "When GitHub authentication fails" section in the chat prompt. It tells the agent to stop, report the error, and post nothing; not to read, decode, or print credentials; not to mint tokens; and not to search the environment or files for a replacement credential. > [!IMPORTANT] > After merge, doc-check stays off until someone with repo admin sets `DOC_CHECK_ENABLED=true`. > The workflow is also currently disabled in the Actions UI (`gh workflow disable`), so re-enabling needs both. > Don't re-enable until coder/dogfood#738 is deployed. The prompt rule is defense in depth only. The primary fix is coder/dogfood#738, which removes the GitHub App private key from the agent environment. ## Testing - Rendered the `Build chat prompt` step locally with bash and confirmed the new section appears with literal backticks. - `actionlint`, `zizmor --offline`, and `pre-commit-light` pass. <details> <summary>Incident handoff steps and status</summary> 1. Stop new exposure: `doc-check.yaml` disabled in the Actions UI. Runs that were in progress and the #31226 chat and workspace are handled separately. 2. Land coder/dogfood#738 and confirm a new active `coder-workflow-bot` template version. Pending review. 3. Handle token expiry for runs longer than one hour. Not decided. 4. Prompt rule and kill switch in coder/coder. **This PR.** 5. Review the `coder-doc-check[bot]` audit log for Oct 23, 23:18 to 00:19 UTC. Optionally rotate the key. 6. Record the incident on SEC-1205 and link it to DOCS-1352. </details> > Generated by Coder Agents on behalf of @nickvigilante. |
||
|
|
dbd7db6877 | feat: add Harbor-based A/B eval for Coder Agents against main (#30686) | ||
|
|
542e5b6952 | ci(.github/workflows): run setup-go-paths in nightly-gauntlet (#31382) | ||
|
|
9666549f3c |
feat: run one doc-check verifier per group of findings (#31243)
## Summary doc-check now runs one Skeptic (verifier) per group of findings, in parallel, instead of one Skeptic over every finding. On #31226 the single Skeptic ran for more than 90 minutes, checking each finding one after another. ## Changes - `SKILL.md` step 6: the orchestrator runs the two lookup checks itself (the quote exists, not already reported), then groups the remaining findings by sentence or by missing page and runs one verifier per group. With a model configuration ID, each group is its own sub-agent; the orchestrator spawns them all, then waits once. - `personas/verifier.md`: scoped to one group, loads only the files its findings cite, and returns only verdicts so the orchestrator's context stays small. - `output.md` and `doc-check.yaml`: wording follows the change. <details> <summary>Decision log</summary> - **Group by sentence, not one agent per check.** The seven checks run in order and stop at the first failure, so one agent per check would re-read the same sources seven times and lose the early stop. Grouping by sentence keeps every possible duplicate or contradiction inside one group, so groups never need each other. - **Lookups move to the orchestrator.** "The quote exists" and "not already reported" are string comparisons, so they don't need a model turn. The missing-page form of check 1 ("no other page covers the fact") stays with the verifier because it needs judgment. - **No concurrency cap yet.** A load ramp on the shared Solstice server is in progress (median turn: 79s with 1 agent, 185s with 3, 235s with 16). A cap belongs in a follow-up once the ramp shows where throughput stops growing. - **Context size matters as much as agent count.** One review agent at about 107k input tokens took more than 10 minutes per turn while running alone, which is why each verifier loads only its group's files. </details> ## Testing - `make lint/emdash`, `lint/markdown`, and the pre-commit hooks pass. - Not yet exercised on a live run; the next doc-check run on a PR with several findings is the test. --- *Generated by Coder Agents on behalf of @nickvigilante.* |
||
|
|
a010e29d4e |
ci: bump the github-actions group with 5 updates (#31341)
Bumps the github-actions group with 5 updates: | Package | From | To | | --- | --- | --- | | [step-security/harden-runner](https://github.com/step-security/harden-runner) | `2.22.1` | `2.22.2` | | [actions/setup-java](https://github.com/actions/setup-java) | `6.0.1` | `6.1.0` | | [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) | `4.38.3` | `4.39.0` | | [github/codeql-action/init](https://github.com/github/codeql-action) | `4.38.3` | `4.39.0` | | [github/codeql-action/analyze](https://github.com/github/codeql-action) | `4.38.3` | `4.39.0` | Updates `step-security/harden-runner` from 2.22.1 to 2.22.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/step-security/harden-runner/releases">step-security/harden-runner's releases</a>.</em></p> <blockquote> <h2>v2.22.2</h2> <h2>What's Changed</h2> <ul> <li>Fixed inbound (ingress) network traffic being incorrectly classified as outbound (egress) traffic on macOS</li> <li>Fixed implicit endpoints intended for self-hosted runners being applied to custom VM environments on Linux (enterprise tier)</li> <li>Improved network and DNS tracing, enforcement logic, and process information correlation on Linux (enterprise tier)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/step-security/harden-runner/compare/v2.22.1...v2.22.2">https://github.com/step-security/harden-runner/compare/v2.22.1...v2.22.2</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/step-security/harden-runner/commit/dc2769abcc0fcfbadfc1df54081c1608579ef6b2"><code>dc2769a</code></a> Merge pull request <a href="https://redirect.github.com/step-security/harden-runner/issues/707">#707</a> from step-security/rc-45</li> <li><a href="https://github.com/step-security/harden-runner/commit/ab0b27386ab734bab7c3b9293e0c8b1b29ce5c26"><code>ab0b273</code></a> Merge pull request <a href="https://redirect.github.com/step-security/harden-runner/issues/706">#706</a> from h0x0er/rc-45</li> <li><a href="https://github.com/step-security/harden-runner/commit/03ccff8a8b3b1ac0ba57353a585903c8f73647f4"><code>03ccff8</code></a> Remove agent-preinstalled skip for third-party runners</li> <li><a href="https://github.com/step-security/harden-runner/commit/815e48d1a3d3878ac5dbf4d5a3ba0f76666a846f"><code>815e48d</code></a> Skip agent install and post-step cleanup when agent is already installed</li> <li>See full diff in <a href="https://github.com/step-security/harden-runner/compare/ccd8616d44fd3846e67624a50d5aad6d37bf2d25...dc2769abcc0fcfbadfc1df54081c1608579ef6b2">compare view</a></li> </ul> </details> <br /> Updates `actions/setup-java` from 6.0.1 to 6.1.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-java/releases">actions/setup-java's releases</a>.</em></p> <blockquote> <h2>v6.1.0</h2> <h2>What's Changed</h2> <ul> <li>Preserve compound Liberica build versions from .sdkmanrc by <a href="https://github.com/brunoborges"><code>@brunoborges</code></a> with <a href="https://github.com/Copilot"><code>@Copilot</code></a> in <a href="https://redirect.github.com/actions/setup-java/pull/1268">actions/setup-java#1268</a></li> <li>Support Temurin on Linux RISC-V by <a href="https://github.com/yawkat"><code>@yawkat</code></a> in <a href="https://redirect.github.com/actions/setup-java/pull/1269">actions/setup-java#1269</a></li> <li>Stop GPG agent before removing signature-verification home by <a href="https://github.com/brunoborges"><code>@brunoborges</code></a> with <a href="https://github.com/Copilot"><code>@Copilot</code></a> in <a href="https://redirect.github.com/actions/setup-java/pull/1273">actions/setup-java#1273</a></li> <li>Prefer Zulu 4-segment hotfix builds when resolving version ranges by <a href="https://github.com/brunoborges"><code>@brunoborges</code></a> in <a href="https://redirect.github.com/actions/setup-java/pull/1278">actions/setup-java#1278</a></li> <li>Support Temurin JEP 322 patch versions like 26.0.2.1+1 by <a href="https://github.com/brunoborges"><code>@brunoborges</code></a> in <a href="https://redirect.github.com/actions/setup-java/pull/1279">actions/setup-java#1279</a></li> <li>chore(deps): bump undici from 6.28.0 to 6.29.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a>[bot] in <a href="https://redirect.github.com/actions/setup-java/pull/1274">actions/setup-java#1274</a></li> <li>chore(deps): bump the monthly-npm-updates group with 13 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a>[bot] in <a href="https://redirect.github.com/actions/setup-java/pull/1276">actions/setup-java#1276</a></li> <li>feat: support Maven server credential origins by <a href="https://github.com/YunaBraska"><code>@YunaBraska</code></a> in <a href="https://redirect.github.com/actions/setup-java/pull/1282">actions/setup-java#1282</a></li> <li>Support Maven plugin repositories in generated settings.xml by <a href="https://github.com/brunoborges"><code>@brunoborges</code></a> in <a href="https://redirect.github.com/actions/setup-java/pull/1286">actions/setup-java#1286</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/yawkat"><code>@yawkat</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-java/pull/1269">actions/setup-java#1269</a></li> <li><a href="https://github.com/YunaBraska"><code>@YunaBraska</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-java/pull/1282">actions/setup-java#1282</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-java/compare/v6.0.1...v6.1.0">https://github.com/actions/setup-java/compare/v6.0.1...v6.1.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-java/commit/b843ebf9b913146b38da2eaa7aeddf76074ae1ad"><code>b843ebf</code></a> Support Maven plugin repositories in generated settings.xml (<a href="https://redirect.github.com/actions/setup-java/issues/1286">#1286</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/2a69be27b0baa8a7ec1c0ba665dc022b180664c5"><code>2a69be2</code></a> feat: support Maven server credential origins (<a href="https://redirect.github.com/actions/setup-java/issues/1282">#1282</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/d0e6e4dbf773b98efde945f446d2099b2c0d8fd2"><code>d0e6e4d</code></a> chore(deps): bump the monthly-npm-updates group with 13 updates (<a href="https://redirect.github.com/actions/setup-java/issues/1276">#1276</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/b24925bc49b74c38e5a106894c14cfd876ac1ab5"><code>b24925b</code></a> chore(deps): bump undici from 6.28.0 to 6.29.0 (<a href="https://redirect.github.com/actions/setup-java/issues/1274">#1274</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/47b36480ae3ac5671badb6bde2dec0c1898a1cc9"><code>47b3648</code></a> Support Temurin JEP 322 patch versions like 26.0.2.1+1 (<a href="https://redirect.github.com/actions/setup-java/issues/1270">#1270</a>) (<a href="https://redirect.github.com/actions/setup-java/issues/1279">#1279</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/74920aab4a9e7a33c5bd4fd3c8d5a7ba260ae795"><code>74920aa</code></a> Prefer Zulu 4-segment hotfix builds when resolving version ranges (<a href="https://redirect.github.com/actions/setup-java/issues/1278">#1278</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/a78ec39f1243adc9be41d35a49593a4c665a604c"><code>a78ec39</code></a> Stop GPG agent before removing signature-verification home (<a href="https://redirect.github.com/actions/setup-java/issues/1273">#1273</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/97c5a5e13aa773f277f72c1287dda3c789f1366c"><code>97c5a5e</code></a> Support Temurin on Linux RISC-V (<a href="https://redirect.github.com/actions/setup-java/issues/1269">#1269</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/1aa87b638dacaa70f1c903fa9ec9cbd91058e2ff"><code>1aa87b6</code></a> Preserve compound Liberica build versions from .sdkmanrc (<a href="https://redirect.github.com/actions/setup-java/issues/1268">#1268</a>)</li> <li>See full diff in <a href="https://github.com/actions/setup-java/compare/de7274f081f381c8f8158605e0321c36c376e2e6...b843ebf9b913146b38da2eaa7aeddf76074ae1ad">compare view</a></li> </ul> </details> <br /> Updates `github/codeql-action/upload-sarif` from 4.38.3 to 4.39.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action/upload-sarif's releases</a>.</em></p> <blockquote> <h2>v4.39.0</h2> <ul> <li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li> <li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li> <li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li> <li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action/upload-sarif's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>4.39.1 - 21 Oct 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.3">2.27.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4256">#4256</a></li> </ul> <h2>4.39.0 - 15 Oct 2026</h2> <ul> <li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li> <li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li> <li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li> <li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li> </ul> <h2>4.38.3 - 08 Oct 2026</h2> <ul> <li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li> <li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li> </ul> <h2>4.38.2 - 24 Sept 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.1">2.27.1</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4160">#4160</a></li> </ul> <h2>4.38.1 - 18 Sept 2026</h2> <ul> <li>The CodeQL Action now has experimental support for CodeQL releases for which per-language bundles are available. Per-language bundles support analysis for a single language and are therefore smaller than the combined bundles that allow analysis for all supported languages. As a result, per-language bundles take up less space on disk and are faster to download. We expect to roll this change out to everyone in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4146">#4146</a></li> </ul> <h2>4.38.0 - 09 Sept 2026</h2> <ul> <li>On GitHub-hosted runners, the CodeQL Action now deletes unused CodeQL bundles from the toolcache before downloading a different bundle, which frees up disk space for the analysis. We expect to roll this change out to everyone in September. <a href="https://redirect.github.com/github/codeql-action/pull/4124">#4124</a></li> <li>The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and downloads the native <code>linux-arm64</code> CodeQL bundle when available. <a href="https://redirect.github.com/github/codeql-action/pull/4072">#4072</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.0">2.27.0</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4129">#4129</a></li> </ul> <h2>4.37.9 - 26 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li> </ul> <h2>4.37.8 - 21 Aug 2026</h2> <p>No user facing changes.</p> <h2>4.37.7 - 13 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.3">2.26.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4085">#4085</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/6f2ac81f5cd81fe351a197ba0b00d91d03cd2aee"><code>6f2ac81</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4239">#4239</a> from github/update-v4.39.0-d63383a73</li> <li><a href="https://github.com/github/codeql-action/commit/eb1c428e6e3725d2b527aec0ee5db4303c8f669d"><code>eb1c428</code></a> Trigger workflows</li> <li><a href="https://github.com/github/codeql-action/commit/444333376e064d207fe1dc74e881528bf11649c1"><code>4443333</code></a> Update changelog for v4.39.0</li> <li><a href="https://github.com/github/codeql-action/commit/d63383a7318b5332e86725adf62ac19528a9786a"><code>d63383a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4233">#4233</a> from github/mbg/start-proxy/report-version</li> <li><a href="https://github.com/github/codeql-action/commit/8dec0b9f88b61a76f5fc97056ee8e7dc8a1a8022"><code>8dec0b9</code></a> Rename <code>path</code> to <code>result</code> in tests</li> <li><a href="https://github.com/github/codeql-action/commit/4eabea6b5e5123ae16fffacf06e86d9d3864c350"><code>4eabea6</code></a> Merge remote-tracking branch 'origin/main' into mbg/start-proxy/report-version</li> <li><a href="https://github.com/github/codeql-action/commit/57938b85687300731b9b53559017c143d849481d"><code>57938b8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4201">#4201</a> from github/mario-campos/automate-changenotes-assemble</li> <li><a href="https://github.com/github/codeql-action/commit/ee07b503f465bcf3338b6e4807a36789e3106f4b"><code>ee07b50</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4236">#4236</a> from github/mbg/add-missing-changenotes</li> <li><a href="https://github.com/github/codeql-action/commit/a897ed5c2eeeb4862bf224c65f62a8b2478eb581"><code>a897ed5</code></a> Add change note for <a href="https://redirect.github.com/github/codeql-action/issues/4206">#4206</a></li> <li><a href="https://github.com/github/codeql-action/commit/c8bd0195fb2ec9584b1bd6faf9ff5e2983c63d82"><code>c8bd019</code></a> Add change note for <a href="https://redirect.github.com/github/codeql-action/issues/4198">#4198</a></li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/24c54180a607b1449ed407dd24f251e4e9147c8d...6f2ac81f5cd81fe351a197ba0b00d91d03cd2aee">compare view</a></li> </ul> </details> <br /> Updates `github/codeql-action/init` from 4.38.3 to 4.39.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action/init's releases</a>.</em></p> <blockquote> <h2>v4.39.0</h2> <ul> <li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li> <li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li> <li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li> <li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action/init's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>4.39.1 - 21 Oct 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.3">2.27.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4256">#4256</a></li> </ul> <h2>4.39.0 - 15 Oct 2026</h2> <ul> <li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li> <li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li> <li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li> <li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li> </ul> <h2>4.38.3 - 08 Oct 2026</h2> <ul> <li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li> <li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li> </ul> <h2>4.38.2 - 24 Sept 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.1">2.27.1</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4160">#4160</a></li> </ul> <h2>4.38.1 - 18 Sept 2026</h2> <ul> <li>The CodeQL Action now has experimental support for CodeQL releases for which per-language bundles are available. Per-language bundles support analysis for a single language and are therefore smaller than the combined bundles that allow analysis for all supported languages. As a result, per-language bundles take up less space on disk and are faster to download. We expect to roll this change out to everyone in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4146">#4146</a></li> </ul> <h2>4.38.0 - 09 Sept 2026</h2> <ul> <li>On GitHub-hosted runners, the CodeQL Action now deletes unused CodeQL bundles from the toolcache before downloading a different bundle, which frees up disk space for the analysis. We expect to roll this change out to everyone in September. <a href="https://redirect.github.com/github/codeql-action/pull/4124">#4124</a></li> <li>The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and downloads the native <code>linux-arm64</code> CodeQL bundle when available. <a href="https://redirect.github.com/github/codeql-action/pull/4072">#4072</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.0">2.27.0</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4129">#4129</a></li> </ul> <h2>4.37.9 - 26 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li> </ul> <h2>4.37.8 - 21 Aug 2026</h2> <p>No user facing changes.</p> <h2>4.37.7 - 13 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.3">2.26.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4085">#4085</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/6f2ac81f5cd81fe351a197ba0b00d91d03cd2aee"><code>6f2ac81</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4239">#4239</a> from github/update-v4.39.0-d63383a73</li> <li><a href="https://github.com/github/codeql-action/commit/eb1c428e6e3725d2b527aec0ee5db4303c8f669d"><code>eb1c428</code></a> Trigger workflows</li> <li><a href="https://github.com/github/codeql-action/commit/444333376e064d207fe1dc74e881528bf11649c1"><code>4443333</code></a> Update changelog for v4.39.0</li> <li><a href="https://github.com/github/codeql-action/commit/d63383a7318b5332e86725adf62ac19528a9786a"><code>d63383a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4233">#4233</a> from github/mbg/start-proxy/report-version</li> <li><a href="https://github.com/github/codeql-action/commit/8dec0b9f88b61a76f5fc97056ee8e7dc8a1a8022"><code>8dec0b9</code></a> Rename <code>path</code> to <code>result</code> in tests</li> <li><a href="https://github.com/github/codeql-action/commit/4eabea6b5e5123ae16fffacf06e86d9d3864c350"><code>4eabea6</code></a> Merge remote-tracking branch 'origin/main' into mbg/start-proxy/report-version</li> <li><a href="https://github.com/github/codeql-action/commit/57938b85687300731b9b53559017c143d849481d"><code>57938b8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4201">#4201</a> from github/mario-campos/automate-changenotes-assemble</li> <li><a href="https://github.com/github/codeql-action/commit/ee07b503f465bcf3338b6e4807a36789e3106f4b"><code>ee07b50</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4236">#4236</a> from github/mbg/add-missing-changenotes</li> <li><a href="https://github.com/github/codeql-action/commit/a897ed5c2eeeb4862bf224c65f62a8b2478eb581"><code>a897ed5</code></a> Add change note for <a href="https://redirect.github.com/github/codeql-action/issues/4206">#4206</a></li> <li><a href="https://github.com/github/codeql-action/commit/c8bd0195fb2ec9584b1bd6faf9ff5e2983c63d82"><code>c8bd019</code></a> Add change note for <a href="https://redirect.github.com/github/codeql-action/issues/4198">#4198</a></li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/24c54180a607b1449ed407dd24f251e4e9147c8d...6f2ac81f5cd81fe351a197ba0b00d91d03cd2aee">compare view</a></li> </ul> </details> <br /> Updates `github/codeql-action/analyze` from 4.38.3 to 4.39.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action/analyze's releases</a>.</em></p> <blockquote> <h2>v4.39.0</h2> <ul> <li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li> <li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li> <li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li> <li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action/analyze's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>4.39.1 - 21 Oct 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.3">2.27.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4256">#4256</a></li> </ul> <h2>4.39.0 - 15 Oct 2026</h2> <ul> <li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li> <li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li> <li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li> <li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li> </ul> <h2>4.38.3 - 08 Oct 2026</h2> <ul> <li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li> <li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li> </ul> <h2>4.38.2 - 24 Sept 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.1">2.27.1</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4160">#4160</a></li> </ul> <h2>4.38.1 - 18 Sept 2026</h2> <ul> <li>The CodeQL Action now has experimental support for CodeQL releases for which per-language bundles are available. Per-language bundles support analysis for a single language and are therefore smaller than the combined bundles that allow analysis for all supported languages. As a result, per-language bundles take up less space on disk and are faster to download. We expect to roll this change out to everyone in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4146">#4146</a></li> </ul> <h2>4.38.0 - 09 Sept 2026</h2> <ul> <li>On GitHub-hosted runners, the CodeQL Action now deletes unused CodeQL bundles from the toolcache before downloading a different bundle, which frees up disk space for the analysis. We expect to roll this change out to everyone in September. <a href="https://redirect.github.com/github/codeql-action/pull/4124">#4124</a></li> <li>The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and downloads the native <code>linux-arm64</code> CodeQL bundle when available. <a href="https://redirect.github.com/github/codeql-action/pull/4072">#4072</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.0">2.27.0</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4129">#4129</a></li> </ul> <h2>4.37.9 - 26 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li> </ul> <h2>4.37.8 - 21 Aug 2026</h2> <p>No user facing changes.</p> <h2>4.37.7 - 13 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.3">2.26.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4085">#4085</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/6f2ac81f5cd81fe351a197ba0b00d91d03cd2aee"><code>6f2ac81</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4239">#4239</a> from github/update-v4.39.0-d63383a73</li> <li><a href="https://github.com/github/codeql-action/commit/eb1c428e6e3725d2b527aec0ee5db4303c8f669d"><code>eb1c428</code></a> Trigger workflows</li> <li><a href="https://github.com/github/codeql-action/commit/444333376e064d207fe1dc74e881528bf11649c1"><code>4443333</code></a> Update changelog for v4.39.0</li> <li><a href="https://github.com/github/codeql-action/commit/d63383a7318b5332e86725adf62ac19528a9786a"><code>d63383a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4233">#4233</a> from github/mbg/start-proxy/report-version</li> <li><a href="https://github.com/github/codeql-action/commit/8dec0b9f88b61a76f5fc97056ee8e7dc8a1a8022"><code>8dec0b9</code></a> Rename <code>path</code> to <code>result</code> in tests</li> <li><a href="https://github.com/github/codeql-action/commit/4eabea6b5e5123ae16fffacf06e86d9d3864c350"><code>4eabea6</code></a> Merge remote-tracking branch 'origin/main' into mbg/start-proxy/report-version</li> <li><a href="https://github.com/github/codeql-action/commit/57938b85687300731b9b53559017c143d849481d"><code>57938b8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4201">#4201</a> from github/mario-campos/automate-changenotes-assemble</li> <li><a href="https://github.com/github/codeql-action/commit/ee07b503f465bcf3338b6e4807a36789e3106f4b"><code>ee07b50</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4236">#4236</a> from github/mbg/add-missing-changenotes</li> <li><a href="https://github.com/github/codeql-action/commit/a897ed5c2eeeb4862bf224c65f62a8b2478eb581"><code>a897ed5</code></a> Add change note for <a href="https://redirect.github.com/github/codeql-action/issues/4206">#4206</a></li> <li><a href="https://github.com/github/codeql-action/commit/c8bd0195fb2ec9584b1bd6faf9ff5e2983c63d82"><code>c8bd019</code></a> Add change note for <a href="https://redirect.github.com/github/codeql-action/issues/4198">#4198</a></li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/24c54180a607b1449ed407dd24f251e4e9147c8d...6f2ac81f5cd81fe351a197ba0b00d91d03cd2aee">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> |
||
|
|
578b5270a6 | chore: skip Storybook on PRs without site changes (#31298) | ||
|
|
b2e6f89766 |
chore: use go test cache for test-go-pg-17 and test-go-race-pg (#31295)
These jobs skipped the mtimehash step that test-go-pg uses, so packages that open files (cli, enterprise/coderd, enterprise/cli, ...) missed the Go test cache on every PR run. |
||
|
|
c242029192 |
feat: make doc-check review docs quality, not only missing docs (#31193)
## Summary Rebuilds the doc-check skill around one question: if this PR merged now, would the docs on `main` explain the change correctly and clearly? On #31159 the current skill stayed silent on real defects, because "a PR that documents itself needs nothing more" ended the review before anything checked the docs the PR added. ## Changes - **doc-check skill:** a change model built from the code, eight focused personas with a verifier, findings that must cite evidence or get dropped, explicit blocking classes, a changed-lines rule for style, design-friction notes, and a run trace on every run (`output.md`, `personas/`). - **Rules stay in `docs/.style/`:** each rule page lists its personas in `review-personas` front matter, so the skill finds rules without depending on file paths. - **Style guide:** new rules for leading with the reader's surface and for time-relative words, a clearer Latin abbreviations rule with Do and Don't examples, and `as` in the one-meaning table. Coverage counts go from 88 to 90. - **Conflicting guidance fixed:** `.claude/docs/DOCS_STYLE_GUIDE.md` and the old skill no longer recommend semicolons or "see". - **write-docs and AGENTS.md:** authors run doc-check on their branch before opening or updating a PR. - **Workflow prompt:** asks for the full review, reads the skill from the base branch, and runs persona sub-agents only on the configured model. Out of scope, tracked separately: commit statuses (DOCS-1407), the replay harness (DOCS-923), `draft: true` (DOCS-1412), stable rule IDs (DOCS-1413), and "native" wording (DOCS-1409). ## Testing - `make lint/markdown`, `lint/emdash`, `lint/style-claims`, `lint/docs-html`, `lint/docs-manifest`, `lint/actions` (actionlint and zizmor), and Vale on the changed `docs/.style` files all pass. - Read-only evaluation runs of the new skill, with nothing posted: | Known issue on #31159 | Solstice-1 Local, v1 | Sonnet 5.5, v1 | Solstice-1 Local, v2 | |---|---|---|---| | Personal and organization downloads lose the manual-only line | Filed as pre-existing | Blocking | Blocking | | New section contradicts the Project skills section | Missed | Missed | Blocking | | Section leads with the API field, not the UI switch | Blocking | Blocking | Blocking | | Quoted `"true"` is silently ignored | Filed as pre-existing | Suggestion | Missed | | Quoted key is stored unchanged, so the file can disagree | Blocking | Blocking | Missed | | Claim about other tools can't be checked | Suggestion | Suggestion | Suggestion | | PR description claim the code doesn't support | Trace | Trace | Trace | | False positives | 0 | 0 | 0 | On #31164, a docs-metadata PR with nothing wrong, v2 reported a clean result with no findings. v2 fixes the v1 misses: the Continuity Editor reads the whole page first, and gaps on paths the change didn't edit count as caused by the change. The coverage persona's example comes from #31159, so the v2 rerun on that PR overstates the gain. The replay set in DOCS-923 is the real test. ## Risks - Eight personas on Solstice may exceed the workflow's 40-minute wait. Watch the first runs after merge. - Reviews now post inline comments as well as the summary comment, on every PR that reaches the review. <details> <summary>Plan and decision log</summary> # doc-check redesign: decisions so far Status: design interview in progress. Nothing implemented. Tracking: DOCS-918 (parent), DOCS-1407 (commit status), DOCS-925 (outcomes), DOCS-923 (replay), DOCS-926 (harvester), DOCS-1378 (blocking slop), DOCS-597 (renderer class drift). ## First principle If this PR merged now, would the docs on main correctly and clearly explain this exact change? The requirement runs both ways: every docs claim is grounded in the code, and every behavior that materially changes how a customer uses the product has docs. "The PR documents itself" is never a reason to stop reviewing. ## Scope and audience - One skill answers both "are docs needed" and "are the added docs good". - Every PR gets the same depth, including docs-only PRs. - Findings are written for the PR author, and phrased so an authoring agent can apply them. ## Priority and blocking Order: accuracy, journey completeness, consistency, audience fit, structure, concision, word choice and mechanics. Blocking findings: - Claims the code contradicts. - Required docs that are missing for behavior the PR adds or changes. - Rendering breaks and typos (deterministic checks first, LLM as backup). - Consistency and audience findings only when all three hold: the finding cites a rule ID or a contradicting line, the verifier confirmed it, and the PR added or edited the text. Never blocking: - Pure judgment calls without a citable rule. To make something blockable, add a rule. - Style issues on lines the PR did not touch. - Design-friction notes (uncapped, own category, each tied to a docs sentence, re-evaluated every round). - Gaps that predate the PR: filed to Linear through the DOCS-926 harvester. - Tutorial or lab needs: filed to TRAIN or DOCS through the harvester. ## Evidence and hallucination handling - Every finding cites evidence: code location, other page and line, or style rule ID. No evidence, no finding. - Verifier persona re-checks every finding on every run. - The summary lists checks the reviewer could not complete. - `/doc-check wrong <finding-id> <reason>` logs a false finding to Linear and adds the PR to the replay set. ## Output - One PR review per round with as many inline comments as needed, suggestion blocks for local fixes. - Re-reviews comment only on changed lines and resolve fixed threads. A clean round posts nothing new. - Hidden machine-readable findings block (ID, file, line, rule ID, blocking, fix) for agent fix loops. - Every run leaves a trace in the commit status and job summary, even with zero findings. ## Commit status and override (DOCS-1407) - `docs` status on every commit, outcomes `finding`, `clean`, `error`, `skipped`. - An approving review from a `@coder/docs` member overrides to success. - The override carries forward while later commits pass. - A later failing commit re-requests review from the approver, then `@coder/docs` after one business day. The engineer can still merge. - Rollout: report-only for a few weeks, then required for accuracy and missing docs once blocking false positives are at or under 5%, then for rule-anchored consistency and audience. ## Personas One orchestrator chat with sub-agents, each loading only its rule slice. IDs match the job; display names are editorial titles. | ID | Name | Job | |---|---|---| | `accuracy` | Fact Checker | Every docs claim is supported by the code | | `coverage` | Cartographer | Undocumented behavior, and docs for nonexistent behavior | | `learner` | Newcomer | Reads only post-merge docs, reports what it learned, compared against a code-derived change summary | | `consistency` | Continuity Editor | Terms and facts agree across and within pages | | `audience` | Reader Advocate | UI before API, reader task before internals, page type fits | | `structure` | Architect | Headings, procedures, prerequisites, placement | | `language` | Copy Editor | Word choice, sentence shape, mechanics beyond Vale | | `verifier` | Skeptic | Re-checks every finding's evidence | Language and consistency can skip when the PR changes no prose. The persona list grows as needed. ## Rules - `docs/.style/` is the single human-readable rule source. Fix conflicting text in `.claude/docs/DOCS_STYLE_GUIDE.md` and the doc-check skill first (semicolons, unit spacing, "see"). - Each style-guide page lists `review-personas` in front matter. Each rule heading carries a stable ID anchor. The bot resolves rules by ID and front matter, never by path. - Calibration answers that differ from the guide become style-guide PRs before a persona relies on them, and the calibration sentences become persona test cases. ## Ethos captured so far - Test for implementation detail: keep it only if it changes what the reader sees, types, or must do. - UI label leads; the API field appears once as "In the API, ..."; frontmatter keys only where the reader types them. - "Did I learn the thing this PR changes?" is the core reading test. - Always block: typos, markup that breaks rendering, wrong claims, unsupported compliance claims, multiple actions in one step (STE), "See [link]" with non-descriptive link text, missing prerequisites, inconsistent terms, user-facing implementation narrative, missing docs for a flag that changes a user task. - Suggest: "simply" (rewrite the step), passive voice (make the actor the subject), long multi-condition sentences, semicolons, "now" (replace with the condition that makes the action possible), `as` or `since` for cause (use "because"), niche flags without guide coverage. - Latin: never block. On a line that changes for another reason, suggest "for example" in place of "e.g.". The accepted forms are `(e.g., ...)` and `(for example, ...)`. ## Architecture - `coder/coder` holds the Markdown: skill, personas, rules. - Private `coder/doc-check` holds everything else as a hosted GitHub App: orchestration, status, override, re-request, slash commands, verdict parsing, replay harness, persona-to-model map. - Authoring agents run the same skill locally before opening or updating a PR (required in `AGENTS.md` and `write-docs`). - Review chats are shared with `@coder/docs`, not the whole organization. ## Models - Live PRs: Solstice-1 with cloud fallback. Record whether fallback happened on each run and why. - Replay and calibration: Solstice-1 Local (no cloud fallback) so data stays clean. - Persona-to-model map in the bot repo. A persona moves to a different local model only when replay scores show it is better for that persona. - Opus only through `/doc-check model:opus` and in the manual replay. ## Replay set (DOCS-923) - Run manually, never per commit. - Contents: the 48-PR benchmark from #29194 if recoverable, #31159, #31164, the large Vale PRs, confirmed `/doc-check wrong` reports, and calibration cases. - Reports Solstice and Opus scores side by side per persona. ## Calibration set 2 decisions - Open PRs that would change a claim in this PR are scanned and named in the summary. They never block. - External claims (other products) never block. Suggest narrowing to what was checked, linking vendor docs, or adding a product test that fails if the claim breaks. - New rule: when a docs claim depends on product behavior, recommend a test in the product that fails if the claim stops being true. - New page rule: block a page that is not in `docs/manifest/` unless its front matter has `draft: true`, and block a page that is in the manifest while its front matter has `draft: true`. No page on main uses `draft: true` and the manifest tooling doesn't read it today, so the convention needs defining first. - Admin-only settings: block when they're documented only under `docs/user-guides/`, and require that some page covers them. - Stale screenshots: block when the image contradicts a step on the page, otherwise harvest. Long term, generated screenshots replace hand captures (P-DOCS-174, DOCS-1408). - Inclusive wording: replace "non-native readers" in the style guide with wording about readability and translation. ## Open - Calibration set 2: items Nick didn't answer keep my bracketed guess. - How `coder-agents-review-bot` is hosted, to model the doc-check service on it. - How to detect cloud fallback per chat (per-message model config or provider metadata). - Commit status versus check run. ## Overnight decisions (made without Nick; override any of these) Each entry: the decision, why, and how to undo it. ### Linear 1. **DOCS-1409** "native" wording: separate issue in the Docs style guide project, Medium, 2 points. Not fixed in the PR, because Nick asked for a separate issue. The Latin rewrite drops one "non-native readers" sentence only because that paragraph was rewritten anyway. 2. **DOCS-1412** `draft: true`: sub-issue of DOCS-918, Medium, 3 points. Scoped as a deterministic check in `docsmanifestgen`, not an LLM rule, because blocking rules should be deterministic. 3. **DOCS-1411** Pixel screenshots: in Automated screenshot capture (P-DOCS-174), Medium, 5 points, related to DOCS-45 and DOCS-1408. Pixel replaces the Playwright proof of concept for anything a Storybook story renders; Playwright stays for flows that need a live deployment. The project summary is unchanged. 4. **DOCS-1410** for this PR: sub-issue of DOCS-918, High, 5 points, In Progress. 5. **DOCS-1413** stable rule IDs: deferred out of this PR, because IDs for 90 rules plus a `styleclaims` check is its own reviewable change. ### PR scope 6. One PR for skills plus style guide, because the persona front matter and the skill depend on each other. Out of scope: the hosted bot, commit statuses, replay harness, slash commands, sharing chats with `@coder/docs`. 7. Personas are files in `.claude/skills/doc-check/personas/` with the agreed names. 8. `review-personas` front matter on `content-guidelines.md` and eight style-guide pages, documented in `docs/.style/README.md`. Single-line list form so a plain `grep` finds it. `editor-setup.md` and the READMEs get none, because they hold no rules. 9. Mapping: content guidelines to accuracy, coverage, audience, structure. Audience and scope to audience, learner, structure. Word choice to language, consistency, accuracy. Procedural writing and formatting to structure, language. Capitalization and punctuation to language, structure. Accessibility and inclusion to language, structure, audience. Voice and tone, and numbers, to language. 10. CI reads the skill from the base branch, so a PR can't rewrite its own review. Author self-check reads it from the branch. 11. Sub-agents run only when the workflow passes a model config ID (`vars.DOC_CHECK_MODEL_CONFIG_ID`), so a run never mixes models. Otherwise personas run sequentially. 12. Posting: one `COMMENT` review with inline comments, plus the existing sticky summary comment and marker, because the Slack notice and re-review logic depend on the marker. Findings for agents go in a collapsed YAML block in the summary. 13. The footer tells authors to reply in the thread when a finding is wrong. `/doc-check wrong` isn't advertised, because it doesn't exist yet. 14. The run trace is a YAML block at the end of the final chat message, so DOCS-1407 can parse it into a commit status later. 15. Deterministic checks run first. A failing check on a changed line blocks. 16. The 40-minute wait timeout is unchanged. Eight personas on Solstice may run longer, so watch for timeouts after merge. Raising it is a one-line change. ### Style guide content 17. Latin abbreviations: `(e.g., ...)` and `(for example, ...)` are both accepted. The comma form is a Don't example but never blocks. Reviewers suggest the English form only when the line changes for another reason. `etc.` stays accepted in prose, because Ben's position was to accept Latin abbreviations. Nick's personal "tables only" preference is not encoded. 18. `as` row added to Choose words that have one meaning, documentation-only, because `as` has too many correct uses for a Vale word list. 19. New rule: Describe conditions, not moments in time (voice and tone). `now` stays allowed for progress inside a sequenced tutorial, because word choice already uses "Now that you added a language". 20. New rule: Lead with the surface the reader uses (audience and scope), with the #31159 sentence as the Don't example. Tutorials that mirror UI and CLI paths keep both. 21. Coverage counts updated from 88 to 90 rules. `make lint/style-claims` verifies them. 22. Content guidelines: one paragraph under Programmatic content asking for a product test when no test pins a documented behavior, which backs the "recommend a test" rule. 23. `.claude/docs/DOCS_STYLE_GUIDE.md`: removed the semicolon recommendation, "See" as a navigation verb (kept "See which applications", which describes the UI), and a bare `150ms` threshold (now in code font, matching the content guidelines). 24. write-docs: whole-path tracing, checking the PR description against the code, naming the persona, leading with the reader's surface, running doc-check before the PR, two anti-patterns, two checklist items, and a fix for the stale "Premium pages carry the title suffix" item. 25. AGENTS.md: one workflow bullet requiring the doc-check self-check before PRs that touch `docs/` or user-facing behavior. ### Evaluation 26. Eval set: #31159 (known defects) and #31164 (known clean). Solstice-1 Local for tuned runs, Sonnet 5.5 as the comparison. PR heads checked out read-only, nothing posted. 27. Changes after the first eval: both models missed the contradiction between the new section and an older section of the same page, and Solstice filed the download gap and the silently ignored quoted value as `adjacent`. The Continuity Editor now reads the whole page first, "the change caused it" includes paths the change didn't edit, and only class 4 findings need a style rule to block. Risk: the coverage example mentions downloads, which comes from #31159, so the v2 rerun on #31159 overstates the improvement. The replay set (DOCS-923) is the real test. </details> > Generated by Coder Agents on behalf of @nickvigilante. |
||
|
|
14f66c0b07 |
ci: raise the Linux Go temp dir tmpfs to 16g (#31115)
Closes GRU-42 `test-go-race-pg` failed on `main` whilst linking a test binary: ``` /usr/bin/ld: final link failed: No space left on device FAIL github.com/coder/coder/v2/coderd/x/gitsync [build failed] ``` https://github.com/coder/coder/actions/runs/39546966484/job/119047324357 The disk that filled up was the 8g tmpfs we mount at `GOTMPDIR` (#28919), not the root disk. `go test` puts its `$WORK` dir under `GOTMPDIR`, `ld` writes the test binary there, and every compiled package archive stays in `$WORK` until `go test` exits. With a warm build cache there's barely anything to compile, so this peaks at about 1.1 GiB. With a cold cache, a `-race -p 4` build of our test packages peaked at 8.06 GiB locally, and that's without running a single test or writing anything to `t.TempDir()`. (The flake bot blamed the linker's `/tmp/go-link-*` scratch dir on the root disk, but `ld` wrote to that just fine. Pointing `TMPDIR` at the tmpfs would only make this worse.) Our build cache comes from Depot (their runners preset `GOCACHEPROG` to `depot gocache`), and in this run it mostly missed: 92 `(cached)` results, versus 228 and 263 in the runs either side, with only docs commits in between. I'm not sure why. All 8 `test-go-race-pg` ENOSPC failures I found this month had a cold cache like this. To fix, we'll just raise the tmpfs to 16g. `size=` is only a limit; tmpfs takes RAM only for files that actually exist, so a bigger limit uses no memory until something writes that much data. There were also two ENOSPC failures in the non-race jobs on 2026-10-09 with a warm cache, which I can't explain. |
||
|
|
23c7f1fa61 |
ci: bump the github-actions group with 5 updates (#31052)
Bumps the github-actions group with 5 updates: | Package | From | To | | --- | --- | --- | | [actions/create-github-app-token](https://github.com/actions/create-github-app-token) | `3.2.0` | `3.3.0` | | [ossf/scorecard-action](https://github.com/ossf/scorecard-action) | `2.4.4` | `2.5.0` | | [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) | `4.38.2` | `4.38.3` | | [github/codeql-action/init](https://github.com/github/codeql-action) | `4.38.2` | `4.38.3` | | [github/codeql-action/analyze](https://github.com/github/codeql-action) | `4.38.2` | `4.38.3` | Updates `actions/create-github-app-token` from 3.2.0 to 3.3.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/create-github-app-token/releases">actions/create-github-app-token's releases</a>.</em></p> <blockquote> <h2>v3.3.0</h2> <h2><a href="https://github.com/actions/create-github-app-token/compare/v3.2.0...v3.3.0">3.3.0</a> (2026-10-12)</h2> <h3>Features</h3> <ul> <li>update permission inputs (<a href="https://redirect.github.com/actions/create-github-app-token/issues/399">#399</a>) (<a href="https://github.com/actions/create-github-app-token/commit/a47236f79f79fcbc3532af49fe3a5ded89529b6e">a47236f</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>deps:</strong> bump nested undici from 6.24.0 to 6.29.0 (<a href="https://redirect.github.com/actions/create-github-app-token/issues/403">#403</a>) (<a href="https://github.com/actions/create-github-app-token/commit/12461a3a794e67c032f1eff5bb95ece9427eb4fb">12461a3</a>)</li> <li><strong>deps:</strong> bump the production-dependencies group across 1 directory with 3 updates (<a href="https://redirect.github.com/actions/create-github-app-token/issues/395">#395</a>) (<a href="https://github.com/actions/create-github-app-token/commit/a69c19ddfdf8e1ab093900e0064524ce9309c807">a69c19d</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/create-github-app-token/blob/main/CHANGELOG.md">actions/create-github-app-token's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2><a href="https://github.com/actions/create-github-app-token/compare/v3.2.0...v3.3.0">3.3.0</a> (2026-10-12)</h2> <h3>Features</h3> <ul> <li>update permission inputs (<a href="https://redirect.github.com/actions/create-github-app-token/issues/399">#399</a>) (<a href="https://github.com/actions/create-github-app-token/commit/a47236f79f79fcbc3532af49fe3a5ded89529b6e">a47236f</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>deps:</strong> bump nested undici from 6.24.0 to 6.29.0 (<a href="https://redirect.github.com/actions/create-github-app-token/issues/403">#403</a>) (<a href="https://github.com/actions/create-github-app-token/commit/12461a3a794e67c032f1eff5bb95ece9427eb4fb">12461a3</a>)</li> <li><strong>deps:</strong> bump the production-dependencies group across 1 directory with 3 updates (<a href="https://redirect.github.com/actions/create-github-app-token/issues/395">#395</a>) (<a href="https://github.com/actions/create-github-app-token/commit/a69c19ddfdf8e1ab093900e0064524ce9309c807">a69c19d</a>)</li> </ul> <h2><a href="https://github.com/actions/create-github-app-token/compare/v3.1.1...v3.2.0">3.2.0</a> (2026-05-12)</h2> <h3>Features</h3> <ul> <li>add support for enterprise-level GitHub Apps (<a href="https://redirect.github.com/actions/create-github-app-token/issues/263">#263</a>) (<a href="https://github.com/actions/create-github-app-token/commit/952a2a7073df6bfa5f49bc469ec895b6ec1acea4">952a2a7</a>)</li> <li>support full repository names in <code>repositories</code> input (<a href="https://redirect.github.com/actions/create-github-app-token/issues/372">#372</a>) (<a href="https://github.com/actions/create-github-app-token/commit/85eb8dd41472213aed25d1a126460e0069138ab6">85eb8dd</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>deps:</strong> bump <code>@actions/core</code> from 3.0.0 to 3.0.1 in the production-dependencies group (<a href="https://redirect.github.com/actions/create-github-app-token/issues/364">#364</a>) (<a href="https://github.com/actions/create-github-app-token/commit/43e5c345bfd4d4f3ecea019ad0042001a09dd857">43e5c34</a>)</li> <li>validate private-key input (<a href="https://redirect.github.com/actions/create-github-app-token/issues/376">#376</a>) (<a href="https://github.com/actions/create-github-app-token/commit/f24bbd89643991c0de27ae823c01791b2c6bafdd">f24bbd8</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/create-github-app-token/commit/64ab729a6294000f5aa4a4bc0b73d1f32bc45510"><code>64ab729</code></a> chore(main): release 3.3.0 (<a href="https://redirect.github.com/actions/create-github-app-token/issues/402">#402</a>)</li> <li><a href="https://github.com/actions/create-github-app-token/commit/f3a828e4b91180d3a46ac1f4b43fa8384b0dea07"><code>f3a828e</code></a> ci: create signed dist commits in release workflow (<a href="https://redirect.github.com/actions/create-github-app-token/issues/404">#404</a>)</li> <li><a href="https://github.com/actions/create-github-app-token/commit/655017ffa7c6b0c6e4210729fa6bce35cacd8ca0"><code>655017f</code></a> docs: clarify when owner grants access to all repositories (<a href="https://redirect.github.com/actions/create-github-app-token/issues/378">#378</a>)</li> <li><a href="https://github.com/actions/create-github-app-token/commit/12461a3a794e67c032f1eff5bb95ece9427eb4fb"><code>12461a3</code></a> fix(deps): bump nested undici from 6.24.0 to 6.29.0 (<a href="https://redirect.github.com/actions/create-github-app-token/issues/403">#403</a>)</li> <li><a href="https://github.com/actions/create-github-app-token/commit/a47236f79f79fcbc3532af49fe3a5ded89529b6e"><code>a47236f</code></a> feat: update permission inputs (<a href="https://redirect.github.com/actions/create-github-app-token/issues/399">#399</a>)</li> <li><a href="https://github.com/actions/create-github-app-token/commit/a69c19ddfdf8e1ab093900e0064524ce9309c807"><code>a69c19d</code></a> fix(deps): bump the production-dependencies group across 1 directory with 3 u...</li> <li><a href="https://github.com/actions/create-github-app-token/commit/d5cb7ae41d64331820d88810a4878e0942ec992a"><code>d5cb7ae</code></a> build(deps): bump actions/checkout from 6 to 7 (<a href="https://redirect.github.com/actions/create-github-app-token/issues/384">#384</a>)</li> <li><a href="https://github.com/actions/create-github-app-token/commit/575da866bd0a42d7f234a8645831d55573252b09"><code>575da86</code></a> build(deps): bump stefanzweifel/git-auto-commit-action from 7.1.0 to 7.2.0 in...</li> <li><a href="https://github.com/actions/create-github-app-token/commit/e85f677b44da0d1f08115ce52cdfd8fd2c69874a"><code>e85f677</code></a> test: omit stack traces from snapshots (<a href="https://redirect.github.com/actions/create-github-app-token/issues/401">#401</a>)</li> <li><a href="https://github.com/actions/create-github-app-token/commit/9419396df4d5672241cfb593dadc19758e54a204"><code>9419396</code></a> build(deps-dev): bump c8 from 11.0.0 to 12.0.0 (<a href="https://redirect.github.com/actions/create-github-app-token/issues/400">#400</a>)</li> <li>Additional commits viewable in <a href="https://github.com/actions/create-github-app-token/compare/bcd2ba49218906704ab6c1aa796996da409d3eb1...64ab729a6294000f5aa4a4bc0b73d1f32bc45510">compare view</a></li> </ul> </details> <br /> Updates `ossf/scorecard-action` from 2.4.4 to 2.5.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p> <blockquote> <h2>v2.5.0</h2> <h2>What's Changed</h2> <p>This release moves the action to Scorecard v5.6.0, the first Scorecard release since its hosted services moved to new infrastructure.</p> <p>For changes to checks and results, and what the infrastructure move means for you, see the <a href="https://github.com/ossf/scorecard/releases/tag/v5.6.0">Scorecard v5.6.0 release notes</a>.</p> <ul> <li>The action's container image is built with Go 1.27.2 on a refreshed distroless base. by <a href="https://github.com/justaugustus"><code>@justaugustus</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1716">ossf/scorecard-action#1716</a></li> <li>The installer (<code>cmd/installer</code>) now creates <code>.github/workflows/scorecard.yml</code>, and still recognizes existing <code>scorecards.yml</code> and <code>scorecards-analysis.yml</code> workflows. by <a href="https://github.com/justaugustus"><code>@justaugustus</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1716">ossf/scorecard-action#1716</a></li> <li>The Scorecard version in results now always matches the Scorecard release the action is built with. by <a href="https://github.com/justaugustus"><code>@justaugustus</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1718">ossf/scorecard-action#1718</a></li> <li>The action no longer prints the GitHub token variable while validating its options. by <a href="https://github.com/arpitjain099"><code>@arpitjain099</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1709">ossf/scorecard-action#1709</a></li> <li><code>results_format</code> accepts <code>intoto</code>, which wraps the JSON results in an in-toto attestation statement. by <a href="https://github.com/puerco"><code>@puerco</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1702">ossf/scorecard-action#1702</a></li> </ul> <h3>Other</h3> <ul> <li>Add a daily canary against Scorecard main by <a href="https://github.com/justaugustus"><code>@justaugustus</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1711">ossf/scorecard-action#1711</a></li> <li>Bump Scorecard to the v5.6.0 candidate and fix the canary toolchain by <a href="https://github.com/justaugustus"><code>@justaugustus</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1714">ossf/scorecard-action#1714</a></li> <li>Run Scorecard on every merge, add a zizmor presubmit, analyze workflows with CodeQL, and update RELEASE.md by <a href="https://github.com/justaugustus"><code>@justaugustus</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1716">ossf/scorecard-action#1716</a></li> <li>Bump Scorecard to v5.6.0 by <a href="https://github.com/justaugustus"><code>@justaugustus</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1719">ossf/scorecard-action#1719</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/arpitjain099"><code>@arpitjain099</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1709">ossf/scorecard-action#1709</a></li> <li><a href="https://github.com/puerco"><code>@puerco</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1702">ossf/scorecard-action#1702</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.4.4...v2.5.0">https://github.com/ossf/scorecard-action/compare/v2.4.4...v2.5.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ossf/scorecard-action/commit/fa7117db83c52d787ae5a89f350999701505d78e"><code>fa7117d</code></a> Bump action tag for v2.5.0 release (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1720">#1720</a>)</li> <li><a href="https://github.com/ossf/scorecard-action/commit/cef4eb5d6088e4adcf03f9d62997f3bb26a8f09c"><code>cef4eb5</code></a> 🌱 Bump Scorecard to v5.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1719">#1719</a>)</li> <li><a href="https://github.com/ossf/scorecard-action/commit/bedb16e17db10ec69e7ee324652b5fe4a1ef05fe"><code>bedb16e</code></a> ✨ Add intoto results format (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1702">#1702</a>)</li> <li><a href="https://github.com/ossf/scorecard-action/commit/de70347fd7cf68f25ffab60983dd64a81bc10c77"><code>de70347</code></a> Remove the leftover debug print of the auth token (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1709">#1709</a>)</li> <li><a href="https://github.com/ossf/scorecard-action/commit/950873de57049dbae181637f165e7992d3f63d0a"><code>950873d</code></a> 🌱 Derive the reported Scorecard version from go.mod (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1718">#1718</a>)</li> <li><a href="https://github.com/ossf/scorecard-action/commit/2ce8ee42fdf35edce28a64fa8a6cfc162ba359e7"><code>2ce8ee4</code></a> 🌱 Bump github.com/sigstore/cosign/v2 from 2.6.4 to 2.6.5 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1695">#1695</a>)</li> <li><a href="https://github.com/ossf/scorecard-action/commit/aabdf5ad3b10f2d6c993d6fb177a301fd6bb0db9"><code>aabdf5a</code></a> 🌱 Bump the github-actions group across 1 directory with 7 updates (#...</li> <li><a href="https://github.com/ossf/scorecard-action/commit/b4b9adf9b43b304ae7e11c3fdec496a1a437052f"><code>b4b9adf</code></a> 🌱 CodeQL: Analyze workflows instead of a placeholder JavaScript file</li> <li><a href="https://github.com/ossf/scorecard-action/commit/4e9f2a270106ff88d667a0490660d05e2f1adb04"><code>4e9f2a2</code></a> 📖 RELEASE.md: Document drafting release notes</li> <li><a href="https://github.com/ossf/scorecard-action/commit/f618e8bbfd5d42b160e1e8a472e5efd90e6a15ea"><code>f618e8b</code></a> 🌱 Build the image with Go 1.27.2 and refresh distroless</li> <li>Additional commits viewable in <a href="https://github.com/ossf/scorecard-action/compare/2d1146689b8cda280b9bc96326124645441f03bc...fa7117db83c52d787ae5a89f350999701505d78e">compare view</a></li> </ul> </details> <br /> Updates `github/codeql-action/upload-sarif` from 4.38.2 to 4.38.3 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action/upload-sarif's releases</a>.</em></p> <blockquote> <h2>v4.38.3</h2> <ul> <li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li> <li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action/upload-sarif's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>4.39.0 - 15 Oct 2026</h2> <ul> <li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li> <li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li> <li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li> <li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li> </ul> <h2>4.38.3 - 08 Oct 2026</h2> <ul> <li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li> <li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li> </ul> <h2>4.38.2 - 24 Sept 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.1">2.27.1</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4160">#4160</a></li> </ul> <h2>4.38.1 - 18 Sept 2026</h2> <ul> <li>The CodeQL Action now has experimental support for CodeQL releases for which per-language bundles are available. Per-language bundles support analysis for a single language and are therefore smaller than the combined bundles that allow analysis for all supported languages. As a result, per-language bundles take up less space on disk and are faster to download. We expect to roll this change out to everyone in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4146">#4146</a></li> </ul> <h2>4.38.0 - 09 Sept 2026</h2> <ul> <li>On GitHub-hosted runners, the CodeQL Action now deletes unused CodeQL bundles from the toolcache before downloading a different bundle, which frees up disk space for the analysis. We expect to roll this change out to everyone in September. <a href="https://redirect.github.com/github/codeql-action/pull/4124">#4124</a></li> <li>The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and downloads the native <code>linux-arm64</code> CodeQL bundle when available. <a href="https://redirect.github.com/github/codeql-action/pull/4072">#4072</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.0">2.27.0</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4129">#4129</a></li> </ul> <h2>4.37.9 - 26 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li> </ul> <h2>4.37.8 - 21 Aug 2026</h2> <p>No user facing changes.</p> <h2>4.37.7 - 13 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.3">2.26.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4085">#4085</a></li> </ul> <h2>4.37.6 - 04 Aug 2026</h2> <ul> <li>Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to <code>.github/codeql-config.yml</code> to align it with the suggested path that is used elsewhere. <a href="https://redirect.github.com/github/codeql-action/pull/4070">#4070</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/24c54180a607b1449ed407dd24f251e4e9147c8d"><code>24c5418</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4214">#4214</a> from github/update-v4.38.3-e0b52dbdc</li> <li><a href="https://github.com/github/codeql-action/commit/69e87c56c1db5253592f61da177da1d20d033bd8"><code>69e87c5</code></a> Add changelog note for <a href="https://redirect.github.com/github/codeql-action/issues/4184">#4184</a></li> <li><a href="https://github.com/github/codeql-action/commit/23b682830be5e93afb6466bfc0197142d70268aa"><code>23b6828</code></a> Update changelog for v4.38.3</li> <li><a href="https://github.com/github/codeql-action/commit/e0b52dbdc5c3376dd8cb78e956fd23fa07ca2c5b"><code>e0b52db</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4210">#4210</a> from github/henrymercer/pin-python-for-older-clis-in-ci</li> <li><a href="https://github.com/github/codeql-action/commit/6b99698c8cda6115e2bc7c52226b508dc558d7dc"><code>6b99698</code></a> Pin Python 3.13.15 for older CLI versions in multi-language check</li> <li><a href="https://github.com/github/codeql-action/commit/63d3d632fc7cbd91c8089c7fea5322f1bc73d7d8"><code>63d3d63</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4203">#4203</a> from github/update-bundle/codeql-bundle-v2.27.2</li> <li><a href="https://github.com/github/codeql-action/commit/7377a10091aa5d781c1d36dc3834817d8ad0acfe"><code>7377a10</code></a> Add changelog note</li> <li><a href="https://github.com/github/codeql-action/commit/c1a30cda114f23a88a09ab61f4ec08c312d2c524"><code>c1a30cd</code></a> Update default bundle to codeql-bundle-v2.27.2</li> <li><a href="https://github.com/github/codeql-action/commit/d208ec71e39ae46397cbf6569bef8439b9aab974"><code>d208ec7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4200">#4200</a> from github/mbg/esm/migrate-pr-checks</li> <li><a href="https://github.com/github/codeql-action/commit/a71b0c6684dea6ca627a472a11bf5b80bd47c845"><code>a71b0c6</code></a> Replace <code>__dirname</code> in <code>sync.ts</code></li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2...24c54180a607b1449ed407dd24f251e4e9147c8d">compare view</a></li> </ul> </details> <br /> Updates `github/codeql-action/init` from 4.38.2 to 4.38.3 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action/init's releases</a>.</em></p> <blockquote> <h2>v4.38.3</h2> <ul> <li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li> <li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action/init's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>4.39.0 - 15 Oct 2026</h2> <ul> <li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li> <li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li> <li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li> <li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li> </ul> <h2>4.38.3 - 08 Oct 2026</h2> <ul> <li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li> <li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li> </ul> <h2>4.38.2 - 24 Sept 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.1">2.27.1</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4160">#4160</a></li> </ul> <h2>4.38.1 - 18 Sept 2026</h2> <ul> <li>The CodeQL Action now has experimental support for CodeQL releases for which per-language bundles are available. Per-language bundles support analysis for a single language and are therefore smaller than the combined bundles that allow analysis for all supported languages. As a result, per-language bundles take up less space on disk and are faster to download. We expect to roll this change out to everyone in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4146">#4146</a></li> </ul> <h2>4.38.0 - 09 Sept 2026</h2> <ul> <li>On GitHub-hosted runners, the CodeQL Action now deletes unused CodeQL bundles from the toolcache before downloading a different bundle, which frees up disk space for the analysis. We expect to roll this change out to everyone in September. <a href="https://redirect.github.com/github/codeql-action/pull/4124">#4124</a></li> <li>The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and downloads the native <code>linux-arm64</code> CodeQL bundle when available. <a href="https://redirect.github.com/github/codeql-action/pull/4072">#4072</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.0">2.27.0</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4129">#4129</a></li> </ul> <h2>4.37.9 - 26 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li> </ul> <h2>4.37.8 - 21 Aug 2026</h2> <p>No user facing changes.</p> <h2>4.37.7 - 13 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.3">2.26.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4085">#4085</a></li> </ul> <h2>4.37.6 - 04 Aug 2026</h2> <ul> <li>Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to <code>.github/codeql-config.yml</code> to align it with the suggested path that is used elsewhere. <a href="https://redirect.github.com/github/codeql-action/pull/4070">#4070</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/24c54180a607b1449ed407dd24f251e4e9147c8d"><code>24c5418</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4214">#4214</a> from github/update-v4.38.3-e0b52dbdc</li> <li><a href="https://github.com/github/codeql-action/commit/69e87c56c1db5253592f61da177da1d20d033bd8"><code>69e87c5</code></a> Add changelog note for <a href="https://redirect.github.com/github/codeql-action/issues/4184">#4184</a></li> <li><a href="https://github.com/github/codeql-action/commit/23b682830be5e93afb6466bfc0197142d70268aa"><code>23b6828</code></a> Update changelog for v4.38.3</li> <li><a href="https://github.com/github/codeql-action/commit/e0b52dbdc5c3376dd8cb78e956fd23fa07ca2c5b"><code>e0b52db</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4210">#4210</a> from github/henrymercer/pin-python-for-older-clis-in-ci</li> <li><a href="https://github.com/github/codeql-action/commit/6b99698c8cda6115e2bc7c52226b508dc558d7dc"><code>6b99698</code></a> Pin Python 3.13.15 for older CLI versions in multi-language check</li> <li><a href="https://github.com/github/codeql-action/commit/63d3d632fc7cbd91c8089c7fea5322f1bc73d7d8"><code>63d3d63</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4203">#4203</a> from github/update-bundle/codeql-bundle-v2.27.2</li> <li><a href="https://github.com/github/codeql-action/commit/7377a10091aa5d781c1d36dc3834817d8ad0acfe"><code>7377a10</code></a> Add changelog note</li> <li><a href="https://github.com/github/codeql-action/commit/c1a30cda114f23a88a09ab61f4ec08c312d2c524"><code>c1a30cd</code></a> Update default bundle to codeql-bundle-v2.27.2</li> <li><a href="https://github.com/github/codeql-action/commit/d208ec71e39ae46397cbf6569bef8439b9aab974"><code>d208ec7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4200">#4200</a> from github/mbg/esm/migrate-pr-checks</li> <li><a href="https://github.com/github/codeql-action/commit/a71b0c6684dea6ca627a472a11bf5b80bd47c845"><code>a71b0c6</code></a> Replace <code>__dirname</code> in <code>sync.ts</code></li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2...24c54180a607b1449ed407dd24f251e4e9147c8d">compare view</a></li> </ul> </details> <br /> Updates `github/codeql-action/analyze` from 4.38.2 to 4.38.3 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action/analyze's releases</a>.</em></p> <blockquote> <h2>v4.38.3</h2> <ul> <li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li> <li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action/analyze's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>4.39.0 - 15 Oct 2026</h2> <ul> <li><em>Breaking change</em>: Bump the minimum required CodeQL bundle version to 2.20.7. <a href="https://redirect.github.com/github/codeql-action/pull/4205">#4205</a></li> <li>The <code>codeql-action/analyze</code> step now validates that a correct argument for the <code>checkout_path</code> input has been provided. The <code>checkout_path</code> input must be set to the path where the repository that is being analyzed is checked out at on the runner, if that path is something other than the workspace root. If the path does not point to a repository checkout or is different from the path that was used by <code>codeql-action/init</code>, then the CodeQL Action now produces a warning. <a href="https://redirect.github.com/github/codeql-action/pull/4148">#4148</a></li> <li>Resolved an issue with third-party caching implementations that prevented caches from being restored correctly. <a href="https://redirect.github.com/github/codeql-action/pull/4206">#4206</a></li> <li>The <code>codeql-action/start-proxy</code> step that is used in Code Scanning Default Setup now finds CodeQL releases using the same logic as <code>codeql-action/init</code>. This primarily benefits customers who are using GitHub instances other than <code>github.com</code> where the <code>codeql-action/start-proxy</code> step may previously have been unable to locate recent releases and ended up using outdated versions of the private registry authentication proxy as a result. <a href="https://redirect.github.com/github/codeql-action/pull/4198">#4198</a></li> </ul> <h2>4.38.3 - 08 Oct 2026</h2> <ul> <li><em>Upcoming breaking change</em>: CodeQL version 2.21.2 and earlier were discontinued on 24 September 2026 alongside GitHub Enterprise Server 3.17, and will be unsupported by the next minor release of the CodeQL Action. Added a deprecation warning for customers using these versions of CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/4188">#4188</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.2">2.27.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4203">#4203</a></li> <li>Fixed a bug where the decision of whether to use a per-language bundle did not account for custom configurations that reference queries outside of compiled CodeQL packs. This issue was caught during internal testing and did not affect any customer repositories. We will resume the roll out of per-language bundles in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4184">#4184</a></li> </ul> <h2>4.38.2 - 24 Sept 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.1">2.27.1</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4160">#4160</a></li> </ul> <h2>4.38.1 - 18 Sept 2026</h2> <ul> <li>The CodeQL Action now has experimental support for CodeQL releases for which per-language bundles are available. Per-language bundles support analysis for a single language and are therefore smaller than the combined bundles that allow analysis for all supported languages. As a result, per-language bundles take up less space on disk and are faster to download. We expect to roll this change out to everyone in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4146">#4146</a></li> </ul> <h2>4.38.0 - 09 Sept 2026</h2> <ul> <li>On GitHub-hosted runners, the CodeQL Action now deletes unused CodeQL bundles from the toolcache before downloading a different bundle, which frees up disk space for the analysis. We expect to roll this change out to everyone in September. <a href="https://redirect.github.com/github/codeql-action/pull/4124">#4124</a></li> <li>The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and downloads the native <code>linux-arm64</code> CodeQL bundle when available. <a href="https://redirect.github.com/github/codeql-action/pull/4072">#4072</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.0">2.27.0</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4129">#4129</a></li> </ul> <h2>4.37.9 - 26 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li> </ul> <h2>4.37.8 - 21 Aug 2026</h2> <p>No user facing changes.</p> <h2>4.37.7 - 13 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.3">2.26.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4085">#4085</a></li> </ul> <h2>4.37.6 - 04 Aug 2026</h2> <ul> <li>Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to <code>.github/codeql-config.yml</code> to align it with the suggested path that is used elsewhere. <a href="https://redirect.github.com/github/codeql-action/pull/4070">#4070</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/24c54180a607b1449ed407dd24f251e4e9147c8d"><code>24c5418</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4214">#4214</a> from github/update-v4.38.3-e0b52dbdc</li> <li><a href="https://github.com/github/codeql-action/commit/69e87c56c1db5253592f61da177da1d20d033bd8"><code>69e87c5</code></a> Add changelog note for <a href="https://redirect.github.com/github/codeql-action/issues/4184">#4184</a></li> <li><a href="https://github.com/github/codeql-action/commit/23b682830be5e93afb6466bfc0197142d70268aa"><code>23b6828</code></a> Update changelog for v4.38.3</li> <li><a href="https://github.com/github/codeql-action/commit/e0b52dbdc5c3376dd8cb78e956fd23fa07ca2c5b"><code>e0b52db</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4210">#4210</a> from github/henrymercer/pin-python-for-older-clis-in-ci</li> <li><a href="https://github.com/github/codeql-action/commit/6b99698c8cda6115e2bc7c52226b508dc558d7dc"><code>6b99698</code></a> Pin Python 3.13.15 for older CLI versions in multi-language check</li> <li><a href="https://github.com/github/codeql-action/commit/63d3d632fc7cbd91c8089c7fea5322f1bc73d7d8"><code>63d3d63</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4203">#4203</a> from github/update-bundle/codeql-bundle-v2.27.2</li> <li><a href="https://github.com/github/codeql-action/commit/7377a10091aa5d781c1d36dc3834817d8ad0acfe"><code>7377a10</code></a> Add changelog note</li> <li><a href="https://github.com/github/codeql-action/commit/c1a30cda114f23a88a09ab61f4ec08c312d2c524"><code>c1a30cd</code></a> Update default bundle to codeql-bundle-v2.27.2</li> <li><a href="https://github.com/github/codeql-action/commit/d208ec71e39ae46397cbf6569bef8439b9aab974"><code>d208ec7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4200">#4200</a> from github/mbg/esm/migrate-pr-checks</li> <li><a href="https://github.com/github/codeql-action/commit/a71b0c6684dea6ca627a472a11bf5b80bd47c845"><code>a71b0c6</code></a> Replace <code>__dirname</code> in <code>sync.ts</code></li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2...24c54180a607b1449ed407dd24f251e4e9147c8d">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> |